ICEfaces
  1. ICEfaces
  2. ICE-3544

ice:selectInputDate: add optional time input fields to calendar component

          Details

          • Type: New Feature New Feature
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.7.1
          • Fix Version/s: 1.8RC1, 1.8
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            any
          • Affects:
            Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial

            Description

            Add time input fields to the calendar component.

              Activity

              Ascending order - Click to sort in descending order
              10 older comments
              Hide
              Permalink
              Adnan Durrani added a comment -

              Krashan Brahmanjara the popup calendar doesn't close on click is an intentional change its not a bug.

              Show
              Adnan Durrani added a comment - Krashan Brahmanjara the popup calendar doesn't close on click is an intentional change its not a bug.
              Hide
              Permalink
              Krashan Brahmanjara added a comment -

              OK Adnan. But my users and probably others may not accept this new behaviour

              • closing window on click worked well before , no problems occured, now app users see it as a bug or regression
              • almost all calendar implementation from js, jsp,jsf up to c++ ... do the same - user select date and calendar disappear.

              My vote - restore lines 1725-1735 or old behaviour.

              Show
              Krashan Brahmanjara added a comment - OK Adnan. But my users and probably others may not accept this new behaviour closing window on click worked well before , no problems occured, now app users see it as a bug or regression almost all calendar implementation from js, jsp,jsf up to c++ ... do the same - user select date and calendar disappear. My vote - restore lines 1725-1735 or old behaviour.
              Hide
              Permalink
              Krashan Brahmanjara added a comment -

              After some test I see that in current source from rev. 18425 only 1664-1670 lines should be uncommented to keep old behaviour.

              > if (showPopup != null) {
              > if (showPopup.equalsIgnoreCase("true"))

              { > dateSelect.setShowPopup(true); > }

              else

              { > dateSelect.setShowPopup(false); > }

              > }

              Rows 1710-1720 can be commented .

              Show
              Krashan Brahmanjara added a comment - After some test I see that in current source from rev. 18425 only 1664-1670 lines should be uncommented to keep old behaviour. > if (showPopup != null) { > if (showPopup.equalsIgnoreCase("true")) { > dateSelect.setShowPopup(true); > } else { > dateSelect.setShowPopup(false); > } > } Rows 1710-1720 can be commented .
              Hide
              Permalink
              Adnan Durrani added a comment -

              Changes made so:

              1. The popup will be closed automatically on selecting a date when there isn't any time input elements on the calendar (same as 1.7.2 behaviour)
              2. The popup will NOT be closed automatically on selecting a date, if there are time fields on the popup

              Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDateRenderer.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDateRenderer.java
              Completed: At revision: 18458

              Show
              Adnan Durrani added a comment - Changes made so: 1. The popup will be closed automatically on selecting a date when there isn't any time input elements on the calendar (same as 1.7.2 behaviour) 2. The popup will NOT be closed automatically on selecting a date, if there are time fields on the popup Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDateRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDateRenderer.java Completed: At revision: 18458
              Hide
              Permalink
              Mandeep Hayher added a comment -

              Following behaviour have been successfully verified on ICEFaces1.8 buil6 (Tomcat5 server, FF3, IE7 & Opera9.63 browsers)

              1. The popup will be closed automatically on selecting a date when there isn't any time input elements on the calendar (same as 1.7.2 behaviour)
              2. The popup will NOT be closed automatically on selecting a date, if there are time fields on the popup

              Show
              Mandeep Hayher added a comment - Following behaviour have been successfully verified on ICEFaces1.8 buil6 (Tomcat5 server, FF3, IE7 & Opera9.63 browsers) 1. The popup will be closed automatically on selecting a date when there isn't any time input elements on the calendar (same as 1.7.2 behaviour) 2. The popup will NOT be closed automatically on selecting a date, if there are time fields on the popup

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Michael Thiem
                • Votes:
                  6 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: