[ICE-3484] Optimize the rendering of the effect related JS handlers - ICEsoft JIRA Issue Tracker

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 1.8DR#2, 1.8
Component/s: ICE-Components
Labels:
None
Environment:
renderer + effect related JS handlers

Description

Currently the renderer of the component writes the JShandler, and then the following call rewrite them again. Which means it can re-invoke the value binding if exist.

LocalEffectEncoder
.encodeLocalEffects(uiComponent, attributeElement, facesContext);

Issue Links

depends on

ICE-3072 outputLabel outputText event handlers

Closed

ICE-3749 Add missing JS handler attributes to the ICE components which can be applied to the underling elements

Closed

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Mark Collette added a comment - 05/Sep/08 1:23 PM

Maybe the renderer could pass in a Map of what it wants to render to LocalEffectEncoder, where a map entry would look like "onclick" -> "iceSubmitPartial(...)". These could be statically defined, or dynamically generated if necessary.

LocalEffectEncoder could iterate over all the typical events, and combine the effect + user + framework Javascript, based on the on*effect attribute, the on* attribute, and the Map, respectively.

Also, it looks like some renderers invoke it directly, while it's also called from PassThruAttributeRenderer.renderHtmlAttributes, so we should probably make we're not double-invoking it that way too.

Show

Mark Collette added a comment - 05/Sep/08 1:23 PM Maybe the renderer could pass in a Map of what it wants to render to LocalEffectEncoder, where a map entry would look like "onclick" -> "iceSubmitPartial(...)". These could be statically defined, or dynamically generated if necessary. LocalEffectEncoder could iterate over all the typical events, and combine the effect + user + framework Javascript, based on the on*effect attribute, the on* attribute, and the Map, respectively. Also, it looks like some renderers invoke it directly, while it's also called from PassThruAttributeRenderer.renderHtmlAttributes, so we should probably make we're not double-invoking it that way too.

6 older comments

Hide

Permalink

Adnan Durrani added a comment - 05/Nov/08 2:29 PM

The following two components extend the renderer of the panelGroup component.
-panelPopup
-PanelTooltip

According to the TLD docs and the ExtendedAttributeConstants the above components have the following passThru attributes:

panelGroup { HTML.STYLE_ATTR };

- panelPopup { HTML.STYLE_ATTR, HTML.TITLE_ATTR };

- PanelTooltip{ HTML.STYLE_ATTR }

According to the TLD docs only the panelGroup has effect related attributes and it doesn't support any javascript related attribute which means that none of the component requires any change.

Show

Adnan Durrani added a comment - 05/Nov/08 2:29 PM The following two components extend the renderer of the panelGroup component. -panelPopup -PanelTooltip According to the TLD docs and the ExtendedAttributeConstants the above components have the following passThru attributes: panelGroup { HTML.STYLE_ATTR }; - panelPopup { HTML.STYLE_ATTR, HTML.TITLE_ATTR }; - PanelTooltip{ HTML.STYLE_ATTR } According to the TLD docs only the panelGroup has effect related attributes and it doesn't support any javascript related attribute which means that none of the component requires any change.

Hide

Permalink

Adnan Durrani added a comment - 06/Nov/08 10:21 PM

Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ExtendedAttributeConstants.java
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlPanelGroup.java
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\GroupRenderer.java
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\ice_properties\ice-panelGroup-props.xml
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\GroupRenderer.java
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\PassThruAttributeRenderer.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\GroupRenderer.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\ice_properties\ice-panelGroup-props.xml
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ExtendedAttributeConstants.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlPanelGroup.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\GroupRenderer.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\PassThruAttributeRenderer.java
Completed: At revision: 17873

I have also overloaded the following method :
public static String[] getAttributes(int index, String[] remove) {

signature of new overloaded method:
public static String[] getAttributes(int index, String[][] remove) {

It allows to pass more then one exclude arrays. (e.g.) Exclude the JS event as well as excluded attributes.

Show

Adnan Durrani added a comment - 06/Nov/08 10:21 PM Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ExtendedAttributeConstants.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlPanelGroup.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\GroupRenderer.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\ice_properties\ice-panelGroup-props.xml Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\GroupRenderer.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\PassThruAttributeRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\GroupRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\ice_properties\ice-panelGroup-props.xml Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ExtendedAttributeConstants.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlPanelGroup.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\GroupRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\PassThruAttributeRenderer.java Completed: At revision: 17873 I have also overloaded the following method : public static String[] getAttributes(int index, String[] remove) { signature of new overloaded method: public static String[] getAttributes(int index, String[][] remove) { It allows to pass more then one exclude arrays. (e.g.) Exclude the JS event as well as excluded attributes.

Hide

Permalink

Adnan Durrani added a comment - 06/Nov/08 11:43 PM

Changes applied to the panelPopup as well as panelTooltip.

Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ExtendedAttributeConstants.java
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panelpopup\PanelPopupRenderer.java
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltooltip\PanelTooltipRenderer.java
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\ice_cust_properties\cust-panelpopup-props.xml
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\ice_cust_properties\cust-paneltooltip-props.xml
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltooltip\PanelTooltipRenderer.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panelpopup\PanelPopupRenderer.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\ice_cust_properties\cust-panelpopup-props.xml
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ExtendedAttributeConstants.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\ice_cust_properties\cust-paneltooltip-props.xml
Completed: At revision: 17875

Show

Adnan Durrani added a comment - 06/Nov/08 11:43 PM Changes applied to the panelPopup as well as panelTooltip. Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ExtendedAttributeConstants.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panelpopup\PanelPopupRenderer.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltooltip\PanelTooltipRenderer.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\ice_cust_properties\cust-panelpopup-props.xml Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\ice_cust_properties\cust-paneltooltip-props.xml Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltooltip\PanelTooltipRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panelpopup\PanelPopupRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\ice_cust_properties\cust-panelpopup-props.xml Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ExtendedAttributeConstants.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\ice_cust_properties\cust-paneltooltip-props.xml Completed: At revision: 17875

Hide

Permalink

Adnan Durrani added a comment - 07/Nov/08 4:13 PM

Assigning to Mandeep for testing

Show

Adnan Durrani added a comment - 07/Nov/08 4:13 PM Assigning to Mandeep for testing

Hide

Permalink

Ken Fyten added a comment - 16/Dec/08 3:54 PM

This optimization has been made to the following priority components:

inputText
outputText
panelGroup
panelPopup
panelTooltip

Show

Ken Fyten added a comment - 16/Dec/08 3:54 PM This optimization has been made to the following priority components: inputText outputText panelGroup panelPopup panelTooltip

People

Assignee:

Unassigned

Reporter:

Adnan Durrani

Votes:

0 Vote for this issue

Watchers:

0 Start watching this issue

Dates

Created:

05/Sep/08 12:46 PM

Updated:

10/Apr/09 11:27 AM

Resolved:

16/Dec/08 3:54 PM