Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Component/s: ICE-Components
-
Labels:None
-
Environment:renderer + effect related JS handlers
Description
LocalEffectEncoder
.encodeLocalEffects(uiComponent, attributeElement, facesContext);
Issue Links
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
The following two components extend the renderer of the panelGroup component.
-panelPopup
-PanelTooltip
According to the TLD docs and the ExtendedAttributeConstants the above components have the following passThru attributes:
- panelGroup
{ HTML.STYLE_ATTR };
- panelPopup { HTML.STYLE_ATTR, HTML.TITLE_ATTR };
- PanelTooltip{ HTML.STYLE_ATTR }
According to the TLD docs only the panelGroup has effect related attributes and it doesn't support any javascript related attribute which means that none of the component requires any change.
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ExtendedAttributeConstants.java
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlPanelGroup.java
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\GroupRenderer.java
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\ice_properties\ice-panelGroup-props.xml
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\GroupRenderer.java
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\PassThruAttributeRenderer.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\GroupRenderer.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\ice_properties\ice-panelGroup-props.xml
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ExtendedAttributeConstants.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlPanelGroup.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\GroupRenderer.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\PassThruAttributeRenderer.java
Completed: At revision: 17873
I have also overloaded the following method :
public static String[] getAttributes(int index, String[] remove) {
signature of new overloaded method:
public static String[] getAttributes(int index, String[][] remove) {
It allows to pass more then one exclude arrays. (e.g.) Exclude the JS event as well as excluded attributes.
Changes applied to the panelPopup as well as panelTooltip.
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ExtendedAttributeConstants.java
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panelpopup\PanelPopupRenderer.java
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltooltip\PanelTooltipRenderer.java
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\ice_cust_properties\cust-panelpopup-props.xml
Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\ice_cust_properties\cust-paneltooltip-props.xml
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltooltip\PanelTooltipRenderer.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\panelpopup\PanelPopupRenderer.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\ice_cust_properties\cust-panelpopup-props.xml
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ExtendedAttributeConstants.java
Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\ice_cust_properties\cust-paneltooltip-props.xml
Completed: At revision: 17875
Assigning to Mandeep for testing
This optimization has been made to the following priority components:
- inputText
- outputText
- panelGroup
- panelPopup
- panelTooltip
Maybe the renderer could pass in a Map of what it wants to render to LocalEffectEncoder, where a map entry would look like "onclick" -> "iceSubmitPartial(...)". These could be statically defined, or dynamically generated if necessary.
LocalEffectEncoder could iterate over all the typical events, and combine the effect + user + framework Javascript, based on the on*effect attribute, the on* attribute, and the Map, respectively.
Also, it looks like some renderers invoke it directly, while it's also called from PassThruAttributeRenderer.renderHtmlAttributes, so we should probably make we're not double-invoking it that way too.