ICEfaces
  1. ICEfaces
  2. ICE-3455

UIXhtmlComponent.xmlAttributes is not Serializable

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.7.2
          • Fix Version/s: 1.8DR#1, 1.8
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            JSP
          • Affects:
            Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration

            Description

            In UIXhtmlComponent, the xmlAttributes field is not Serializable, and so is not currently participating in state saving. Replace it with a data structure that is Serializable.

              Activity

              Hide
              Permalink
              Mark Collette added a comment -

              There were 3 different data structures for attributes, one of them being for non-EL attributes for JSP, one for non-EL attributes for Facelets, and one for EL attributes for Facelets. I was going to simply make the JSP non-EL code use the Facelets non-EL data structure, but then I realised that it wouldn't be too hard to also cover the case of JSP EL attributes. So now there are only two data structures, both of which are Serializable. And, the JSP and Facelets code is more unified, and we've got a new feature, that XHTML tags in JSPX documents may now have EL values.

              Both JSP and the Facelets should be tested, since both were changed.

              TRUNK
              Subversion 17476
              ICEfaces 1.7 branch
              Subversion 17477
              icefaces\core\src\com\icesoft\faces\component\UIXhtmlComponent.java
              icefaces\core\src\com\icesoft\faces\facelets\UIXhtmlComponentHandler.java
              icefaces\core\src\com\icesoft\faces\webapp\parser\XhtmlTag.java

              Show
              Mark Collette added a comment - There were 3 different data structures for attributes, one of them being for non-EL attributes for JSP, one for non-EL attributes for Facelets, and one for EL attributes for Facelets. I was going to simply make the JSP non-EL code use the Facelets non-EL data structure, but then I realised that it wouldn't be too hard to also cover the case of JSP EL attributes. So now there are only two data structures, both of which are Serializable. And, the JSP and Facelets code is more unified, and we've got a new feature, that XHTML tags in JSPX documents may now have EL values. Both JSP and the Facelets should be tested, since both were changed. TRUNK Subversion 17476 ICEfaces 1.7 branch Subversion 17477 icefaces\core\src\com\icesoft\faces\component\UIXhtmlComponent.java icefaces\core\src\com\icesoft\faces\facelets\UIXhtmlComponentHandler.java icefaces\core\src\com\icesoft\faces\webapp\parser\XhtmlTag.java

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Mark Collette
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: