ICEfaces
  1. ICEfaces
  2. ICE-3410

Memory: instances of DOMContext need to be cleared after the response

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.7.1
          • Fix Version/s: 1.8DR#1, 1.8
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            Any

            Description

            As of the 1.7.1 release, we were keeping in memory all instances of DOMContext after serving the client. It isn't necessary to keep these objects in memory after the response. Removing them would bring significant memory savings. For example, Auction Monitor creates 82 DOMContext objects per client (50 after ICE-3321), which take ~13k of memory in total (~8k after ICE-3321).

              Issue Links

              blocks

              Improvement - An improvement or enhancement to an existing feature or task. ICE-3083 Memory performance/efficiency

              • Major - Major loss of function.
              • Open

                Activity

                Ascending order - Click to sort in descending order
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17348 Tue Aug 12 17:33:53 MDT 2008 art.zambrano ICE-3410 Instances of DOMContext need to be cleared after the response
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/DOMResponseWriter.java
                Arturo Zambrano created issue -
                Arturo Zambrano made changes -
                Field Original Value New Value
                Assignee Arturo Zambrano [ artzambrano ]
                Hide
                Permalink
                Arturo Zambrano added a comment -

                This was fixed by adding 'domContexts.clear();' to the endDocument() method of DOMResponseWriter.

                public void endDocument() throws IOException {
                + domContexts.clear();
                if (!isStreamWriting())

                { enhanceAndFixDocument(); serializer.serialize(document); }

                }

                Committed to revision 17348.

                Show
                Arturo Zambrano added a comment - This was fixed by adding 'domContexts.clear();' to the endDocument() method of DOMResponseWriter. public void endDocument() throws IOException { + domContexts.clear(); if (!isStreamWriting()) { enhanceAndFixDocument(); serializer.serialize(document); } } Committed to revision 17348.
                Arturo Zambrano made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Arturo Zambrano made changes -
                Summary Instances of DOMContext need to be cleared after the response Performance: instances of DOMContext need to be cleared after the response
                Ken Fyten made changes -
                Link This issue blocks ICE-3083 [ ICE-3083 ]
                Ken Fyten made changes -
                Fix Version/s 1.7.2 [ 10130 ]
                Arturo Zambrano made changes -
                Summary Performance: instances of DOMContext need to be cleared after the response Memory: instances of DOMContext need to be cleared after the response
                Ken Fyten made changes -
                Fix Version/s 1.7.2RC1 [ 10140 ]
                Fix Version/s 1.7.2 [ 10130 ]
                Ken Fyten made changes -
                Fix Version/s 1.8DR#1 [ 10141 ]
                Fix Version/s 1.7.2RC1 [ 10140 ]
                Ken Fyten made changes -
                Fix Version/s 1.8 [ 10161 ]
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]
                Assignee Arturo Zambrano [ artzambrano ]

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    Arturo Zambrano
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: