ICEfaces
  1. ICEfaces
  2. ICE-3410

Memory: instances of DOMContext need to be cleared after the response

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.7.1
          • Fix Version/s: 1.8DR#1, 1.8
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            Any

            Description

            As of the 1.7.1 release, we were keeping in memory all instances of DOMContext after serving the client. It isn't necessary to keep these objects in memory after the response. Removing them would bring significant memory savings. For example, Auction Monitor creates 82 DOMContext objects per client (50 after ICE-3321), which take ~13k of memory in total (~8k after ICE-3321).

              Issue Links

              blocks

              Improvement - An improvement or enhancement to an existing feature or task. ICE-3083 Memory performance/efficiency

              • Major - Major loss of function.
              • Open

                Activity

                Hide
                Permalink
                Arturo Zambrano added a comment -

                This was fixed by adding 'domContexts.clear();' to the endDocument() method of DOMResponseWriter.

                public void endDocument() throws IOException {
                + domContexts.clear();
                if (!isStreamWriting())

                { enhanceAndFixDocument(); serializer.serialize(document); }

                }

                Committed to revision 17348.

                Show
                Arturo Zambrano added a comment - This was fixed by adding 'domContexts.clear();' to the endDocument() method of DOMResponseWriter. public void endDocument() throws IOException { + domContexts.clear(); if (!isStreamWriting()) { enhanceAndFixDocument(); serializer.serialize(document); } } Committed to revision 17348.

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    Arturo Zambrano
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: