Details
Description
Recent work on performance improvements have shown memory consumption with large numbers of similar or identical Strings. In an effort to increase re-use of Strings, some of our JavaScript calls should be examined. For instance:
<form action="iceSubmit('j_id56');"
- can iceSubmit(this.id) or iceSubmit(form.id) be used?
- can ' be written as '
<a onclick="document.forms['iceForm']['iceForm:_idcl'].value='iceForm:iceTable:sortByTitle_click';iceSubmit( document.forms['iceForm'], this,event); return false;"
- can we still use iceSubmit(form, this, event) but search for a parent of "this" to find "form"? (Because <a> is not a form control.) iceSubmit could detect that the input control was a commandLink and set the hidden field directly.
onblur="setFocus('');"
- can this be replaced with "setFocus();"
iceSubmit(form,this,event);return false;
- can this be replaced with iceSubmit(form,this,event); or iceSubmitF(form,this,event);
Issue Links
- blocks
-
ICE-3083
Memory performance/efficiency
-
- Open
-
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
I was referring to "iceSubmit could detect that the input control was a commandLink". iceSubmit is already used in few subtle but different ways. Making iceSubmit aware about a specific component would just add another level of complexity to its implementation.
The commandLink component can be refactored to not use any hidden fields at all. This will also solve some DOM diff problems cause by the hidden fields rendered as direct children of the form.
It might be interesting to implement the JSF 2.0 commandLink without a hidden field (at the very least, I was thinking that all commandLinks could share a single common field) could you explain the basic idea for the new mechanism? (JSF 2.0 may have a constraint that it should work with JavaScript, but without Ajax – required browser support may extend to browsers without XMLHttpRequest.)
Mircea, please comment on the following:
iceSubmit() return false always.
iceSubmit(form,this,event) should be iceSubmit(this,event) (obtain form from "this")
iceSubmit(this,event) detect if "this" is <a> and walk up to obtain the form if this.form is not available
" iceSubmit() return false always. "
That's because the function doesn't return anything. Or maybe it was some historical reason. When I refactored iceSubmit and iceSubmitPartial implementation I kept the behavior intact.
"iceSubmit(form,this,event) should be iceSubmit(this,event) (obtain form from "this") "
I agree. But when I did that while refactoring the function there were some components that picked an element outside the form for submission 
"iceSubmit(this,event) detect if "this" is <a> and walk up to obtain the form if this.form is not available "
There's code in place for doing exactly that. Is just that the components relied on hidden fields every time and anchor <a> was used.
Could we add the hidden field logic to iceSubmit for commandLink?
Remove useless form action pseudo-URL.
Reduce amount of Javascript wiring for command links.
Please comment on the opportunities for re-use of JavaScript expressions. If Strings can be re-used, they can be more effectively pooled on the server.