Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7.1
    • Fix Version/s: 1.7.2
    • Component/s: Bridge
    • Labels:
      None
    • Environment:
      ICEfaces

      Description


      Recent work on performance improvements have shown memory consumption with large numbers of similar or identical Strings. In an effort to increase re-use of Strings, some of our JavaScript calls should be examined. For instance:

      <form action="iceSubmit(&#39;j_id56&#39;);"
        - can iceSubmit(this.id) or iceSubmit(form.id) be used?
        - can &#39; be written as '

      <a onclick="document.forms[&#39;iceForm&#39;][&#39;iceForm:_idcl&#39;].value=&#39;iceForm:iceTable:sortByTitle_click&#39;;iceSubmit( document.forms[&#39;iceForm&#39;], this,event); return false;"
        - can we still use iceSubmit(form, this, event) but search for a parent of "this" to find "form"? (Because <a> is not a form control.) iceSubmit could detect that the input control was a commandLink and set the hidden field directly.

      onblur="setFocus(&#39;&#39;);"
        - can this be replaced with "setFocus();"

      iceSubmit(form,this,event);return false;
        - can this be replaced with iceSubmit(form,this,event); or iceSubmitF(form,this,event);

        Issue Links

          Activity

          Repository Revision Date User Message
          ICEsoft Public SVN Repository #17471 Fri Aug 29 14:04:48 MDT 2008 mircea.toma ICE-3344 Make event handler return false to cancel default action for anchors.
          Files Changed
          Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/CommandLinkRenderer.java
          Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/CommandLinkRenderer.java
          Commit graph MODIFY /icefaces/trunk/icefaces/bridge/src/submit.js
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #17470 Fri Aug 29 14:01:53 MDT 2008 mircea.toma ICE-3344 Make event handler return false to cancel default action for anchors.
          Files Changed
          Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/webapp/http/core/MultiViewServer.java
          Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/bridge/src/submit.js
          Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/CommandLinkRenderer.java
          Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/CommandLinkRenderer.java
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #17449 Tue Aug 26 16:02:11 MDT 2008 mircea.toma ICE-3344 Reduce amount of Javascript wiring for command links.
          Files Changed
          Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/bridge/src/submit.js
          Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/CommandLinkRenderer.java
          Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/CommandLinkRenderer.java
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #17448 Tue Aug 26 15:54:26 MDT 2008 mircea.toma ICE-3344 Reduce amount of Javascript wiring for command links.
          Files Changed
          Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/CommandLinkRenderer.java
          Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/CommandLinkRenderer.java
          Commit graph MODIFY /icefaces/trunk/icefaces/bridge/src/submit.js
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #17375 Wed Aug 20 14:40:23 MDT 2008 mircea.toma ICE-3344 Disable form default behavior.
          Files Changed
          Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/FormRenderer.java
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #17374 Wed Aug 20 14:39:59 MDT 2008 mircea.toma ICE-3344 Disable form default behavior.
          Files Changed
          Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/FormRenderer.java

            People

            • Assignee:
              Unassigned
              Reporter:
              Ted Goddard
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: