ICEfaces
  1. ICEfaces
  2. ICE-3321

Create a outputText and inputText component that uses ResponseWriter instead of DOMContext

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: None
          • Fix Version/s: 1.8DR#1, 1.8
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            All

            Description

            In order to better assess the potential performance improvements made possible by converting existing ICEfaces components that use DOM Context D2D rendering techniques to instead use the JSF-standard ResponseWriter technique we need to create an ice:outputText component that uses ResponseWriter for rendering.

              Issue Links

              blocks

              Bug - A problem which impairs or prevents the functions of the product. ICE-3534 SelectInputText component gives a Javascript error after typing a character

              • Major - Major loss of function.
              • Closed

              Improvement - An improvement or enhancement to an existing feature or task. ICE-3082 CPU performance/efficiency

              • Major - Major loss of function.
              • Closed

                Activity

                Descending order - Click to sort in ascending order
                Hide
                Permalink
                Mark Collette added a comment -

                Here are copied html fragments from the component-showcase of the inputSecret component renderings, from before and after the code fix.

                Before:
                <input type="password" value="" size="10" onmousedown="this.focus();" onkeypress="iceSubmit(form,this,event);iceSubmit(form,this,event);" onfocus="setFocus(this.id);" onblur="setFocus('');iceSubmitPartial(form, this, event);setFocus('');iceSubmitPartial(form,this,event); return false;" name="iceform:TxtPw" maxlength="10" id="iceform:TxtPw" class="iceInpSecrt"/>

                After:
                <input type="password" value="" size="10" onmousedown="this.focus();" onkeypress="iceSubmit(form,this,event);" onfocus="setFocus(this.id);" onblur="setFocus('');iceSubmitPartial(form,this,event); return false;" name="iceform:TxtPw" maxlength="10" id="iceform:TxtPw" class="iceInpSecrt"/>

                Show
                Mark Collette added a comment - Here are copied html fragments from the component-showcase of the inputSecret component renderings, from before and after the code fix. Before: <input type="password" value="" size="10" onmousedown="this.focus();" onkeypress="iceSubmit(form,this,event);iceSubmit(form,this,event);" onfocus="setFocus(this.id);" onblur="setFocus('');iceSubmitPartial(form, this, event);setFocus('');iceSubmitPartial(form,this,event); return false;" name="iceform:TxtPw" maxlength="10" id="iceform:TxtPw" class="iceInpSecrt"/> After: <input type="password" value="" size="10" onmousedown="this.focus();" onkeypress="iceSubmit(form,this,event);" onfocus="setFocus(this.id);" onblur="setFocus('');iceSubmitPartial(form,this,event); return false;" name="iceform:TxtPw" maxlength="10" id="iceform:TxtPw" class="iceInpSecrt"/>
                Hide
                Permalink
                Mark Collette added a comment -

                Fixed the regression with changes made in ICE-3484.

                Show
                Mark Collette added a comment - Fixed the regression with changes made in ICE-3484 .
                Hide
                Permalink
                Mark Collette added a comment -

                Several of our components extend HtmlInputText, so the change to getOnkeypress() might cause more side-effects than what has been found with SelectInputText.

                Show
                Mark Collette added a comment - Several of our components extend HtmlInputText, so the change to getOnkeypress() might cause more side-effects than what has been found with SelectInputText.
                Hide
                Permalink
                Mark Collette added a comment -

                This is causing a regression with:
                http://jira.icefaces.org/browse/ICE-3534

                We should solve it using the strategy from:
                http://jira.icefaces.org/browse/ICE-3484

                Show
                Mark Collette added a comment - This is causing a regression with: http://jira.icefaces.org/browse/ICE-3534 We should solve it using the strategy from: http://jira.icefaces.org/browse/ICE-3484
                Hide
                Permalink
                Adnan Durrani added a comment -

                The h:outputText is also using the ResponseWriter.
                trunk revision: 17518

                Show
                Adnan Durrani added a comment - The h:outputText is also using the ResponseWriter. trunk revision: 17518
                14 older comments

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    Ken Fyten
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: