ICEfaces
  1. ICEfaces
  2. ICE-3303

Make InputFile's FileInfo Serializable

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7.1
    • Fix Version/s: 1.8DR#2, 1.8
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      All

      Description

      User needs InputFile's FileInfo to be Serializable.

        Issue Links

          Activity

          Mark Collette created issue -
          Mark Collette made changes -
          Field Original Value New Value
          Link This issue blocks ICE-3442 [ ICE-3442 ]
          Mark Collette made changes -
          Link This issue blocks ICE-3696 [ ICE-3696 ]
          Hide
          Mark Collette added a comment -

          While making all fields of FileInfo be serialized, make sure InputFile.uploadException is too. Specifically, see if the commons-upload, or any other, Exceptions are Serializable, so that the FacesMessages will still be properly generated.

          Show
          Mark Collette added a comment - While making all fields of FileInfo be serialized, make sure InputFile.uploadException is too. Specifically, see if the commons-upload, or any other, Exceptions are Serializable, so that the FacesMessages will still be properly generated.
          Mark Collette made changes -
          Assignee Mark Collette [ mark.collette ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #17850 Tue Oct 28 15:06:40 MDT 2008 yip.ng ICE-3303
          Made FileInfo class serializable and implemented equals method.
          Files Changed
          Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/inputfile/FileInfo.java
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #17852 Tue Oct 28 16:46:55 MDT 2008 yip.ng ICE-3303
          Made FileInfo class serializable and implemented equals method.
          Files Changed
          Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/util/CoreUtils.java
          Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/inputfile/FileInfo.java
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #17853 Tue Oct 28 17:10:51 MDT 2008 yip.ng ICE-3303
          Made FileInfo class serializable and implemented equals method.
          Files Changed
          Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/util/CoreUtils.java
          yip.ng made changes -
          Assignee Mark Collette [ mark.collette ] Yip Ng [ yip.ng ]
          Hide
          yip.ng added a comment -

          FileInfo already implements Serializable.

          Added equals() method.

          FileInfo.exception is either an org.apache.commons.fileupload.FileUploadBase.FileUploadIOException or a java.io.IOException. They all inherit from Throwable, which implements Serializable. Therefore, they are already serializable.

          InputFile.uploadException is either an org.apache.commons.fileupload.FileUploadException or java.io.IOException. They all inherit from Throwable, which implements Serializable. Therefore, they are already serializable.

          Other Commons File Upload exceptions also inherit from Throwable. Therefore they are already serializable.

          Show
          yip.ng added a comment - FileInfo already implements Serializable. Added equals() method. FileInfo.exception is either an org.apache.commons.fileupload.FileUploadBase.FileUploadIOException or a java.io.IOException. They all inherit from Throwable, which implements Serializable. Therefore, they are already serializable. InputFile.uploadException is either an org.apache.commons.fileupload.FileUploadException or java.io.IOException. They all inherit from Throwable, which implements Serializable. Therefore, they are already serializable. Other Commons File Upload exceptions also inherit from Throwable. Therefore they are already serializable.
          Hide
          yip.ng added a comment -

          Added util method to compare Throwables and called it from FileInfo equals() method to compare FileInfo.exception.

          Show
          yip.ng added a comment - Added util method to compare Throwables and called it from FileInfo equals() method to compare FileInfo.exception.
          yip.ng made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          yip.ng made changes -
          Salesforce Case []
          Fix Version/s 1.8DR#2 [ 10142 ]
          Ken Fyten made changes -
          Fix Version/s 1.8 [ 10161 ]
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Assignee Yip Ng [ yip.ng ]

            People

            • Assignee:
              Unassigned
              Reporter:
              Mark Collette
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: