[ICE-2724] Make tooltip panel expand and contract with contents without a fixed width or height. - ICEsoft JIRA Issue Tracker

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 1.7Beta1
Fix Version/s: 1.7.1
Component/s: ICE-Components
Labels:
None
Environment:
All.

Description

Right now, tooltip panels always have a width and height. If not specified in the application, they will have default values from xp.css. We should explore the option of not fixing the size of the panels and having them expand and contract with the contents.

Initial exploration indicates that it may require changes to the popup panel renderer, the IFRAME hack for IE6 and xp.css, in addition to changes to component showcase. Therefore, we need to make sure that it won't break the popup panel, the IFRAME hack, and any existing applications.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

screenshot-1.jpg

195 kB

11/Feb/08 6:20 PM
screenshot-2.jpg

167 kB

11/Feb/08 6:35 PM
screenshot-3.jpg

133 kB

11/Feb/08 6:50 PM
screenshot-4.jpg

189 kB

15/Feb/08 11:32 AM

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

yip.ng added a comment - 12/Feb/08 11:55 AM

Fix works perfectly only in Firefox. In IE it would break existing apps with fixed-width popups and the IFRAME hack. See the attached screenshots.

Show

yip.ng added a comment - 12/Feb/08 11:55 AM Fix works perfectly only in Firefox. In IE it would break existing apps with fixed-width popups and the IFRAME hack. See the attached screenshots.

Hide

Permalink

yip.ng added a comment - 15/Feb/08 11:32 AM

Screenshot showing that fix won't break existing apps with fixed width popups in Firefox.

Show

yip.ng added a comment - 15/Feb/08 11:32 AM Screenshot showing that fix won't break existing apps with fixed width popups in Firefox.

Hide

Permalink

yip.ng added a comment - 15/Feb/08 11:46 AM

Fix that works perfect in Firefox only:

Index: ../../svn/ossrepo/icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp.css
===================================================================
— ../../svn/ossrepo/icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp.css (revision 15797)
+++ ../../svn/ossrepo/icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp.css Thu Feb 14 18:07:54 MST 2008
@@ -1688,12 +1688,9 @@
border-top: 1px solid #ABABAB;
border-left: 1px solid #ABABAB;
border-bottom: 2px solid #ABABAB;

width: auto;
background-color: #DDDDDD;
padding: 0px;
z-index: 1000;
width: 300px;
height: 150px;
}

.icePnlPopHdr, .icePnlTlTipHdr {
Index: ../../svn/ossrepo/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java
===================================================================
— ../../svn/ossrepo/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java (revision 15797)
+++ ../../svn/ossrepo/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java Fri Feb 15 10:05:47 MST 2008
@@ -112,8 +112,7 @@
Element table = domContext.createElement(HTML.TABLE_ELEM);
table.setAttribute(HTML.CELLPADDING_ATTR, "0");
table.setAttribute(HTML.CELLSPACING_ATTR, "0");

table.setAttribute(HTML.WIDTH_ATTR, "100%");
table.setAttribute(HTML.STYLE_ATTR, "position:absolute;"); // ~~ICE-1490~~
+ table.setAttribute(HTML.STYLE_ATTR, "width:inherit;");
rootDiv.appendChild(table);

// ~~ICE-1490~~

Show

yip.ng added a comment - 15/Feb/08 11:46 AM Fix that works perfect in Firefox only: Index: ../../svn/ossrepo/icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp.css =================================================================== — ../../svn/ossrepo/icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp.css (revision 15797) +++ ../../svn/ossrepo/icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp.css Thu Feb 14 18:07:54 MST 2008 @@ -1688,12 +1688,9 @@ border-top: 1px solid #ABABAB; border-left: 1px solid #ABABAB; border-bottom: 2px solid #ABABAB; width: auto; background-color: #DDDDDD; padding: 0px; z-index: 1000; width: 300px; height: 150px; } .icePnlPopHdr, .icePnlTlTipHdr { Index: ../../svn/ossrepo/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java =================================================================== — ../../svn/ossrepo/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java (revision 15797) +++ ../../svn/ossrepo/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java Fri Feb 15 10:05:47 MST 2008 @@ -112,8 +112,7 @@ Element table = domContext.createElement(HTML.TABLE_ELEM); table.setAttribute(HTML.CELLPADDING_ATTR, "0"); table.setAttribute(HTML.CELLSPACING_ATTR, "0"); table.setAttribute(HTML.WIDTH_ATTR, "100%"); table.setAttribute(HTML.STYLE_ATTR, "position:absolute;"); // ICE-1490 + table.setAttribute(HTML.STYLE_ATTR, "width:inherit;"); rootDiv.appendChild(table); // ICE-1490

Hide

Permalink

yip.ng added a comment - 17/Apr/08 6:42 PM

Already done in ~~ICE-1490~~ using JavaScript instead of CSS. Just needed to remove the default width and height from the rime theme as well.

Show

yip.ng added a comment - 17/Apr/08 6:42 PM Already done in ICE-1490 using JavaScript instead of CSS. Just needed to remove the default width and height from the rime theme as well.

Make tooltip panel expand and contract with contents without a fixed width or height.

Details

Description

Attachments

Activity

People

Dates