ICEfaces
  1. ICEfaces
  2. ICE-2724

Make tooltip panel expand and contract with contents without a fixed width or height.

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.7Beta1
          • Fix Version/s: 1.7.1
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            All.

            Description

            Right now, tooltip panels always have a width and height. If not specified in the application, they will have default values from xp.css. We should explore the option of not fixing the size of the panels and having them expand and contract with the contents.

            Initial exploration indicates that it may require changes to the popup panel renderer, the IFRAME hack for IE6 and xp.css, in addition to changes to component showcase. Therefore, we need to make sure that it won't break the popup panel, the IFRAME hack, and any existing applications.
            1. screenshot-4.jpg
              189 kB
            2. screenshot-3.jpg
              133 kB
            3. screenshot-2.jpg
              167 kB
            4. screenshot-1.jpg
              195 kB

              Activity

              Descending order - Click to sort in ascending order
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Yip Ng [ yip.ng ]
              yip.ng made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              yip.ng added a comment -

              Already done in ICE-1490 using JavaScript instead of CSS. Just needed to remove the default width and height from the rime theme as well.

              Show
              yip.ng added a comment - Already done in ICE-1490 using JavaScript instead of CSS. Just needed to remove the default width and height from the rime theme as well.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #16469 Thu Apr 17 17:37:46 MDT 2008 yip.ng ICE-1490, ICE-2724
              Removed default width and height for popup and tooltip panels.
              Files Changed
              Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/resources/css/rime/rime.css
              Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/resources/css/rime/rime-portlet.css
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #16468 Thu Apr 17 17:16:29 MDT 2008 yip.ng ICE-1490, ICE-2724
              Removed default width and height for popup and tooltip panels.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/rime/rime.css
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/rime/rime-portlet.css
              Ken Fyten made changes -
              Fix Version/s 1.7.1 [ 10122 ]
              Fix Version/s 1.7 [ 10080 ]
              Hide
              Permalink
              yip.ng added a comment -

              Fix that works perfect in Firefox only:

              Index: ../../svn/ossrepo/icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp.css
              ===================================================================
              — ../../svn/ossrepo/icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp.css (revision 15797)
              +++ ../../svn/ossrepo/icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp.css Thu Feb 14 18:07:54 MST 2008
              @@ -1688,12 +1688,9 @@
              border-top: 1px solid #ABABAB;
              border-left: 1px solid #ABABAB;
              border-bottom: 2px solid #ABABAB;

              • width: auto;
                background-color: #DDDDDD;
                padding: 0px;
                z-index: 1000;
              • width: 300px;
              • height: 150px;
                }

              .icePnlPopHdr, .icePnlTlTipHdr {
              Index: ../../svn/ossrepo/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java
              ===================================================================
              — ../../svn/ossrepo/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java (revision 15797)
              +++ ../../svn/ossrepo/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java Fri Feb 15 10:05:47 MST 2008
              @@ -112,8 +112,7 @@
              Element table = domContext.createElement(HTML.TABLE_ELEM);
              table.setAttribute(HTML.CELLPADDING_ATTR, "0");
              table.setAttribute(HTML.CELLSPACING_ATTR, "0");

              • table.setAttribute(HTML.WIDTH_ATTR, "100%");
              • table.setAttribute(HTML.STYLE_ATTR, "position:absolute;"); // ICE-1490
                + table.setAttribute(HTML.STYLE_ATTR, "width:inherit;");
                rootDiv.appendChild(table);

              // ICE-1490

              Show
              yip.ng added a comment - Fix that works perfect in Firefox only: Index: ../../svn/ossrepo/icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp.css =================================================================== — ../../svn/ossrepo/icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp.css (revision 15797) +++ ../../svn/ossrepo/icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp.css Thu Feb 14 18:07:54 MST 2008 @@ -1688,12 +1688,9 @@ border-top: 1px solid #ABABAB; border-left: 1px solid #ABABAB; border-bottom: 2px solid #ABABAB; width: auto; background-color: #DDDDDD; padding: 0px; z-index: 1000; width: 300px; height: 150px; } .icePnlPopHdr, .icePnlTlTipHdr { Index: ../../svn/ossrepo/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java =================================================================== — ../../svn/ossrepo/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java (revision 15797) +++ ../../svn/ossrepo/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java Fri Feb 15 10:05:47 MST 2008 @@ -112,8 +112,7 @@ Element table = domContext.createElement(HTML.TABLE_ELEM); table.setAttribute(HTML.CELLPADDING_ATTR, "0"); table.setAttribute(HTML.CELLSPACING_ATTR, "0"); table.setAttribute(HTML.WIDTH_ATTR, "100%"); table.setAttribute(HTML.STYLE_ATTR, "position:absolute;"); // ICE-1490 + table.setAttribute(HTML.STYLE_ATTR, "width:inherit;"); rootDiv.appendChild(table); // ICE-1490
              yip.ng made changes -
              Attachment screenshot-4.jpg [ 10820 ]
              Hide
              Permalink
              yip.ng added a comment -

              Screenshot showing that fix won't break existing apps with fixed width popups in Firefox.

              Show
              yip.ng added a comment - Screenshot showing that fix won't break existing apps with fixed width popups in Firefox.
              Hide
              Permalink
              yip.ng added a comment -

              Fix works perfectly only in Firefox. In IE it would break existing apps with fixed-width popups and the IFRAME hack. See the attached screenshots.

              Show
              yip.ng added a comment - Fix works perfectly only in Firefox. In IE it would break existing apps with fixed-width popups and the IFRAME hack. See the attached screenshots.
              yip.ng made changes -
              Attachment screenshot-3.jpg [ 10816 ]
              yip.ng made changes -
              Attachment screenshot-2.jpg [ 10815 ]
              yip.ng made changes -
              Attachment screenshot-1.jpg [ 10814 ]
              yip.ng made changes -
              Assignee Yip Ng [ yip.ng ]
              yip.ng made changes -
              Field Original Value New Value
              Fix Version/s 1.7 [ 10080 ]
              yip.ng created issue -

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  yip.ng
                • Votes:
                  1 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: