ICEfaces
  1. ICEfaces
  2. ICE-2186

The rowSelector component should bypass the validation when a rowSelector event is fired

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Won't Fix
          • Affects Version/s: 1.7DR#3
          • Fix Version/s: 1.7Beta1, 1.7
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            rowSelector + validation

            Description

            The rowSelector component should bypass the validation when a rowSelector event is fired.
            1. screenshot-4.jpg
              186 kB
            2. screenshot-3.jpg
              190 kB
            3. screenshot-2.jpg
              186 kB
            4. screenshot-1.jpg
              188 kB

              Issue Links

              blocks

              Bug - A problem which impairs or prevents the functions of the product. ICE-1518 tabChangeListener doesnot work for dynamic tabs

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                4 older comments
                Hide
                Permalink
                yip.ng added a comment -

                Screenshot after another fix, showing that the length validation is skipped as well.

                Show
                yip.ng added a comment - Screenshot after another fix, showing that the length validation is skipped as well.
                Hide
                Permalink
                yip.ng added a comment -

                How to test:

                In component-showcase/web/inc/components/tableRowSelection.jspx, add input fields with validation requirements, e.g.:

                <ice:inputText id="testInput1" required="true"/>
                <ice:message for="testInput1"/><br/>
                <ice:inputText id="testInput2" required="false">
                <f:validateLength maximum="2"/>
                </ice:inputText>
                <ice:message for="testInput2"/>

                Before the fix, you would get validation errors when selecting a row; after the fix, there should be no validation triggered. See the attached screenshots.

                Show
                yip.ng added a comment - How to test: In component-showcase/web/inc/components/tableRowSelection.jspx, add input fields with validation requirements, e.g.: <ice:inputText id="testInput1" required="true"/> <ice:message for="testInput1"/><br/> <ice:inputText id="testInput2" required="false"> <f:validateLength maximum="2"/> </ice:inputText> <ice:message for="testInput2"/> Before the fix, you would get validation errors when selecting a row; after the fix, there should be no validation triggered. See the attached screenshots.
                Hide
                Permalink
                Ken Fyten added a comment -

                We should revert this change prior to the 1.7 final release. The scenario that this was attempting to improve support for can affect numerous components, changing the rowSelector specifically is undesirable.

                There is also a new request for an additional tutorial to demonstrate application examples that resolve the issues this fix tries to address: ICE-2701.

                Show
                Ken Fyten added a comment - We should revert this change prior to the 1.7 final release. The scenario that this was attempting to improve support for can affect numerous components, changing the rowSelector specifically is undesirable. There is also a new request for an additional tutorial to demonstrate application examples that resolve the issues this fix tries to address: ICE-2701 .
                Hide
                Permalink
                Ken Fyten added a comment -

                Original changes have been backed out.

                Won't Fix.

                Show
                Ken Fyten added a comment - Original changes have been backed out. Won't Fix.
                Hide
                Permalink
                Mark Collette added a comment -

                While we wanted to remove the call to FacesContext.renderResponse() from the RowSelector component's decode method, the Javascript should have still used partialSubmit. This is fixed in: ICE-2749.

                Show
                Mark Collette added a comment - While we wanted to remove the call to FacesContext.renderResponse() from the RowSelector component's decode method, the Javascript should have still used partialSubmit. This is fixed in: ICE-2749 .

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    Adnan Durrani
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: