ICEfaces
  1. ICEfaces
  2. ICE-2186

The rowSelector component should bypass the validation when a rowSelector event is fired

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 1.7DR#3
    • Fix Version/s: 1.7Beta1, 1.7
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      rowSelector + validation

      Description

      The rowSelector component should bypass the validation when a rowSelector event is fired.
      1. screenshot-1.jpg
        188 kB
      2. screenshot-2.jpg
        186 kB
      3. screenshot-3.jpg
        190 kB
      4. screenshot-4.jpg
        186 kB

        Issue Links

          Activity

          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Ken Fyten made changes -
          Fix Version/s 1.7 [ 10080 ]
          Hide
          Mark Collette added a comment -

          While we wanted to remove the call to FacesContext.renderResponse() from the RowSelector component's decode method, the Javascript should have still used partialSubmit. This is fixed in: ICE-2749.

          Show
          Mark Collette added a comment - While we wanted to remove the call to FacesContext.renderResponse() from the RowSelector component's decode method, the Javascript should have still used partialSubmit. This is fixed in: ICE-2749 .
          Mark Collette made changes -
          Link This issue blocks ICE-1518 [ ICE-1518 ]
          Ken Fyten made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Won't Fix [ 2 ]
          Assignee Yip Ng [ yip.ng ]
          Hide
          Ken Fyten added a comment -

          Original changes have been backed out.

          Won't Fix.

          Show
          Ken Fyten added a comment - Original changes have been backed out. Won't Fix.
          Ken Fyten made changes -
          Fix Version/s 1.7Beta1 [ 10121 ]
          Fix Version/s 1.7DR#3 [ 10112 ]
          Affects Version/s 1.7DR#3 [ 10112 ]
          Affects Version/s 1.7Beta1 [ 10121 ]
          Ken Fyten made changes -
          Affects Version/s 1.7Beta1 [ 10121 ]
          Affects Version/s 1.7 [ 10080 ]
          Ken Fyten made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Hide
          Ken Fyten added a comment -

          We should revert this change prior to the 1.7 final release. The scenario that this was attempting to improve support for can affect numerous components, changing the rowSelector specifically is undesirable.

          There is also a new request for an additional tutorial to demonstrate application examples that resolve the issues this fix tries to address: ICE-2701.

          Show
          Ken Fyten added a comment - We should revert this change prior to the 1.7 final release. The scenario that this was attempting to improve support for can affect numerous components, changing the rowSelector specifically is undesirable. There is also a new request for an additional tutorial to demonstrate application examples that resolve the issues this fix tries to address: ICE-2701 .
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #15714 Mon Feb 04 17:19:15 MST 2008 yip.ng ICE-2186
          Backed out previous changes.
          Files Changed
          Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/RowSelector.java
          Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/extras.js
          Ken Fyten made changes -
          Issue Type New Feature [ 2 ] Improvement [ 4 ]
          yip.ng made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          yip.ng added a comment -

          How to test:

          In component-showcase/web/inc/components/tableRowSelection.jspx, add input fields with validation requirements, e.g.:

          <ice:inputText id="testInput1" required="true"/>
          <ice:message for="testInput1"/><br/>
          <ice:inputText id="testInput2" required="false">
          <f:validateLength maximum="2"/>
          </ice:inputText>
          <ice:message for="testInput2"/>

          Before the fix, you would get validation errors when selecting a row; after the fix, there should be no validation triggered. See the attached screenshots.

          Show
          yip.ng added a comment - How to test: In component-showcase/web/inc/components/tableRowSelection.jspx, add input fields with validation requirements, e.g.: <ice:inputText id="testInput1" required="true"/> <ice:message for="testInput1"/><br/> <ice:inputText id="testInput2" required="false"> <f:validateLength maximum="2"/> </ice:inputText> <ice:message for="testInput2"/> Before the fix, you would get validation errors when selecting a row; after the fix, there should be no validation triggered. See the attached screenshots.
          yip.ng made changes -
          Attachment screenshot-4.jpg [ 10726 ]
          Hide
          yip.ng added a comment -

          Screenshot after another fix, showing that the length validation is skipped as well.

          Show
          yip.ng added a comment - Screenshot after another fix, showing that the length validation is skipped as well.
          yip.ng made changes -
          Attachment screenshot-3.jpg [ 10725 ]
          Hide
          yip.ng added a comment -

          Screenshot showing that the "required" validation is skipped but the length validation is not skipped.

          Show
          yip.ng added a comment - Screenshot showing that the "required" validation is skipped but the length validation is not skipped.
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #15094 Mon Nov 05 15:23:02 MST 2007 yip.ng ICE-2186
          Changed to not trigger input validation when row is selected.
          Files Changed
          Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/RowSelector.java
          yip.ng made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Hide
          yip.ng added a comment -

          Doesn't seem to work with length validator.

          Show
          yip.ng added a comment - Doesn't seem to work with length validator.
          yip.ng made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          yip.ng added a comment -

          How to test:

          In File component-showcase/web/inc/components/tableRowSelection.jspx, add an input field with validation requirements, e.g.:

          <ice:inputText id="testInput" required="true"/>
          <ice:message for="testInput"/>

          Before the fix, you would get a validation error when selecting a row; after the fix, there should be no validation triggered. See the attached screenshots.

          Show
          yip.ng added a comment - How to test: In File component-showcase/web/inc/components/tableRowSelection.jspx, add an input field with validation requirements, e.g.: <ice:inputText id="testInput" required="true"/> <ice:message for="testInput"/> Before the fix, you would get a validation error when selecting a row; after the fix, there should be no validation triggered. See the attached screenshots.
          yip.ng made changes -
          Attachment screenshot-2.jpg [ 10724 ]
          Hide
          yip.ng added a comment -

          Screenshot after the fix. No validation error message for input field anymore.

          Show
          yip.ng added a comment - Screenshot after the fix. No validation error message for input field anymore.
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #15089 Fri Nov 02 17:21:41 MDT 2007 yip.ng ICE-2186
          Changed to not trigger input validation when row is selected.
          Files Changed
          Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/extras.js
          yip.ng made changes -
          Attachment screenshot-1.jpg [ 10723 ]
          Hide
          yip.ng added a comment -

          Screenshot showing the problem. Validation of the input field is triggered by a row selection.

          Show
          yip.ng added a comment - Screenshot showing the problem. Validation of the input field is triggered by a row selection.
          Ken Fyten made changes -
          Assignee Adnan Durrani [ adnan.durrani ] Yip Ng [ yip.ng ]
          Adnan Durrani made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Ken Fyten made changes -
          Fix Version/s 1.7DR#3 [ 10112 ]
          Adnan Durrani made changes -
          Field Original Value New Value
          Assignee Adnan Durrani [ adnan.durrani ]
          Adnan Durrani created issue -

            People

            • Assignee:
              Unassigned
              Reporter:
              Adnan Durrani
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: