ICEfaces
  1. ICEfaces
  2. ICE-11317

add library attribute to ace:graphicImage

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 4.2
          • Fix Version/s: EE-4.2.0.GA
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            ace image as resource
          • Assignee Priority:
            P2

            Description

            {code} ace:graphicImage {code} currently has a "name" attribute but no "library" attribute.
            This makes it difficult to use with resources that have a "library" with the "name".

            see showcase example for h:graphicImage page
            contextMenuEffect.xhtml

              Issue Links

              blocks

              Improvement - An improvement or enhancement to an existing feature or task. ICE-11258 Replace h: components in Showcase with ace: versions

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Judy Guglielmin created issue -
                Judy Guglielmin made changes -
                Field Original Value New Value
                Link This issue blocks ICE-11258 [ ICE-11258 ]
                Ken Fyten made changes -
                Assignee Mircea Toma [ mircea.toma ]
                Fix Version/s EE-4.2.0.GA [ 13071 ]
                Assignee Priority P2 [ 10011 ]
                Hide
                Permalink
                Mircea Toma added a comment -

                Introduce 'library' attribute for the ace:graphicImage component. Use 'name' and 'library' whenever the 'value' or 'url' attributes are not defined to lookup the resource request path.

                Show
                Mircea Toma added a comment - Introduce 'library' attribute for the ace:graphicImage component. Use 'name' and 'library' whenever the 'value' or 'url' attributes are not defined to lookup the resource request path.
                Mircea Toma made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #51625 Mon Jun 12 14:39:08 MDT 2017 mircea.toma ICE-11317 Introduce 'library' attribute for the ace:graphicImage component. Use 'name' and 'library' whenever the 'value' or 'url' are not defined to lookup the resource request path.
                Files Changed
                Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/graphicimage/GraphicImage.java
                Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/util/IceOutputResource.java
                Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/graphicimage/GraphicImageMeta.java
                Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/graphicimage/GraphicImageRenderer.java
                Ken Fyten made changes -
                Resolution Fixed [ 1 ]
                Status Resolved [ 5 ] Reopened [ 4 ]
                Hide
                Permalink
                Mircea Toma added a comment - - edited

                I believe there was some confusion what the 'name' attribute was for when the sugestion was made to add the library attribute to the ace:graphicImage component.
                Previous to my changes the 'name' attribute was used for defining the name of the file in the URL that was generated off a byte array.
                The change I put in unfortunately overloads the 'name' attribute, now whenever the 'value' or 'url' attributes are not defined the 'name' and the 'library' attributes are used for looking up a JSF resource, just like h:graphicImage does.

                The Javadoc for the 'name' attribute was updated to clarify new overloaded behaviour.

                Show
                Mircea Toma added a comment - - edited I believe there was some confusion what the 'name' attribute was for when the sugestion was made to add the library attribute to the ace:graphicImage component. Previous to my changes the 'name' attribute was used for defining the name of the file in the URL that was generated off a byte array. The change I put in unfortunately overloads the 'name' attribute, now whenever the 'value' or 'url' attributes are not defined the 'name' and the 'library' attributes are used for looking up a JSF resource, just like h:graphicImage does. The Javadoc for the 'name' attribute was updated to clarify new overloaded behaviour.
                Mircea Toma made changes -
                Status Reopened [ 4 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #51639 Wed Jun 14 16:15:19 MDT 2017 mircea.toma ICE-11317 Update javadoc.
                Files Changed
                Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/graphicimage/GraphicImageMeta.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #51650 Thu Jun 15 16:15:48 MDT 2017 judy.guglielmin ICE-11258 can use ace:graphicImage now that ICE-11317 has been resolved.
                Files Changed
                Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/contextMenu/contextMenuEffect.xhtml
                Hide
                Permalink
                Liana Munroe added a comment -

                Verified ICEfaces 4 trunk r51657, Tomcat 8, MS Edge, IE 11, 10, 9, 8, FF 47, Chrome 59.
                Added test app /ICE-11317.jsf to
                http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/graphicImage

                Show
                Liana Munroe added a comment - Verified ICEfaces 4 trunk r51657, Tomcat 8, MS Edge, IE 11, 10, 9, 8, FF 47, Chrome 59. Added test app / ICE-11317 .jsf to http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/graphicImage
                Ken Fyten made changes -
                Resolution Fixed [ 1 ]
                Status Resolved [ 5 ] Reopened [ 4 ]
                Hide
                Permalink
                Mircea Toma added a comment -

                I had to change the text a bit:

                "If the 'value', 'url' or 'src' attributes are defined the 'name' attribute defines the file name for the graphic image. Alternatively, a value can be specified to reference a JSF resource (also requires the 'library' attribute to be specified)."

                Show
                Mircea Toma added a comment - I had to change the text a bit: "If the 'value', 'url' or 'src' attributes are defined the 'name' attribute defines the file name for the graphic image. Alternatively, a value can be specified to reference a JSF resource (also requires the 'library' attribute to be specified)."
                Mircea Toma made changes -
                Status Reopened [ 4 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #51677 Wed Jun 21 16:40:08 MDT 2017 mircea.toma ICE-11317 Update attribute documentation.
                Files Changed
                Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/graphicimage/GraphicImageMeta.java
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]

                  People

                  • Assignee:
                    Mircea Toma
                    Reporter:
                    Judy Guglielmin
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    4 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: