ICEfaces
  1. ICEfaces
  2. ICE-11317

add library attribute to ace:graphicImage

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.2
    • Fix Version/s: EE-4.2.0.GA
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ace image as resource
    • Assignee Priority:
      P2

      Description

      {code} ace:graphicImage {code} currently has a "name" attribute but no "library" attribute.
      This makes it difficult to use with resources that have a "library" with the "name".

      see showcase example for h:graphicImage page
      contextMenuEffect.xhtml

        Issue Links

          Activity

          Hide
          Mircea Toma added a comment -

          Introduce 'library' attribute for the ace:graphicImage component. Use 'name' and 'library' whenever the 'value' or 'url' attributes are not defined to lookup the resource request path.

          Show
          Mircea Toma added a comment - Introduce 'library' attribute for the ace:graphicImage component. Use 'name' and 'library' whenever the 'value' or 'url' attributes are not defined to lookup the resource request path.
          Hide
          Mircea Toma added a comment - - edited

          I believe there was some confusion what the 'name' attribute was for when the sugestion was made to add the library attribute to the ace:graphicImage component.
          Previous to my changes the 'name' attribute was used for defining the name of the file in the URL that was generated off a byte array.
          The change I put in unfortunately overloads the 'name' attribute, now whenever the 'value' or 'url' attributes are not defined the 'name' and the 'library' attributes are used for looking up a JSF resource, just like h:graphicImage does.

          The Javadoc for the 'name' attribute was updated to clarify new overloaded behaviour.

          Show
          Mircea Toma added a comment - - edited I believe there was some confusion what the 'name' attribute was for when the sugestion was made to add the library attribute to the ace:graphicImage component. Previous to my changes the 'name' attribute was used for defining the name of the file in the URL that was generated off a byte array. The change I put in unfortunately overloads the 'name' attribute, now whenever the 'value' or 'url' attributes are not defined the 'name' and the 'library' attributes are used for looking up a JSF resource, just like h:graphicImage does. The Javadoc for the 'name' attribute was updated to clarify new overloaded behaviour.
          Hide
          Liana Munroe added a comment -

          Verified ICEfaces 4 trunk r51657, Tomcat 8, MS Edge, IE 11, 10, 9, 8, FF 47, Chrome 59.
          Added test app /ICE-11317.jsf to
          http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/graphicImage

          Show
          Liana Munroe added a comment - Verified ICEfaces 4 trunk r51657, Tomcat 8, MS Edge, IE 11, 10, 9, 8, FF 47, Chrome 59. Added test app / ICE-11317 .jsf to http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/graphicImage
          Hide
          Mircea Toma added a comment -

          I had to change the text a bit:

          "If the 'value', 'url' or 'src' attributes are defined the 'name' attribute defines the file name for the graphic image. Alternatively, a value can be specified to reference a JSF resource (also requires the 'library' attribute to be specified)."

          Show
          Mircea Toma added a comment - I had to change the text a bit: "If the 'value', 'url' or 'src' attributes are defined the 'name' attribute defines the file name for the graphic image. Alternatively, a value can be specified to reference a JSF resource (also requires the 'library' attribute to be specified)."

            People

            • Assignee:
              Mircea Toma
              Reporter:
              Judy Guglielmin
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: