ICEfaces
  1. ICEfaces
  2. ICE-11142

Some ace:tabSet showEffect attributes are not rendering properly

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-4.1.0.GA
          • Fix Version/s: 4.2.BETA, 4.2
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            ICEfaces 4 trunk r49216. Tomcat 8, all browsers
          • Assignee Priority:
            P2

            Description

            Some of the ace:tabSet showEffect attributes do not render properly. When changing tabs the content is only partially shown in the first 0.5 second, then loads completely. This may be in part because our test machines as well as my PC run very slow.
            See attached screen shots:
            1.png - The page when first loaded
            2.png - After changing to tab 3, the "Ta" and half of the b are what is initially displayed in the content area.
            3.png - Tab 3 content now fully loaded.
            http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/tabSet
            /tabsetAttribute.jsf was updated to include additional showEffects.
            Many other effects besides "clip" appear to have rendering issues. These effects include:
            blind, shake, puff, slide, and bounce.
            1. 1.PNG
              6 kB
            2. 2.PNG
              6 kB
            3. 3.PNG
              6 kB
            4. 4.png
              11 kB

              Activity

              Ascending order - Click to sort in descending order
              Liana Munroe created issue -
              Liana Munroe made changes -
              Field Original Value New Value
              Attachment 1.PNG [ 22302 ]
              Attachment 2.PNG [ 22303 ]
              Attachment 3.PNG [ 22304 ]
              Ken Fyten made changes -
              Assignee Arturo Zambrano [ artzambrano ]
              Fix Version/s 4.2 [ 12870 ]
              Assignee Priority P2 [ 10011 ]
              Ken Fyten made changes -
              Assignee Arturo Zambrano [ artzambrano ] Mircea Toma [ mircea.toma ]
              Hide
              Permalink
              Mircea Toma added a comment -

              Set temporarily (just before animation is run) the width of the content element to match the width node will have once displayed inside the tab. This allows for the animation to run with an element that does not have a width set to zero by the display: none CSS rule.

              Show
              Mircea Toma added a comment - Set temporarily (just before animation is run) the width of the content element to match the width node will have once displayed inside the tab. This allows for the animation to run with an element that does not have a width set to zero by the display: none CSS rule.
              Mircea Toma made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #49619 Thu Dec 01 17:58:57 MST 2016 mircea.toma ICE-11142 Set temporarily the width of the content node to match the width node will have once displayed inside the tab.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/tabset/tabset.js
              Hide
              Permalink
              Liana Munroe added a comment - - edited

              Tested with ICEfaces 4 trunk r49625. Chrome 53, IE 11, FF 47.
              The width fix appears to have been successful however there seems to be a height issue as well. Please see attached screenshot 4.png. When changing tabs the content appears to be cut off along the bottom for a half second before being fully loaded.

              Show
              Liana Munroe added a comment - - edited Tested with ICEfaces 4 trunk r49625. Chrome 53, IE 11, FF 47. The width fix appears to have been successful however there seems to be a height issue as well. Please see attached screenshot 4.png. When changing tabs the content appears to be cut off along the bottom for a half second before being fully loaded.
              Liana Munroe made changes -
              Attachment 4.png [ 22391 ]
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Hide
              Permalink
              Ken Fyten added a comment -

              The issue with the height is particularly noticeable on Firefox, though occurs on all browsers.

              Show
              Ken Fyten added a comment - The issue with the height is particularly noticeable on Firefox, though occurs on all browsers.
              Hide
              Permalink
              Mircea Toma added a comment -

              Which effect are you talking about? If it's clip then I believe that is the expected behaviour.

              Show
              Mircea Toma added a comment - Which effect are you talking about? If it's clip then I believe that is the expected behaviour.
              Hide
              Permalink
              Ken Fyten added a comment -

              Happens with most of them. The bottom of the tab/text is clipped off during the animation.

              Show
              Ken Fyten added a comment - Happens with most of them. The bottom of the tab/text is clipped off during the animation.
              Hide
              Permalink
              Mircea Toma added a comment - - edited

              Remove ui-tabs-hide CSS class from the parent DIV of the newly selected tab to have the browser set the dimensions of the tab. This ensures that the animation will run on a element that has the width and height defined.

              Removed the previous fix since it is not required anymore.

              Show
              Mircea Toma added a comment - - edited Remove ui-tabs-hide CSS class from the parent DIV of the newly selected tab to have the browser set the dimensions of the tab. This ensures that the animation will run on a element that has the width and height defined. Removed the previous fix since it is not required anymore.
              Mircea Toma made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #49635 Wed Dec 07 11:12:38 MST 2016 mircea.toma ICE-11142 Remove ui-tabs-hide CSS class from the parent DIV of the newly selected tab to have the browser set the dimenstions of the tab.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/tabset/tabset.js
              Hide
              Permalink
              Carmen Cristurean added a comment -

              Verified ICEfaces4 trunk r49636 on IE8, IE11, FF49, Chrome55, MsEdge38, with ace:tabSet QA test app, /tabsetAttribute.jsf test.
              No rendering issues seen with any of the effects.

              Show
              Carmen Cristurean added a comment - Verified ICEfaces4 trunk r49636 on IE8, IE11, FF49, Chrome55, MsEdge38, with ace:tabSet QA test app, /tabsetAttribute.jsf test. No rendering issues seen with any of the effects.
              Ken Fyten made changes -
              Fix Version/s 4.2.BETA [ 13091 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Liana Munroe
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: