ICEfaces
  1. ICEfaces
  2. ICE-11107

icecore:refresh - Refresh causing ace:tabSet showEffect to fire

          Details

            Description

            When using an icecore:refresh tag on a page that has an ace:tabSet, which uses a showEffect, the showEffect is fired on each refresh interval.

            Sample code:
                <h:body>
                    <icecore:refresh interval="1"/>
                    <h:form id="iceForm">
                        <ace:tabSet id="testTabSet"
                                    showEffect="clip">
                            <ace:tabPane label="Tab One">
                                <h:outputText value="Tab One Content"/>
                            </ace:tabPane>
                            <ace:tabPane label="Tab Two">
                                <h:outputText value="Tab Two Content"/>
                            </ace:tabPane>
                            <ace:tabPane label="Tab Three">
                                <h:outputText value="Tab Three Content"/>
                            </ace:tabPane>
                        </ace:tabSet>
                    </h:form>
                </h:body>

            Each time the refresh happens, the clip effect is fired. This issue is not seen on the ICEfaces 3 code base. This might effect other components that render animations as well.

              Activity

              Ascending order - Click to sort in descending order
              Arran Mccullough created issue -
              Hide
              Permalink
              Arran Mccullough added a comment -

              Attached test case that shows this issue.

              Steps:

              • Load welcomeICEfaces.jsf
              • The content of the tabSet will clip on every refresh (1 second intervals).
              Show
              Arran Mccullough added a comment - Attached test case that shows this issue. Steps: Load welcomeICEfaces.jsf The content of the tabSet will clip on every refresh (1 second intervals).
              Arran Mccullough made changes -
              Field Original Value New Value
              Attachment Case13830Example2.war [ 22257 ]
              Attachment Case13830Example2.zip [ 22258 ]
              Ken Fyten made changes -
              Assignee Arturo Zambrano [ artzambrano ]
              Fix Version/s 4.2 [ 12870 ]
              Assignee Priority P1 [ 10010 ]
              Hide
              Permalink
              Arturo Zambrano added a comment -

              r49172: added a flag to inform the client side that the request was an active tab change request. Only in such case the showEffect animation will be run, thus avoiding running it at every interval when using icecore:refresh

              The updateProperties() function, in the ace:tabSet client-side code, is updated at every request, whether there's a change in the markup or not, because of a random-string mechanism added to force this update to solve various other issues. Thus, the icecore:refresh was refreshing the page, and this updateProperties() function was being updated every time, and the animation was being run as well. The fix consists in detecting when the request was actually a tab change request and only in such case run the animation, as per the TLD documentation.

              Testing notes: please run all regression tests involving showEffect in ace:tabSet.

              Show
              Arturo Zambrano added a comment - r49172: added a flag to inform the client side that the request was an active tab change request. Only in such case the showEffect animation will be run, thus avoiding running it at every interval when using icecore:refresh The updateProperties() function, in the ace:tabSet client-side code, is updated at every request, whether there's a change in the markup or not, because of a random-string mechanism added to force this update to solve various other issues. Thus, the icecore:refresh was refreshing the page, and this updateProperties() function was being updated every time, and the animation was being run as well. The fix consists in detecting when the request was actually a tab change request and only in such case run the animation, as per the TLD documentation. Testing notes: please run all regression tests involving showEffect in ace:tabSet.
              Arturo Zambrano made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #49172 Thu Sep 08 13:01:55 MDT 2016 art.zambrano ICE-11107 added a flag to inform the client side that the request was an active tab change request. Only in such case the showEffect animation will be run, thus avoiding running it at every interval when using icecore:refresh
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/tabset/TabSetRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/tabset/tabset.js
              Liana Munroe made changes -
              Attachment 1.PNG [ 22290 ]
              Attachment 2.PNG [ 22291 ]
              Attachment 3.PNG [ 22292 ]
              Liana Munroe made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Those effect issues were occurring before this fix and have to do with the way content is loaded in the tabs. Please create a new JIRA to address those effect issues.

              Show
              Arturo Zambrano added a comment - Those effect issues were occurring before this fix and have to do with the way content is loaded in the tabs. Please create a new JIRA to address those effect issues.
              Arturo Zambrano made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Liana Munroe added a comment -

              http://jira.icesoft.org/browse/ICE-11142 was created to address the effect issues.

              Show
              Liana Munroe added a comment - http://jira.icesoft.org/browse/ICE-11142 was created to address the effect issues.
              Ken Fyten made changes -
              Fix Version/s 4.2.BETA [ 13091 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: