ICEfaces
  1. ICEfaces
  2. ICE-11081

Clean up commented out Annotation code from Mobile Showcase bean classes

          Details

          • Type: Task Task
          • Status: Closed
          • Priority: Minor Minor
          • Resolution: Fixed
          • Affects Version/s: 4.1
          • Fix Version/s: 4.2.BETA, 4.2
          • Component/s: Sample Apps
          • Labels:
            None
          • Environment:
            ICEfaces 4.1 Mobile Showcase samples.
          • Assignee Priority:
            P2
          • Affects:
            Sample App./Tutorial

            Description

            When the Showcase sample was refactored for 4.1 to remove the use of annotations it appears that in the Mobile Showcase demo beans classes the code was only commented out and not removed completely.

            This JIRA is to remove the commented out dead code from the bean classes found under: icefaces\samples\showcase\showcase\src\main\java\org\icefaces\samples\showcase\example\mobi\*

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Ken Fyten added a comment -

              Example of the offending commented code taken from the showcase\example\mobi\scan\QrCodeBean.java class:

              //import org.icemobile.samples.mobileshowcase.view.metadata.annotation.*;
//import org.icemobile.samples.mobileshowcase.view.metadata.context.ExampleImpl;

              /*
@Destination(
        title = "example.layout.dataview.destination.title.short",
        titleExt = "example.layout.dataview.destination.title.long",
        titleBack = "example.layout.dataview.destination.title.back"
)
@Example(
        descriptionPath = "/WEB-INF/includes/examples/layout/dataview-desc.xhtml",
        examplePath = "/WEB-INF/includes/examples/layout/dataview-example.xhtml",
        resourcesPath  = "/WEB-INF/includes/examples/example-resources.xhtml"
)
@ExampleResources(
        resources = {
                // xhtml
                @ExampleResource(type = ResourceType.xhtml,
                                 title = "dataview-example.xhtml",
                                 resource = "/WEB-INF/includes/examples/layout/dataview-example.xhtml"),
                // Java Source
                @ExampleResource(type = ResourceType.java,
                                 title = "DataViewBean.java",
                                 resource = "/WEB-INF/classes/org/icemobile/samples/mobileshowcase" +
                                         "/view/examples/layout/dataview/DataViewBean.java")
        }
)*/
              Show
              Ken Fyten added a comment - Example of the offending commented code taken from the showcase\example\mobi\scan\QrCodeBean.java class: // import org.icemobile.samples.mobileshowcase.view.metadata.annotation.*; // import org.icemobile.samples.mobileshowcase.view.metadata.context.ExampleImpl; /* @Destination( title = "example.layout.dataview.destination.title. short " , titleExt = "example.layout.dataview.destination.title. long " , titleBack = "example.layout.dataview.destination.title.back" ) @Example( descriptionPath = "/WEB-INF/includes/examples/layout/dataview-desc.xhtml" , examplePath = "/WEB-INF/includes/examples/layout/dataview-example.xhtml" , resourcesPath = "/WEB-INF/includes/examples/example-resources.xhtml" ) @ExampleResources( resources = { // xhtml @ExampleResource(type = ResourceType.xhtml, title = "dataview-example.xhtml" , resource = "/WEB-INF/includes/examples/layout/dataview-example.xhtml" ), // Java Source @ExampleResource(type = ResourceType.java, title = "DataViewBean.java" , resource = "/WEB-INF/classes/org/icemobile/samples/mobileshowcase" + "/view/examples/layout/dataview/DataViewBean.java" ) } )*/
              Hide
              Permalink
              Judy Guglielmin added a comment -

              rev 48986

              Show
              Judy Guglielmin added a comment - rev 48986

                People

                • Assignee:
                  Judy Guglielmin
                  Reporter:
                  Ken Fyten
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: