[ICE-10975] icecore:focusManager - Support setting focus to buttons and links - ICEsoft JIRA Issue Tracker

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: EE-3.3.0.GA_P03, 4.1
Fix Version/s: EE-4.1.0.RC1, EE-4.1.0.GA, EE-3.3.0.GA_P04, 4.2.BETA, 4.2
Component/s: ICECORE-Components
Labels:
None
Environment:
All

Assignee Priority:
P2
Support Case References:
Support Case #13708 - https://icesoft.my.salesforce.com/5007000001ZJkDH
Affects:

Documentation (User Guide, Ref. Guide, etc.)

Description

The icecore:focusManager tag only supports setting focus to components that are an instance of UIInput. This request is to see if support for buttons and links can be added so that on load of a page, a button or link can receive focus.

Testing the following code:
            <icecore:focusManager for="buttonTwo">
                <ace:pushButton id="buttonOne" value="Button One"/>
                <ace:pushButton id="buttonTwo" value="Button Two"/>
                <ace:pushButton id="buttonThree" value="Button Three"/>
            </icecore:focusManager>
Shows the following warning: The "for" attribute points to a component that is not an instance of UIInput

Activity

Ascending order - Click to sort in descending order

Arran Mccullough created issue - 24/Feb/16 11:44 AM

Ken Fyten made changes - 02/Mar/16 10:15 AM

Field	Original Value	New Value
Assignee		Mircea Toma [ mircea.toma ]
Fix Version/s		EE-4.1.0.GA [ 12171 ]
Fix Version/s		EE-3.3.0.GA_P04 [ 12270 ]
Assignee Priority		P2 [ 10011 ]

Hide

Permalink

Mircea Toma added a comment - 08/Mar/16 4:40 AM

Implemented Focusable functionality for push and link buttons.

Show

Mircea Toma added a comment - 08/Mar/16 4:40 AM Implemented Focusable functionality for push and link buttons.

Mircea Toma made changes - 08/Mar/16 4:40 AM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#48496	Tue Mar 08 04:45:06 MST 2016	mircea.toma	~~ICE-10975~~ Implemented Focusable functionality for push and link buttons.
				Files Changed
				MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/linkbutton/LinkButton.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/pushbutton/PushButton.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/pushbutton/PushButtonRenderer.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/linkbutton/LinkButtonRenderer.java

Hide

Permalink

Ken Fyten added a comment - 08/Mar/16 10:18 AM

Should also add support for ace:radioButtons and ace:checkboxButtons.

Show

Ken Fyten added a comment - 08/Mar/16 10:18 AM Should also add support for ace:radioButtons and ace:checkboxButtons.

Ken Fyten made changes - 08/Mar/16 10:18 AM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]
Affects		Documentation (User Guide, Ref. Guide, etc.) [ 10003 ]

Hide

Permalink

Carmen Cristurean added a comment - 08/Mar/16 1:11 PM - edited

Added tests for pushButton, linkButton, radioButtons, checkboxButtons with focusManger.
http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/focusManager
Test page: /focusManagerFor.jsf

A regression was found for both ace:pushButton, and ace:linkButton: the actionListener does not appear to fire once linkButton's 'value', or pushButton's 'label' attribute is changed dynamically.
To reproduce, use the Dynamic Attribute QA tests for these components:
http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/linkButton
http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/pushButton
Test pages: /pushButtonDynamic.jsf, or /linkButtonDynamicAttribute.jsf

These regressions cannot be reproduced with ICEfaces 4 Trunk Jenkins Build #1848 (r.48494).

Show

Carmen Cristurean added a comment - 08/Mar/16 1:11 PM - edited Added tests for pushButton, linkButton, radioButtons, checkboxButtons with focusManger. http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/focusManager Test page: /focusManagerFor.jsf A regression was found for both ace:pushButton, and ace:linkButton: the actionListener does not appear to fire once linkButton's 'value', or pushButton's 'label' attribute is changed dynamically. To reproduce, use the Dynamic Attribute QA tests for these components: http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/linkButton http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/pushButton Test pages: /pushButtonDynamic.jsf, or /linkButtonDynamicAttribute.jsf These regressions cannot be reproduced with ICEfaces 4 Trunk Jenkins Build #1848 (r.48494).

Hide

Permalink

Mircea Toma added a comment - 09/Mar/16 6:42 PM

Assign ID to the element that needs to be focused, but do it programmatically to ensure that the DOM updates for the component propagates to the root of its markup.

Show

Mircea Toma added a comment - 09/Mar/16 6:42 PM Assign ID to the element that needs to be focused, but do it programmatically to ensure that the DOM updates for the component propagates to the root of its markup.

Mircea Toma made changes - 09/Mar/16 6:42 PM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#48504	Wed Mar 09 18:42:43 MST 2016	mircea.toma	~~ICE-10975~~ Assign ID to the element that needs to be focus, but do it programmatically to avoid interfering with the DOM updates.
				Files Changed
				MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/pushbutton/PushButtonRenderer.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/linkbutton/LinkButtonRenderer.java

Hide

Permalink

Carmen Cristurean added a comment - 10/Mar/16 9:42 AM

ICEfaces4 trunk r.48505: verified pushButton and linkButton using the QA test apps > Dynamic Attribute tests, on IE11, Chrome48, FF41.

Show

Carmen Cristurean added a comment - 10/Mar/16 9:42 AM ICEfaces4 trunk r.48505: verified pushButton and linkButton using the QA test apps > Dynamic Attribute tests, on IE11, Chrome48, FF41.

Hide

Permalink

Carmen Cristurean added a comment - 10/Mar/16 9:43 AM

Re-opening to add support for ace:radioButtons and ace:checkboxButtons.

Show

Carmen Cristurean added a comment - 10/Mar/16 9:43 AM Re-opening to add support for ace:radioButtons and ace:checkboxButtons.

Carmen Cristurean made changes - 10/Mar/16 9:43 AM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Hide

Permalink

Mircea Toma added a comment - 10/Mar/16 12:29 PM

Added focus support for ace:radioButtons and ace:checkboxButtons.

Show

Mircea Toma added a comment - 10/Mar/16 12:29 PM Added focus support for ace:radioButtons and ace:checkboxButtons .

Mircea Toma made changes - 10/Mar/16 12:29 PM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#48508	Thu Mar 10 12:33:50 MST 2016	mircea.toma	~~ICE-10975~~ Add focus support for ace:radioButtons and ace:checkboxButtons.
				Files Changed
				MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/radiobuttons/RadioButtons.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/checkboxbuttons/CheckboxButtons.java

Ken Fyten made changes - 10/Mar/16 2:38 PM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Ken Fyten made changes - 10/Mar/16 3:13 PM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Ken Fyten made changes - 29/Apr/16 10:31 AM

Fix Version/s

EE-4.1.0.BETA [ 13072 ]

Ken Fyten made changes - 22/Dec/16 10:43 AM

Fix Version/s		4.2.BETA [ 13091 ]
Fix Version/s		4.2 [ 12870 ]

Ken Fyten made changes - 13/Mar/17 1:33 PM

Status

Resolved [ 5 ]

Closed [ 6 ]

People

Assignee:

Mircea Toma

Reporter:

Arran Mccullough

Votes:

0 Vote for this issue

Watchers:

4 Start watching this issue

Dates

Created:

24/Feb/16 11:44 AM

Updated:

13/Mar/17 1:33 PM

Resolved:

10/Mar/16 3:13 PM