Details
-
Type: Improvement
-
Status: Closed
-
Priority: Major
-
Resolution: Fixed
-
Affects Version/s: EE-3.3.0.GA_P03, 4.1
-
Fix Version/s: 4.1.1, EE-3.3.0.GA_P04
-
Component/s: ACE-Components
-
Labels:None
-
Environment:Portlets
-
Assignee Priority:P1
Description
The FileEntryUpload.setPortletRequestWrapper(Object) method should be removed for the following reasons:
1) Calling BridgeContext.getCurrentInstance().setPortletRequest(PortletRequest) reflectively may have been necessary years ago with older versions of the bridge, but isn't anymore. Instead, the simple call to ExternalContext.setRequest(Object) (which FileEntryUpload.java is doing on line 212) is enough.
2) The BridgeContext.setPortletRequest(PortletRequest) method has been removed from the Liferay Faces Bridge API. For more information see https://issues.liferay.com/browse/FACES-2611
1) Calling BridgeContext.getCurrentInstance().setPortletRequest(PortletRequest) reflectively may have been necessary years ago with older versions of the bridge, but isn't anymore. Instead, the simple call to ExternalContext.setRequest(Object) (which FileEntryUpload.java is doing on line 212) is enough.
2) The BridgeContext.setPortletRequest(PortletRequest) method has been removed from the Liferay Faces Bridge API. For more information see https://issues.liferay.com/browse/FACES-2611
Activity
Neil Griffin
created issue -
Ken Fyten
made changes -
Field | Original Value | New Value |
---|---|---|
Assignee | Mircea Toma [ mircea.toma ] | |
Fix Version/s | 4.1.1 [ 12972 ] | |
Assignee Priority | P1 [ 10010 ] |
Mircea Toma
made changes -
Status | Open [ 1 ] | Resolved [ 5 ] |
Resolution | Fixed [ 1 ] |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #48139 | Wed Feb 24 13:40:41 MST 2016 | mircea.toma | |
Files Changed | ||||
MODIFY
/icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/fileentry/FileEntryUpload.java
|
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #48140 | Wed Feb 24 14:16:54 MST 2016 | ken.fyten | |
Files Changed | ||||
MODIFY
/icefaces4/tags/icefaces-4.1.1/icefaces/ace/component/src/org/icefaces/ace/component/fileentry/FileEntryUpload.java
|
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #48141 | Wed Feb 24 14:17:41 MST 2016 | ken.fyten | |
Files Changed | ||||
MODIFY
/icefaces4/branches/icefaces-4.1.1/icefaces/ace/component/src/org/icefaces/ace/component/fileentry/FileEntryUpload.java
|
Ken Fyten
made changes -
Resolution | Fixed [ 1 ] | |
Status | Resolved [ 5 ] | Reopened [ 4 ] |
Ken Fyten
made changes -
Fix Version/s | EE-3.3.0.GA_P04 [ 12270 ] |
Mircea Toma
made changes -
Status | Reopened [ 4 ] | Resolved [ 5 ] |
Resolution | Fixed [ 1 ] |
Ken Fyten
made changes -
Affects Version/s | EE-3.3.0.GA_P03 [ 11572 ] |
Ken Fyten
made changes -
Status | Resolved [ 5 ] | Closed [ 6 ] |
1) I tried running icefaces4-portlet test case with the modified version of FileEntryUpload class where the call to BridgeContext.getCurrentInstance().setPortletRequest(PortletRequest) was removed. Unfortunately there's an exception thrown in Liferay Bridge:
2) Debugging the same test case I can see that the BridgeContext.setPortletRequest method is reflectively acquired, without errors. So the method is still there.
I used liferay-portal-7.0-ce-b7 for testing.