ICEfaces
  1. ICEfaces
  2. ICE-10973

Remove the FileEntryUpload.setPortletRequestWrapper(Object) method

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-3.3.0.GA_P03, 4.1
          • Fix Version/s: 4.1.1, EE-3.3.0.GA_P04
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            Portlets
          • Assignee Priority:
            P1

            Description

            The FileEntryUpload.setPortletRequestWrapper(Object) method should be removed for the following reasons:

            1) Calling BridgeContext.getCurrentInstance().setPortletRequest(PortletRequest) reflectively may have been necessary years ago with older versions of the bridge, but isn't anymore. Instead, the simple call to ExternalContext.setRequest(Object) (which FileEntryUpload.java is doing on line 212) is enough.

            2) The BridgeContext.setPortletRequest(PortletRequest) method has been removed from the Liferay Faces Bridge API. For more information see https://issues.liferay.com/browse/FACES-2611

              Activity

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Neil Griffin
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: