ICEfaces
  1. ICEfaces
  2. ICE-10973

Remove the FileEntryUpload.setPortletRequestWrapper(Object) method

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-3.3.0.GA_P03, 4.1
          • Fix Version/s: 4.1.1, EE-3.3.0.GA_P04
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            Portlets
          • Assignee Priority:
            P1

            Description

            The FileEntryUpload.setPortletRequestWrapper(Object) method should be removed for the following reasons:

            1) Calling BridgeContext.getCurrentInstance().setPortletRequest(PortletRequest) reflectively may have been necessary years ago with older versions of the bridge, but isn't anymore. Instead, the simple call to ExternalContext.setRequest(Object) (which FileEntryUpload.java is doing on line 212) is enough.

            2) The BridgeContext.setPortletRequest(PortletRequest) method has been removed from the Liferay Faces Bridge API. For more information see https://issues.liferay.com/browse/FACES-2611

              Activity

              Repository Revision Date User Message
              ICEsoft Public SVN Repository #48141 Wed Feb 24 14:17:41 MST 2016 ken.fyten ICE-10973 Removed redundant call to method 'setPortletRequestWrapper'.
              Files Changed
              Commit graph MODIFY /icefaces4/branches/icefaces-4.1.1/icefaces/ace/component/src/org/icefaces/ace/component/fileentry/FileEntryUpload.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #48140 Wed Feb 24 14:16:54 MST 2016 ken.fyten ICE-10973 Removed redundant call to method 'setPortletRequestWrapper'.
              Files Changed
              Commit graph MODIFY /icefaces4/tags/icefaces-4.1.1/icefaces/ace/component/src/org/icefaces/ace/component/fileentry/FileEntryUpload.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #48139 Wed Feb 24 13:40:41 MST 2016 mircea.toma ICE-10973 Removed redundant call to method 'setPortletRequestWrapper'.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/fileentry/FileEntryUpload.java

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Neil Griffin
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: