ICEfaces
  1. ICEfaces
  2. ICE-10813

Network Connection Interrupted popup shown on JavaScript error

          Details

            Description

            An NCI popup is shown when a JavaScript error is thrown when trying to open a new window with popups being blocked on the browser.

            This seems to only happen if there is a script error thrown in the browser. If there is no errors then the popup blocker blocks the new window correctly without any NCI popups being displayed.

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Arran Mccullough added a comment -

              Attached test case that shows the issue.

              Steps:

              • In Firefox or Chrome (IE popup blocker doesn't block the popup for some reason) set it to block all popups.
              • Load welcomeICEfaces.jsf
              • Click on the 'Open Window' button
              • The popup blocker should be activated and an NCI popup is shown.
              Show
              Arran Mccullough added a comment - Attached test case that shows the issue. Steps: In Firefox or Chrome (IE popup blocker doesn't block the popup for some reason) set it to block all popups. Load welcomeICEfaces.jsf Click on the 'Open Window' button The popup blocker should be activated and an NCI popup is shown.
              Hide
              Permalink
              Mircea Toma added a comment -

              The issue occurs when either the updated could not be parsed or the JS code (in the update) could not be evaluated. In this case the JS code that pops up the window fails to run because the window pointing to the popup windows is null.

              Modified the callback setup by submitErrorBroadcaster function to avoid rendering the NCI popup when a 'malformedXML' submit error with an OK HTTP response code is captured. A warning is still logged though.

              Show
              Mircea Toma added a comment - The issue occurs when either the updated could not be parsed or the JS code (in the update) could not be evaluated. In this case the JS code that pops up the window fails to run because the window pointing to the popup windows is null. Modified the callback setup by submitErrorBroadcaster function to avoid rendering the NCI popup when a 'malformedXML' submit error with an OK HTTP response code is captured. A warning is still logged though.
              Hide
              Permalink
              Carmen Cristurean added a comment - - edited

              Verified ICEfaces4 trunk r.47057/ EE-3.3.0-maintenance branch r.47057 using attached test case on FF41, Chrome48.

              Show
              Carmen Cristurean added a comment - - edited Verified ICEfaces4 trunk r.47057/ EE-3.3.0-maintenance branch r.47057 using attached test case on FF41, Chrome48.

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: