ICEfaces
  1. ICEfaces
  2. ICE-10735

Add "accesskey" attribute support to all eligible ACE components.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: EE-4.1.0.RC1, EE-4.1.0.GA, 4.2.BETA, 4.2
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ICEfaces 4.1, focusable ACE components.
    • Assignee Priority:
      P2

      Description

      As of ICEfaces 4.0, the ACE components have very limited support for the XHTML "accesskey" attribute.

      In a web browser, accesskey allows a user to immediately jump (set focus) to a specific element on a web page via a keyboard-shortcut.

      As of ICEfaces 4.0, the following ACE components support accesskey:
      - autoCompleteEntry
      - comboBox
      - maskedEntry
      - simpleSelectOneMenu
      - textEntry
      - themeSelect

      In ICEfaces 3 ace:checkboxButton, ace:pushButton, ace:radioButton, and ace:linkButton also supported accesskey, however, their support was lost when certain "unsupported" HTML passthrough attributes were removed from their TLDs in 4.0.

      This JIRA is to add support for the "accesskey" attribute to the following additional ACE components:
      - accordionPane (focus on toggle button)
      - audioPlayer (focus on audio element, actual keyboard support varies by browser)
      - breadcrumbMenu (focus on menu/first focussable element)
      - cellEditor (focus on editor pencil or checkmark button)
      - checkboxButton (focus on button)
      - columm (focus on filter input if rendered, else asc sort button control if rendered) (ICE-10642)
      - dataExporter (focus on button)
      - dataTable (focus on dataTable body)
      - dataTable Paginator (requires keyboard navigation for Paginator)
      - dateTimeEntry (focus on popup entry field only until full keyboard nav support is added to dateTimeEntry)
      - dynamicResource (focus on link, image, or button)
      - fileEntry (focus on Select Files button when multiple=false, need keyboard support for multiple=true)
      - gMap (focus on map viewer)
      - gMapAutoComplete (focus on input element)
      - linkButton (focus on button)
      - menuButton (focus on button)
      - menuItem (focus on menuItem, or not feasible action on menuItem)
      - pushButton (focus on button)
      - radioButton (focus on button)
      - richTextEntry (focus on editable region).
      - selectMenu (focus on input)
      - sliderEntry (focus on slider shuttle)
      - tableConfigPanel (focus on button)
      - tabPane (focus on tab header, requires keyboard navigation support on tabPane - ICE-10643)
      - textAreaEntry (focus on input component)
      - tree (focus on tree body)
      - videoPlayer (focus on video element actual keyboard support varies by browser)

        Issue Links

          Activity

          Hide
          Carmen Cristurean added a comment - - edited

          EE4-trunk r45005/48674/ IE8/11, FF41, Chrome50, MS Edge: verified showcase > richTextEntry, the issue mentioned above is resolved.

          On MS Edge/Windows10 test PC, a browser console error was seen when saving text in the richTextEntry - see ICE-10988.

          Show
          Carmen Cristurean added a comment - - edited EE4-trunk r45005/48674/ IE8/11, FF41, Chrome50, MS Edge: verified showcase > richTextEntry, the issue mentioned above is resolved. On MS Edge/Windows10 test PC, a browser console error was seen when saving text in the richTextEntry - see ICE-10988 .
          Hide
          Arturo Zambrano added a comment -

          The issue above seems unrelated to these changes. Do you know what was the last revision where this wasn't an issue?

          Show
          Arturo Zambrano added a comment - The issue above seems unrelated to these changes. Do you know what was the last revision where this wasn't an issue?
          Hide
          Liana Munroe added a comment -

          ICEfaces 4 trunk r 48675. Also tested with Jenkins build 1857 where the initial commits were made for the accesskeys.
          gMap > accesskey > all browsers - map component does not appear to gain focus when using the accesskey in any browser. When viewing the page markup there is no accesskey attribute associated with the gMap. This is only the case for the gMap component. Not an issue with the gMap autoComplete.

          Show
          Liana Munroe added a comment - ICEfaces 4 trunk r 48675. Also tested with Jenkins build 1857 where the initial commits were made for the accesskeys. gMap > accesskey > all browsers - map component does not appear to gain focus when using the accesskey in any browser. When viewing the page markup there is no accesskey attribute associated with the gMap. This is only the case for the gMap component. Not an issue with the gMap autoComplete.
          Hide
          Arturo Zambrano added a comment -

          r48694: fix to make accesskey work on Chrome for ace:gMap; moved attribute to parent node, which doesn't get replaced by the Google Maps code

          Note that for ace:gMap, having focus doesn't imply that the map can be controlled that way.

          Show
          Arturo Zambrano added a comment - r48694: fix to make accesskey work on Chrome for ace:gMap; moved attribute to parent node, which doesn't get replaced by the Google Maps code Note that for ace:gMap, having focus doesn't imply that the map can be controlled that way.
          Hide
          Liana Munroe added a comment -

          Verified ICEfaces EE-4.1.0 r48694. Tomcat 8, IE Edge, 11, 10, 9, 8, Chrome 50, FF 43.

          Show
          Liana Munroe added a comment - Verified ICEfaces EE-4.1.0 r48694. Tomcat 8, IE Edge, 11, 10, 9, 8, Chrome 50, FF 43.

            People

            • Assignee:
              Arturo Zambrano
              Reporter:
              Ken Fyten
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: