ICEfaces
  1. ICEfaces
  2. ICE-10316

Create tool to speed up the process of minifying javascript resources

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: None
          • Fix Version/s: 4.0
          • Component/s: ACE-Components, MOBI-Components
          • Labels:
            None
          • Environment:
            Any
          • Assignee Priority:
            P1

            Description

            With the recent changes made under ICE-10290, the build process takes a lot longer to complete due to the fact that now several javascript resources are minified individually, instead of as part of a bundle. The root cause is that every time the minifying tool is invoked, it starts a new Java VM, instead of reusing the existing one. Using fork="false" in the build script doesn't work for the minifying tool, so a different approach is necessary.

              Activity

              Ascending order - Click to sort in descending order
              Arturo Zambrano created issue -
              Arturo Zambrano made changes -
              Field Original Value New Value
              Assignee Arturo Zambrano [ artzambrano ]
              Arturo Zambrano made changes -
              Fix Version/s 4.0 [ 11382 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #42885 Tue Oct 14 12:10:16 MDT 2014 art.zambrano ICE-10316 added batchminify tool to speed up the process of compressing javascript resources
              Files Changed
              Commit graph ADD /icefaces4/trunk/icefaces/ace/tools/batchminify/src/org/icefaces
              Commit graph ADD /icefaces4/trunk/icefaces/ace/tools/batchminify/src/org/icefaces/ace/util/batchminify
              Commit graph ADD /icefaces4/trunk/icefaces/ace/tools/batchminify/readme.txt
              Commit graph ADD /icefaces4/trunk/icefaces/ace/tools/batchminify/src
              Commit graph ADD /icefaces4/trunk/icefaces/ace/tools/batchminify
              Commit graph ADD /icefaces4/trunk/icefaces/ace/tools/batchminify/src/org/icefaces/ace
              Commit graph ADD /icefaces4/trunk/icefaces/ace/tools/batchminify/src/org/icefaces/ace/util
              Commit graph ADD /icefaces4/trunk/icefaces/ace/tools/batchminify/src/org/icefaces/ace/util/batchminify/BatchMinify.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/build.xml
              Commit graph ADD /icefaces4/trunk/icefaces/ace/tools/batchminify/src/org
              Commit graph ADD /icefaces4/trunk/icefaces/ace/tools/batchminify/build.xml
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Added batchminify tool to speed up the process of compressing javascript files, at revision 42885.

              Show
              Arturo Zambrano added a comment - Added batchminify tool to speed up the process of compressing javascript files, at revision 42885.
              Arturo Zambrano made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Ken Fyten added a comment -

              Note that the bulk minification process is failing on both my local OSX checkout, and in the Jenkins linux-based build:

              • On my OSX build, every attempt to invoke the bulk compressor fails with "[java] ERROR - Cannot read: xxx".
              Show
              Ken Fyten added a comment - Note that the bulk minification process is failing on both my local OSX checkout, and in the Jenkins linux-based build: On my OSX build, every attempt to invoke the bulk compressor fails with " [java] ERROR - Cannot read: xxx". On Jenkins, see: http://dev.icesoft.com/jenkins/job/ICEfaces%204%20Trunk%20(Continuous)/765/consoleFull and search through the page for "res-js-compress:" to find the failures.
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Assignee Priority P1 [ 10010 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #42894 Wed Oct 15 12:09:09 MDT 2014 art.zambrano ICE-10316 added quotes around the list of paths so everything gets treated as a single argument and thus avoid issues when paths contain spaces
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/build.xml
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/build.xml
              Hide
              Permalink
              Arturo Zambrano added a comment -

              r42894: added quotes around the list of paths passed to the batch minify tool so everything gets treated as a single argument, and, thus, it prevents issues when paths contain spaces.

              Show
              Arturo Zambrano added a comment - r42894: added quotes around the list of paths passed to the batch minify tool so everything gets treated as a single argument, and, thus, it prevents issues when paths contain spaces.
              Arturo Zambrano made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #42895 Wed Oct 15 13:47:28 MDT 2014 art.zambrano ICE-10316 added specific path separator character to compress target, in order to make things work in the same way across operating systems
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/build.xml
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/build.xml
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Arturo Zambrano
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: