ICEfaces
  1. ICEfaces
  2. ICE-10316

Create tool to speed up the process of minifying javascript resources

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0
    • Labels:
      None
    • Environment:
      Any
    • Assignee Priority:
      P1

      Description

      With the recent changes made under ICE-10290, the build process takes a lot longer to complete due to the fact that now several javascript resources are minified individually, instead of as part of a bundle. The root cause is that every time the minifying tool is invoked, it starts a new Java VM, instead of reusing the existing one. Using fork="false" in the build script doesn't work for the minifying tool, so a different approach is necessary.

        Activity

        Hide
        Arturo Zambrano added a comment -

        Added batchminify tool to speed up the process of compressing javascript files, at revision 42885.

        Show
        Arturo Zambrano added a comment - Added batchminify tool to speed up the process of compressing javascript files, at revision 42885.
        Hide
        Ken Fyten added a comment -

        Note that the bulk minification process is failing on both my local OSX checkout, and in the Jenkins linux-based build:

        • On my OSX build, every attempt to invoke the bulk compressor fails with "[java] ERROR - Cannot read: xxx".
        Show
        Ken Fyten added a comment - Note that the bulk minification process is failing on both my local OSX checkout, and in the Jenkins linux-based build: On my OSX build, every attempt to invoke the bulk compressor fails with " [java] ERROR - Cannot read: xxx". On Jenkins, see: http://dev.icesoft.com/jenkins/job/ICEfaces%204%20Trunk%20(Continuous)/765/consoleFull and search through the page for "res-js-compress:" to find the failures.
        Hide
        Arturo Zambrano added a comment -

        r42894: added quotes around the list of paths passed to the batch minify tool so everything gets treated as a single argument, and, thus, it prevents issues when paths contain spaces.

        Show
        Arturo Zambrano added a comment - r42894: added quotes around the list of paths passed to the batch minify tool so everything gets treated as a single argument, and, thus, it prevents issues when paths contain spaces.

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Arturo Zambrano
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: