ICEfaces
  1. ICEfaces
  2. ICE-10290

Rationalize ACE JavaScript Resource Dependencies

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ICEfaces 4 ACE Components
    • Assignee Priority:
      P1

      Description

      With the resource coalescing and head-update capabilities provided in ICEfaces 4, we need to review the ace-components.js file contents to see if we can lower it's footprint by selectively removing JS for certain components, especially those with larger JS footprints.

        Issue Links

          Activity

          Hide
          Krashan Brahmanjara added a comment -

          Attached footprint at revision 42886

          Show
          Krashan Brahmanjara added a comment - Attached footprint at revision 42886
          Hide
          Arturo Zambrano added a comment -

          You can use resource coalescing to serve all javascript resources in just one file.

          http://www.icesoft.org/wiki/display/ICE/coalesceResources

          Show
          Arturo Zambrano added a comment - You can use resource coalescing to serve all javascript resources in just one file. http://www.icesoft.org/wiki/display/ICE/coalesceResources
          Hide
          Krashan Brahmanjara added a comment -

          True resource coalescing helps

          revision 42640
          pageLoad:1.56s, javascripts:10, script size: 477kB
          revision 42886 org.icefaces.coalesceResources=false
          pageLoad:1.31s, javascripts:17, script size: 206kB
          revision 42886 org.icefaces.coalesceResources=true
          pageLoad:1.22s, javascripts:2, script size: 201kB

          But it can't be used immediately. CoalesceResources true change something and page with primeface schedule component isn't displayed correctly anymore.

          Show
          Krashan Brahmanjara added a comment - True resource coalescing helps revision 42640 pageLoad:1.56s, javascripts:10, script size: 477kB revision 42886 org.icefaces.coalesceResources=false pageLoad:1.31s, javascripts:17, script size: 206kB revision 42886 org.icefaces.coalesceResources=true pageLoad:1.22s, javascripts:2, script size: 201kB But it can't be used immediately. CoalesceResources true change something and page with primeface schedule component isn't displayed correctly anymore.
          Hide
          Ken Fyten added a comment -

          Note that as of rvn #42722 all the ACE component .js files are now being minified.

          Show
          Ken Fyten added a comment - Note that as of rvn #42722 all the ACE component .js files are now being minified.
          Hide
          Krashan Brahmanjara added a comment -

          Ken. MInification was available many years before 42722 (no-compress flag). We use this solution (minification and compression) in production systems with success.

          Solution added after #42640 is good idea but is unnecessary.
          Also coalescing isn't compatibile with this patch. It disables caching and creates new javax.faces.resource/coalesced.js.iface file on each request - I definately see different sizes of this file on each request.

          Summary the I can suggest to restore previous solution with selection based on development mode (orignal or minified js send to client) also coalesce should generate stable cacheable (on client and server) response

          Show
          Krashan Brahmanjara added a comment - Ken. MInification was available many years before 42722 (no-compress flag). We use this solution (minification and compression) in production systems with success. Solution added after #42640 is good idea but is unnecessary. Also coalescing isn't compatibile with this patch. It disables caching and creates new javax.faces.resource/coalesced.js.iface file on each request - I definately see different sizes of this file on each request. Summary the I can suggest to restore previous solution with selection based on development mode (orignal or minified js send to client) also coalesce should generate stable cacheable (on client and server) response

            People

            • Assignee:
              Arturo Zambrano
              Reporter:
              Ken Fyten
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: