ICEfaces
  1. ICEfaces
  2. ICE-10226

ace:messages styleClass issue

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Minor Minor
          • Resolution: Fixed
          • Affects Version/s: EE-3.3.0.GA_P02, 4.0
          • Fix Version/s: EE-4.0.0.GA, EE-3.3.0.GA_P03, 4.1
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            Tomcat 7, all browsers, ICEfaces 4 trunk r42492.
          • Assignee Priority:
            P1

            Description

            When a styleClass such as border is used as an attribute with ace:messages, the styleClass is displayed before the Show Messages button is pressed. I am not sure if a border is a suitable styleClass for ace:messages. See before and after screenshots.
            When using a styleClass that increases font-size in the messages for example, there are no issues.
            Test application /messagesDynamicAttribute.jsf located at:
            http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Manual/messages
            1. after.PNG
              24 kB
            2. before.PNG
              16 kB

              Issue Links

              blocks

              Task - A task that needs to be done. ICE-11077 Remove extraneous System.outs from ACE MessagesRenderer

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Liana Munroe created issue -
                Liana Munroe made changes -
                Field Original Value New Value
                Attachment before.PNG [ 17353 ]
                Attachment after.PNG [ 17354 ]
                Liana Munroe made changes -
                Affects Version/s 4.0 [ 11382 ]
                Hide
                Permalink
                Carmen Cristurean added a comment -

                Still reproducible with IF 4.0 release code (ICEfaces4 trunk r. 43353).

                Show
                Carmen Cristurean added a comment - Still reproducible with IF 4.0 release code (ICEfaces4 trunk r. 43353).
                Ken Fyten made changes -
                Assignee Arturo Zambrano [ artzambrano ]
                Fix Version/s EE-4.0.0.GA [ 11171 ]
                Priority Major [ 3 ] Minor [ 4 ]
                Component/s ACE-Components [ 10050 ]
                Ken Fyten made changes -
                Assignee Arturo Zambrano [ artzambrano ] Judy Guglielmin [ judy.guglielmin ]
                Assignee Priority P1 [ 10010 ]
                Ken Fyten made changes -
                Assignee Judy Guglielmin [ judy.guglielmin ] Arturo Zambrano [ artzambrano ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #43968 Wed Jan 28 16:25:13 MST 2015 art.zambrano ICE-10226 modified renderer classes to only render the style and styleClass attributes when the component is actually displaying messages
                Files Changed
                Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/messages/MessagesRenderer.java
                Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/message/MessageRenderer.java
                Hide
                Permalink
                Arturo Zambrano added a comment -

                r43968: modified renderer classes to only render the style and styleClass attributes when the component is actually displaying messages.

                Show
                Arturo Zambrano added a comment - r43968: modified renderer classes to only render the style and styleClass attributes when the component is actually displaying messages.
                Arturo Zambrano made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Hide
                Permalink
                Liana Munroe added a comment -

                Verified ICEfaces 4 trunk r43974. Tomcat 7, FF 34, Chrome 39, IE 8, 9, 10 11.

                Show
                Liana Munroe added a comment - Verified ICEfaces 4 trunk r43974. Tomcat 7, FF 34, Chrome 39, IE 8, 9, 10 11.
                Judy Guglielmin made changes -
                Assignee Arturo Zambrano [ artzambrano ] Judy Guglielmin [ judy.guglielmin ]
                Judy Guglielmin made changes -
                Assignee Judy Guglielmin [ judy.guglielmin ] Arturo Zambrano [ artzambrano ]
                Hide
                Permalink
                Liana Munroe added a comment -

                Issue exists on EE-3.3.0 maintenance branch r44456.

                Show
                Liana Munroe added a comment - Issue exists on EE-3.3.0 maintenance branch r44456.
                Judy Guglielmin made changes -
                Resolution Fixed [ 1 ]
                Status Resolved [ 5 ] Reopened [ 4 ]
                Assignee Arturo Zambrano [ artzambrano ] Judy Guglielmin [ judy.guglielmin ]
                Security Private [ 10001 ]
                Judy Guglielmin made changes -
                Fix Version/s EE-3.3.0.GA_P03 [ 11572 ]
                Judy Guglielmin made changes -
                Affects Version/s EE-3.3.0.GA_P02 [ 11371 ]
                Hide
                Permalink
                Judy Guglielmin added a comment -

                rev. 44492 backported fix from IF4

                Show
                Judy Guglielmin added a comment - rev. 44492 backported fix from IF4
                Judy Guglielmin made changes -
                Status Reopened [ 4 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Hide
                Permalink
                Liana Munroe added a comment - - edited

                Tested with ICEfaces EE-3.3.0 maintenance branch r44495. No styling is applied to messages, all browsers. Not an issue with ICEfaces 4 trunk.
                Test application /messagesDynamicAttribute.jsf
                http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Manual/messages

                Server log:
                Apr 14, 2015 12:35:22 PM com.sun.faces.renderkit.html_basic.HtmlBasicRenderer ge
                tForComponent
                WARNING: Unable to find component with ID styleClass in view.
                Apr 14, 2015 12:35:22 PM com.sun.faces.renderkit.html_basic.HtmlBasicRenderer ge
                tForComponent
                WARNING: Unable to find component with ID initEffect in view.
                Apr 14, 2015 12:35:22 PM com.sun.faces.renderkit.html_basic.HtmlBasicRenderer ge
                tForComponent
                WARNING: Unable to find component with ID initEffectDuration in view.

                Show
                Liana Munroe added a comment - - edited Tested with ICEfaces EE-3.3.0 maintenance branch r44495. No styling is applied to messages, all browsers. Not an issue with ICEfaces 4 trunk. Test application /messagesDynamicAttribute.jsf http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Manual/messages Server log: Apr 14, 2015 12:35:22 PM com.sun.faces.renderkit.html_basic.HtmlBasicRenderer ge tForComponent WARNING: Unable to find component with ID styleClass in view. Apr 14, 2015 12:35:22 PM com.sun.faces.renderkit.html_basic.HtmlBasicRenderer ge tForComponent WARNING: Unable to find component with ID initEffect in view. Apr 14, 2015 12:35:22 PM com.sun.faces.renderkit.html_basic.HtmlBasicRenderer ge tForComponent WARNING: Unable to find component with ID initEffectDuration in view.
                Liana Munroe made changes -
                Resolution Fixed [ 1 ]
                Status Resolved [ 5 ] Reopened [ 4 ]
                Ken Fyten made changes -
                Assignee Judy Guglielmin [ judy.guglielmin ] Arturo Zambrano [ artzambrano ]
                Hide
                Permalink
                Arturo Zambrano added a comment -

                r44500: corrected backport fix, as it needed to be done in a slightly different way in the 3.3 ee maintenance branch; also corrected the ids used in the 'for' attributes on the test page to avoid those server messages.

                Show
                Arturo Zambrano added a comment - r44500: corrected backport fix, as it needed to be done in a slightly different way in the 3.3 ee maintenance branch; also corrected the ids used in the 'for' attributes on the test page to avoid those server messages.
                Arturo Zambrano made changes -
                Status Reopened [ 4 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Hide
                Permalink
                Liana Munroe added a comment -

                Verified ICEfaces EE-3.3.0 maintenance branch r44500. Tomcat 7, IE 11, FF 34, Chrome 41

                Show
                Liana Munroe added a comment - Verified ICEfaces EE-3.3.0 maintenance branch r44500. Tomcat 7, IE 11, FF 34, Chrome 41
                Ken Fyten made changes -
                Security Private [ 10001 ]
                Ken Fyten made changes -
                Fix Version/s 4.1 [ 11375 ]
                Judy Guglielmin made changes -
                Resolution Fixed [ 1 ]
                Status Resolved [ 5 ] Reopened [ 4 ]
                Judy Guglielmin made changes -
                Link This issue blocks ICE-11077 [ ICE-11077 ]
                Hide
                Permalink
                Liana Munroe added a comment -

                Verified println statements removed ICEfaces 4 trunk, EE-3.3.0 maintenance branch r48967.

                Show
                Liana Munroe added a comment - Verified println statements removed ICEfaces 4 trunk, EE-3.3.0 maintenance branch r48967.
                Ken Fyten made changes -
                Status Reopened [ 4 ] Closed [ 6 ]
                Resolution Fixed [ 1 ]

                  People

                  • Assignee:
                    Arturo Zambrano
                    Reporter:
                    Liana Munroe
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    5 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: