ICEpush
  1. ICEpush
  2. PUSH-410

Allow for multiple pending Cloud Push Notifications for a single Browser-ID

    Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-4.0.0.GA, 4.1
    • Fix Version/s: EE-4.2.0.GA
    • Component/s: Push Library
    • Labels:
      None
    • Environment:
      ICEpush, Cloud Push

      Description

      Allow for multiple pending Cloud Push Notifications for a single Browser-ID even when issued in a more rapid succession. It is up to the developer to throttle if needed.

        Issue Links

          Activity

          Jack Van Ooststroom created issue -
          Jack Van Ooststroom made changes -
          Field Original Value New Value
          Assignee Jack Van Ooststroom [ jack.van.ooststroom ]
          Hide
          Jack Van Ooststroom added a comment -

          Sending icepush-ee/core/src/main/java/org/icepush/ConfirmationTimeout.java
          Sending icepush-ee/core/src/main/java/org/icepush/LocalPushGroupManager.java
          Transmitting file data ..
          Committed revision 48702.

          Sending icepush-ee/eps/src/main/java/com/icesoft/push/ConfirmationTimeout.java
          Sending icepush-ee/eps/src/main/java/com/icesoft/push/LocalPushGroupManager.java
          Transmitting file data ..
          Committed revision 45030.

          Show
          Jack Van Ooststroom added a comment - Sending icepush-ee/core/src/main/java/org/icepush/ConfirmationTimeout.java Sending icepush-ee/core/src/main/java/org/icepush/LocalPushGroupManager.java Transmitting file data .. Committed revision 48702. Sending icepush-ee/eps/src/main/java/com/icesoft/push/ConfirmationTimeout.java Sending icepush-ee/eps/src/main/java/com/icesoft/push/LocalPushGroupManager.java Transmitting file data .. Committed revision 45030.
          Hide
          Jack Van Ooststroom added a comment - - edited

          The ConfirmationTimeout now holds a Set containing CloudPushNotifications. This new CloudPushNotification class holds the usual browserID, propertyMap, and such which were previously contained within the ConfirmationTimeout itself. Both classes are responsible for proper clean-up to avoid undesired collection growth. When a listen.icepush request comes in the original logic still stands where any pending CloudPushNotification (before ConfirmationTimeout) associated with the incoming Browser-ID gets cancelled unless a CloudPushNotification is marked as forced. Marking this one as FIXED.

          Show
          Jack Van Ooststroom added a comment - - edited The ConfirmationTimeout now holds a Set containing CloudPushNotifications . This new CloudPushNotification class holds the usual browserID , propertyMap , and such which were previously contained within the ConfirmationTimeout itself. Both classes are responsible for proper clean-up to avoid undesired collection growth. When a listen.icepush request comes in the original logic still stands where any pending CloudPushNotification (before ConfirmationTimeout ) associated with the incoming Browser-ID gets cancelled unless a CloudPushNotification is marked as forced . Marking this one as FIXED.
          Jack Van Ooststroom made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s EE-4.1.0.BETA [ 13073 ]
          Resolution Fixed [ 1 ]
          Jack Van Ooststroom made changes -
          Link This issue depends on PUSH-409 [ PUSH-409 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #48702 Thu May 05 16:26:15 MDT 2016 jack.van.ooststroom Fixed JIRA PUSH-410 : Allow for multiple pending Cloud Push Notifications for a single Browser-ID
          Files Changed
          Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/LocalPushGroupManager.java
          Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/ConfirmationTimeout.java
          Ken Fyten made changes -
          Fix Version/s EE-4.1.0.GA [ 12172 ]
          Ken Fyten made changes -
          Fix Version/s EE-4.1.1.BETA [ 13077 ]
          Fix Version/s EE-4.1.0.GA [ 12172 ]
          Fix Version/s EE-4.1.0.RC1 [ 13073 ]
          Ken Fyten made changes -
          Fix Version/s EE-4.2.0.GA [ 13074 ]
          Fix Version/s EE-4.1.1.BETA [ 13077 ]

            People

            • Assignee:
              Jack Van Ooststroom
              Reporter:
              Jack Van Ooststroom
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: