ICEpush
  1. ICEpush
  2. PUSH-407

Add the lifetime of Browser-ID to the Set-Cookie header for Browser-ID

          Details

          • Type: New Feature New Feature
          • Status: Resolved
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-4.0.0.GA, 4.1
          • Fix Version/s: EE-4.2.0.GA
          • Component/s: Push Library
          • Labels:
            None
          • Environment:
            ICEpush, Safari, iOS

            Description

            When using Safari on iOS, upon killing Safari the Browser-ID Cookie gets deleted as it is currently considered a Session Cookie. But with Cloud Push, we already want things like Browser-IDs, Push-IDs and Notify-Back-URIs to survive past the sessions. We should add the lifetime of the Browser-ID, set at the server-side, to the Set-Cookie header for the Browser-ID Cookie in order to do so.

              Activity

              Ascending order - Click to sort in descending order
              8 older comments
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              I back-ported the "second-part" fix for this one to the EE 4.1.1.BETA tag.

              Show
              Jack Van Ooststroom added a comment - I back-ported the "second-part" fix for this one to the EE 4.1.1.BETA tag.
              Hide
              Permalink
              Carmen Cristurean added a comment - - edited

              Verified EE-4.1.1.BETA tag r.48822, and Jenkins Build #3 /showcase-portlet on Liferay 6.2 g5 on IE11, FF41, Chrome45.

              Show
              Carmen Cristurean added a comment - - edited Verified EE-4.1.1.BETA tag r.48822, and Jenkins Build #3 /showcase-portlet on Liferay 6.2 g5 on IE11, FF41, Chrome45.
              Hide
              Permalink
              Mircea Toma added a comment -

              Having an expiry date on the ice.push.browser cookie causes the ICEfaces applications to stop working. See ICE-11020. The problem starts occurring whenever the cookie expiry interval is lower than the one set for session expiry.
              Also the cookie expiration is enforced regardless of user or server activity, once the defined interval has elapsed the cookie is removed by the browser.

              Show
              Mircea Toma added a comment - Having an expiry date on the ice.push.browser cookie causes the ICEfaces applications to stop working. See ICE-11020 . The problem starts occurring whenever the cookie expiry interval is lower than the one set for session expiry. Also the cookie expiration is enforced regardless of user or server activity, once the defined interval has elapsed the cookie is removed by the browser.
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              Sending icepush/core/src/main/java/org/icepush/Browser.java
              Transmitting file data .
              Committed revision 48872.

              Show
              Jack Van Ooststroom added a comment - Sending icepush/core/src/main/java/org/icepush/Browser.java Transmitting file data . Committed revision 48872.
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              As for robust Cloud Push support the Browser-ID cookie's default expiry is now set to 3 years. Ensuring it survives across sessions and doesn't interfere with the current session. Marking this one as FIXED again.

              Show
              Jack Van Ooststroom added a comment - As for robust Cloud Push support the Browser-ID cookie's default expiry is now set to 3 years. Ensuring it survives across sessions and doesn't interfere with the current session. Marking this one as FIXED again.

                People

                • Assignee:
                  Jack Van Ooststroom
                  Reporter:
                  Jack Van Ooststroom
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: