ICEpush
  1. ICEpush
  2. PUSH-402

Remove the minCloudPushInterval and its usage

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-4.0.0.GA, 4.1
    • Fix Version/s: EE-4.2.0.GA
    • Component/s: Push Library
    • Labels:
      None
    • Environment:
      ICEpush
    • Assignee Priority:
      P1

      Description

      The minCloudPushInterval and its usage should be removed from ICEpush. As a result the application developer is responsible for ensuring a Cloud Push storm does not occur. This is to avoid the dropping of Cloud Push Notifications if by chance they are within this interval.

        Activity

        Jack Van Ooststroom created issue -
        Jack Van Ooststroom made changes -
        Field Original Value New Value
        Assignee Jack Van Ooststroom [ jack.van.ooststroom ]
        Jack Van Ooststroom made changes -
        Fix Version/s EE-4.1.0.GA [ 12172 ]
        Hide
        Jack Van Ooststroom added a comment -

        Sending icepush/core/src/main/java/org/icepush/Browser.java
        Sending icepush/core/src/main/java/org/icepush/ConfirmationTimeout.java
        Sending icepush/core/src/main/java/org/icepush/LocalPushGroupManager.java
        Sending icepush/core/src/main/java/org/icepush/servlet/BrowserDispatcher.java
        Transmitting file data ....
        Committed revision 48639.

        Show
        Jack Van Ooststroom added a comment - Sending icepush/core/src/main/java/org/icepush/Browser.java Sending icepush/core/src/main/java/org/icepush/ConfirmationTimeout.java Sending icepush/core/src/main/java/org/icepush/LocalPushGroupManager.java Sending icepush/core/src/main/java/org/icepush/servlet/BrowserDispatcher.java Transmitting file data .... Committed revision 48639.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #48639 Tue Apr 19 16:49:28 MDT 2016 jack.van.ooststroom Fixed JIRA PUSH-402 : Remove the minCloudPushInterval and its usage
        Files Changed
        Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/Browser.java
        Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/LocalPushGroupManager.java
        Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/servlet/BrowserDispatcher.java
        Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/ConfirmationTimeout.java
        Hide
        Jack Van Ooststroom added a comment -

        Sending icepush-ee/eps/src/main/java/com/icesoft/push/Browser.java
        Sending icepush-ee/eps/src/main/java/com/icesoft/push/ConfirmationTimeout.java
        Sending icepush-ee/eps/src/main/java/com/icesoft/push/LocalPushGroupManager.java
        Sending icepush-ee/eps/src/main/java/com/icesoft/push/servlet/BrowserDispatcher.java
        Transmitting file data ....
        Committed revision 44968.

        Show
        Jack Van Ooststroom added a comment - Sending icepush-ee/eps/src/main/java/com/icesoft/push/Browser.java Sending icepush-ee/eps/src/main/java/com/icesoft/push/ConfirmationTimeout.java Sending icepush-ee/eps/src/main/java/com/icesoft/push/LocalPushGroupManager.java Sending icepush-ee/eps/src/main/java/com/icesoft/push/servlet/BrowserDispatcher.java Transmitting file data .... Committed revision 44968.
        Hide
        Jack Van Ooststroom added a comment -

        The minCloudPushInterval and its usage has been removed at both the ICEpush and ICEpush-EE levels. It is now the responsibility of the application developer to avoid unintended Cloud Push Notification "storms". Marking this one as FIXED.

        Show
        Jack Van Ooststroom added a comment - The minCloudPushInterval and its usage has been removed at both the ICEpush and ICEpush-EE levels. It is now the responsibility of the application developer to avoid unintended Cloud Push Notification "storms". Marking this one as FIXED.
        Jack Van Ooststroom made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Ken Fyten added a comment - - edited

        Re-opened due to testing failures:

        Tested with ICEfaces EE-4.1. r48645,
        ipad ios 9, android nexus 5 version 6.0.1

        cloudPush scenarios
        1.) Go to registration page, enable cloudPush.
        Go to redPage, send message.
        Go to yellowPage, send message.
        Minimize browser.
        Fail android- Only the red notification comes through.
        Pass ios - Both notifications come through. (Liana reports only receiving one notification on iPad sometimes).

        Show
        Ken Fyten added a comment - - edited Re-opened due to testing failures: Tested with ICEfaces EE-4.1. r48645, ipad ios 9, android nexus 5 version 6.0.1 cloudPush scenarios 1.) Go to registration page, enable cloudPush. Go to redPage, send message. Go to yellowPage, send message. Minimize browser. Fail android- Only the red notification comes through. Pass ios - Both notifications come through. (Liana reports only receiving one notification on iPad sometimes).
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Priority P1 [ 10010 ]
        Ken Fyten made changes -
        Fix Version/s EE-4.1.0.BETA [ 13073 ]
        Hide
        Liana Munroe added a comment -

        Tested with Labs 1 server, ios 9.3.1 and android 6.0.1 devices.
        Multiple messages are now arriving on devices as expected.

        Show
        Liana Munroe added a comment - Tested with Labs 1 server, ios 9.3.1 and android 6.0.1 devices. Multiple messages are now arriving on devices as expected.
        Hide
        Jack Van Ooststroom added a comment -

        Sending icepush-ee/core/src/main/java/org/icepush/LocalPushGroupManager.java
        Transmitting file data .
        Committed revision 48698.

        Show
        Jack Van Ooststroom added a comment - Sending icepush-ee/core/src/main/java/org/icepush/LocalPushGroupManager.java Transmitting file data . Committed revision 48698.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #48698 Thu May 05 16:11:50 MDT 2016 jack.van.ooststroom Fixed JIRA PUSH-402 : Remove the minCloudPushInterval and its usage; Removed final remnant.
        Files Changed
        Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/LocalPushGroupManager.java
        Hide
        Jack Van Ooststroom added a comment -

        The scenario mentioned by Ken has been addressed in PUSH-410.

        Show
        Jack Van Ooststroom added a comment - The scenario mentioned by Ken has been addressed in PUSH-410 .
        Hide
        Jack Van Ooststroom added a comment -

        The old minCloudPushInterval logic has been removed. Marking this one as FIXED again.

        Show
        Jack Van Ooststroom added a comment - The old minCloudPushInterval logic has been removed. Marking this one as FIXED again.
        Jack Van Ooststroom made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s EE-4.1.1.BETA [ 13077 ]
        Fix Version/s EE-4.1.0.GA [ 12172 ]
        Fix Version/s EE-4.1.0.RC1 [ 13073 ]
        Ken Fyten made changes -
        Fix Version/s EE-4.2.0.GA [ 13074 ]
        Fix Version/s EE-4.1.1.BETA [ 13077 ]

          People

          • Assignee:
            Jack Van Ooststroom
            Reporter:
            Jack Van Ooststroom
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: