ICEpush
  1. ICEpush
  2. PUSH-389

Add support for subject, detail, and uri to the JavaScript API's notify function

    Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-4.0.0.GA, 4.1
    • Fix Version/s: EE-4.2.0.GA
    • Labels:
      None
    • Environment:
      ICEpush JavaScript Bridge, ICEpush Core

      Description

      The server-side Java API already supports specifying a subject, detail and uri when issuing a request for a push through PushContext's push(groupName, pushConfiguration) and push(groupName, payload, pushConfiguration) methods. Similar support should be added to the JavaScript Bridge's notify function. This would also lead to changing the server-side's PushConfiguration's fromRequest(request) method.

        Activity

        Jack Van Ooststroom created issue -
        Jack Van Ooststroom made changes -
        Field Original Value New Value
        Assignee Jack Van Ooststroom [ jack.van.ooststroom ]
        Jack Van Ooststroom made changes -
        Fix Version/s EE-4.1.0.GA [ 12172 ]
        Jack Van Ooststroom made changes -
        Component/s Push Library [ 10044 ]
        Hide
        Jack Van Ooststroom added a comment -

        Please note that if the subject is specified the uri must be mandatory.

        Show
        Jack Van Ooststroom added a comment - Please note that if the subject is specified the uri must be mandatory.
        Hide
        Jack Van Ooststroom added a comment -

        Also note that the uri must be named the same as in PUSH-388.

        Show
        Jack Van Ooststroom added a comment - Also note that the uri must be named the same as in PUSH-388 .
        Hide
        Jack Van Ooststroom added a comment -

        For the uri the name targetURI must be used as per PUSH-388.

        Show
        Jack Van Ooststroom added a comment - For the uri the name targetURI must be used as per PUSH-388 .
        Hide
        Jack Van Ooststroom added a comment -

        As long as the requests option is being used to populate the notify.icepush request, the server-side's PushConfiguration does not seem to require any modification.

        Show
        Jack Van Ooststroom added a comment - As long as the requests option is being used to populate the notify.icepush request, the server-side's PushConfiguration does not seem to require any modification.
        Hide
        Mircea Toma added a comment -

        I would parse them since these parameters are part of the API now.

        Show
        Mircea Toma added a comment - I would parse them since these parameters are part of the API now.
        Hide
        Jack Van Ooststroom added a comment -

        Sending icepush/core/src/main/java/org/icepush/PushConfiguration.java
        Sending icepush/core/src/main/javascript/application.js
        Transmitting file data ..
        Committed revision 48589.

        Show
        Jack Van Ooststroom added a comment - Sending icepush/core/src/main/java/org/icepush/PushConfiguration.java Sending icepush/core/src/main/javascript/application.js Transmitting file data .. Committed revision 48589.
        Hide
        Jack Van Ooststroom added a comment -

        The JavaScript Bridge's notify function parses the subject, detail and targetURI from the options parameter as they are part of the API now. On the server-side the PushConfiguration's fromRequest(...) method has been updated to add these to the attributeMap of the PushConfiguration for now. On the server-side they have a different treatment as the at, delay and duration for now.

        Marking this one as FIXED.

        Show
        Jack Van Ooststroom added a comment - The JavaScript Bridge's notify function parses the subject , detail and targetURI from the options parameter as they are part of the API now. On the server-side the PushConfiguration 's fromRequest(...) method has been updated to add these to the attributeMap of the PushConfiguration for now. On the server-side they have a different treatment as the at , delay and duration for now. Marking this one as FIXED.
        Jack Van Ooststroom made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #48589 Thu Mar 31 17:40:59 MDT 2016 jack.van.ooststroom Fixed JIRA PUSH-389 : Add support for subject, detail, and uri to the JavaScript API's notify function
        Files Changed
        Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/PushConfiguration.java
        Commit graph MODIFY /icepush/trunk/icepush/core/src/main/javascript/application.js
        Ken Fyten made changes -
        Fix Version/s EE-4.1.0.BETA [ 13073 ]
        Ken Fyten made changes -
        Fix Version/s EE-4.1.1.BETA [ 13077 ]
        Fix Version/s EE-4.1.0.GA [ 12172 ]
        Fix Version/s EE-4.1.0.RC1 [ 13073 ]
        Ken Fyten made changes -
        Fix Version/s EE-4.2.0.GA [ 13074 ]
        Fix Version/s EE-4.1.1.BETA [ 13077 ]

          People

          • Assignee:
            Jack Van Ooststroom
            Reporter:
            Jack Van Ooststroom
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: