Details
-
Type:
New Feature
-
Status: Resolved
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: EE-4.0.0.GA, 4.1
-
Fix Version/s: EE-4.2.0.GA
-
Component/s: JavaScript Client, Push Library
-
Labels:None
-
Environment:ICEpush JavaScript Bridge, ICEpush Core
Description
The server-side Java API already supports specifying a subject, detail and uri when issuing a request for a push through PushContext's push(groupName, pushConfiguration) and push(groupName, payload, pushConfiguration) methods. Similar support should be added to the JavaScript Bridge's notify function. This would also lead to changing the server-side's PushConfiguration's fromRequest(request) method.
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
Sending icepush/core/src/main/java/org/icepush/PushConfiguration.java
Sending icepush/core/src/main/javascript/application.js
Transmitting file data ..
Committed revision 48589.
Show
Jack Van Ooststroom
added a comment - Sending icepush/core/src/main/java/org/icepush/PushConfiguration.java
Sending icepush/core/src/main/javascript/application.js
Transmitting file data ..
Committed revision 48589.
I would parse them since these parameters are part of the API now.
Show
Mircea Toma
added a comment - I would parse them since these parameters are part of the API now.
As long as the requests option is being used to populate the notify.icepush request, the server-side's PushConfiguration does not seem to require any modification.
Show
Jack Van Ooststroom
added a comment - As long as the requests option is being used to populate the notify.icepush request, the server-side's PushConfiguration does not seem to require any modification.
For the uri the name targetURI must be used as per PUSH-388.
Show
Jack Van Ooststroom
added a comment - For the uri the name targetURI must be used as per PUSH-388 .
Also note that the uri must be named the same as in PUSH-388.
Show
Jack Van Ooststroom
added a comment - Also note that the uri must be named the same as in PUSH-388 .
Please note that if the subject is specified the uri must be mandatory.
Show
Jack Van Ooststroom
added a comment - Please note that if the subject is specified the uri must be mandatory.
The JavaScript Bridge's notify function parses the subject, detail and targetURI from the options parameter as they are part of the API now. On the server-side the PushConfiguration's fromRequest(...) method has been updated to add these to the attributeMap of the PushConfiguration for now. On the server-side they have a different treatment as the at, delay and duration for now.
Marking this one as FIXED.