ICEpush
  1. ICEpush
  2. PUSH-383

Support the old Notification Provider property names

          Details

          • Type: Improvement Improvement
          • Status: Resolved
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 4.1
          • Fix Version/s: EE-4.2.0.GA
          • Component/s: Push Library, Push Server
          • Labels:
            None
          • Environment:
            ICEpush

            Description

            The new Cloud Notification Service included in ICEpush as per PUSH-378 uses a new consistent scheme of property names. To make it easier for ICEpush/ICEfaces developers and on our existent documentation, it is likely better to allow for the old property names to be support and to take precedence over the new ones.

              Activity

              Ascending order - Click to sort in descending order
              Jack Van Ooststroom created issue -
              Jack Van Ooststroom made changes -
              Field Original Value New Value
              Assignee Jack Van Ooststroom [ jack.van.ooststroom ]
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              Sending cloud/src/main/java/org/icesoft/notify/cloud/core/AbstractNotificationProvider.java
              Sending cloud/src/main/java/org/icesoft/notify/cloud/core/CloudNotificationService.java
              Sending cloud/src/main/java/org/icesoft/notify/cloud/core/EmailNotificationProvider.java
              Sending cloud/src/main/java/org/icesoft/notify/cloud/core/LoggerNotificationProvider.java
              Transmitting file data ....
              Committed revision 48128.

              Sending cloud-ee/src/main/java/com/icesoft/notify/cloud/core/APNSNotificationProvider.java
              Sending cloud-ee/src/main/java/com/icesoft/notify/cloud/core/GCMNotificationProvider.java
              Sending cloud-ee/src/main/java/com/icesoft/notify/cloud/core/TwilioSMSNotificationProvider.java
              Transmitting file data ...
              Committed revision 44528.

              Sending core/src/main/java/org/icepush/LocalPushGroupManager.java
              Sending core/src/main/java/org/icepush/servlet/ICEpushServlet.java
              Transmitting file data ..
              Committed revision 48129.

              Show
              Jack Van Ooststroom added a comment - Sending cloud/src/main/java/org/icesoft/notify/cloud/core/AbstractNotificationProvider.java Sending cloud/src/main/java/org/icesoft/notify/cloud/core/CloudNotificationService.java Sending cloud/src/main/java/org/icesoft/notify/cloud/core/EmailNotificationProvider.java Sending cloud/src/main/java/org/icesoft/notify/cloud/core/LoggerNotificationProvider.java Transmitting file data .... Committed revision 48128. Sending cloud-ee/src/main/java/com/icesoft/notify/cloud/core/APNSNotificationProvider.java Sending cloud-ee/src/main/java/com/icesoft/notify/cloud/core/GCMNotificationProvider.java Sending cloud-ee/src/main/java/com/icesoft/notify/cloud/core/TwilioSMSNotificationProvider.java Transmitting file data ... Committed revision 44528. Sending core/src/main/java/org/icepush/LocalPushGroupManager.java Sending core/src/main/java/org/icepush/servlet/ICEpushServlet.java Transmitting file data .. Committed revision 48129.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #48128 Tue Feb 23 14:27:39 MST 2016 jack.van.ooststroom Fixed JIRA PUSH-383 : Support the old Notification Provider property names
              Files Changed
              Commit graph MODIFY /icenotify/trunk/icenotify/cloud/src/main/java/org/icesoft/notify/cloud/core/EmailNotificationProvider.java
              Commit graph MODIFY /icenotify/trunk/icenotify/cloud/src/main/java/org/icesoft/notify/cloud/core/AbstractNotificationProvider.java
              Commit graph MODIFY /icenotify/trunk/icenotify/cloud/src/main/java/org/icesoft/notify/cloud/core/CloudNotificationService.java
              Commit graph MODIFY /icenotify/trunk/icenotify/cloud/src/main/java/org/icesoft/notify/cloud/core/LoggerNotificationProvider.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #48129 Tue Feb 23 14:28:03 MST 2016 jack.van.ooststroom Fixed JIRA PUSH-383 : Support the old Notification Provider property names
              Files Changed
              Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/LocalPushGroupManager.java
              Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/servlet/ICEpushServlet.java
              Ken Fyten made changes -
              Fix Version/s EE-4.1.0.GA [ 12172 ]
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              Adding icepush-ee/core/src/main/java/org/icepush/AutoSystemConfigurator.java
              Adding icepush-ee/core/src/main/java/org/icepush/Configurator.java
              Adding icepush-ee/core/src/main/java/org/icepush/ExtendedConfigurator.java
              Sending icepush-ee/core/src/main/java/org/icepush/LocalPushGroupManager.java
              Adding icepush-ee/core/src/main/java/org/icepush/SystemConfigurator.java
              Sending icepush-ee/core/src/main/java/org/icepush/servlet/MainServlet.java
              Transmitting file data ......
              Committed revision 48135.

              Adding icepush-ee/core-ee/src/main/java/com/icesoft/icepush/SystemConfigurator.java
              Transmitting file data .
              Committed revision 44529.

              Show
              Jack Van Ooststroom added a comment - Adding icepush-ee/core/src/main/java/org/icepush/AutoSystemConfigurator.java Adding icepush-ee/core/src/main/java/org/icepush/Configurator.java Adding icepush-ee/core/src/main/java/org/icepush/ExtendedConfigurator.java Sending icepush-ee/core/src/main/java/org/icepush/LocalPushGroupManager.java Adding icepush-ee/core/src/main/java/org/icepush/SystemConfigurator.java Sending icepush-ee/core/src/main/java/org/icepush/servlet/MainServlet.java Transmitting file data ...... Committed revision 48135. Adding icepush-ee/core-ee/src/main/java/com/icesoft/icepush/SystemConfigurator.java Transmitting file data . Committed revision 44529.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #48135 Tue Feb 23 20:21:29 MST 2016 jack.van.ooststroom Fixed JIRA PUSH-383 : Support the old Notification Provider property names
              Files Changed
              Commit graph ADD /icepush/trunk/icepush/core/src/main/java/org/icepush/Configurator.java
              Commit graph ADD /icepush/trunk/icepush/core/src/main/java/org/icepush/SystemConfigurator.java
              Commit graph ADD /icepush/trunk/icepush/core/src/main/java/org/icepush/AutoSystemConfigurator.java
              Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/servlet/MainServlet.java
              Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/LocalPushGroupManager.java
              Commit graph ADD /icepush/trunk/icepush/core/src/main/java/org/icepush/ExtendedConfigurator.java
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              Adding icepush-ee/util/src/main/java/org/icesoft/util/NameValuePair.java
              Transmitting file data .
              Committed revision 48136.

              Sending icepush-ee/cloud/src/main/java/org/icesoft/notify/cloud/core/AbstractNotificationProvider.java
              Sending icepush-ee/cloud/src/main/java/org/icesoft/notify/cloud/core/EmailNotificationProvider.java
              Sending icepush-ee/cloud/src/main/java/org/icesoft/notify/cloud/core/LoggerNotificationProvider.java
              Transmitting file data ...
              Committed revision 48137.

              Sending icepush-ee/cloud-ee/src/main/java/com/icesoft/notify/cloud/core/APNSNotificationProvider.java
              Sending icepush-ee/cloud-ee/src/main/java/com/icesoft/notify/cloud/core/GCMNotificationProvider.java
              Sending icepush-ee/cloud-ee/src/main/java/com/icesoft/notify/cloud/core/TwilioSMSNotificationProvider.java
              Transmitting file data ...
              Committed revision 44533.

              Sending icepush-ee/core/src/main/java/org/icepush/SystemConfigurator.java
              Transmitting file data .
              Committed revision 48138.

              Sending icepush-ee/core-ee/src/main/java/com/icesoft/icepush/SystemConfigurator.java
              Transmitting file data .
              Committed revision 44534.

              Show
              Jack Van Ooststroom added a comment - Adding icepush-ee/util/src/main/java/org/icesoft/util/NameValuePair.java Transmitting file data . Committed revision 48136. Sending icepush-ee/cloud/src/main/java/org/icesoft/notify/cloud/core/AbstractNotificationProvider.java Sending icepush-ee/cloud/src/main/java/org/icesoft/notify/cloud/core/EmailNotificationProvider.java Sending icepush-ee/cloud/src/main/java/org/icesoft/notify/cloud/core/LoggerNotificationProvider.java Transmitting file data ... Committed revision 48137. Sending icepush-ee/cloud-ee/src/main/java/com/icesoft/notify/cloud/core/APNSNotificationProvider.java Sending icepush-ee/cloud-ee/src/main/java/com/icesoft/notify/cloud/core/GCMNotificationProvider.java Sending icepush-ee/cloud-ee/src/main/java/com/icesoft/notify/cloud/core/TwilioSMSNotificationProvider.java Transmitting file data ... Committed revision 44533. Sending icepush-ee/core/src/main/java/org/icepush/SystemConfigurator.java Transmitting file data . Committed revision 48138. Sending icepush-ee/core-ee/src/main/java/com/icesoft/icepush/SystemConfigurator.java Transmitting file data . Committed revision 44534.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #48136 Wed Feb 24 07:38:03 MST 2016 jack.van.ooststroom Fixed JIRA PUSH-383 : Support the old Notification Provider property names; Additional re-factor and logging if default value is used.
              Files Changed
              Commit graph ADD /iceutil/trunk/iceutil/util/src/main/java/org/icesoft/util/NameValuePair.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #48137 Wed Feb 24 07:38:17 MST 2016 jack.van.ooststroom Fixed JIRA PUSH-383 : Support the old Notification Provider property names; Additional re-factor and logging if default value is used.
              Files Changed
              Commit graph MODIFY /icenotify/trunk/icenotify/cloud/src/main/java/org/icesoft/notify/cloud/core/EmailNotificationProvider.java
              Commit graph MODIFY /icenotify/trunk/icenotify/cloud/src/main/java/org/icesoft/notify/cloud/core/AbstractNotificationProvider.java
              Commit graph MODIFY /icenotify/trunk/icenotify/cloud/src/main/java/org/icesoft/notify/cloud/core/LoggerNotificationProvider.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #48138 Wed Feb 24 07:38:40 MST 2016 jack.van.ooststroom Fixed JIRA PUSH-383 : Support the old Notification Provider property names; Additional re-factor and logging if default value is used.
              Files Changed
              Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/SystemConfigurator.java
              Hide
              Permalink
              Jack Van Ooststroom added a comment - - edited

              A couple of things have been included in the fix:

              • The NotificationProviders will look for alternative property names now first before using its own defined property names. (Though it is still recommended using the new property names as defined by each NotificationProvider.)
              • If there is now property value associated with the alternative property name the NotificationProviders will use their own defined property names and possibly their own defined property default values if no property value was associated with their own defined property name.
              • Logging indicates the property name found and used as well as the property value and if the property value used is the default.
              • ICEpush has an added @WebListener AutoSystemConfigurator which will use the AnnotationScanner to look for @ExtendedConfigurator annotated classes in order to perform the auto configuration before signalling the {{NotificationProvider}}s.
              • Both ICEpush and ICEpush-EE have an @ExtendedConfigurator annotated class that ensures the old property names are made known to the new Cloud Notification Service.

              Marking this one as FIXED.

              Show
              Jack Van Ooststroom added a comment - - edited A couple of things have been included in the fix: The NotificationProviders will look for alternative property names now first before using its own defined property names. (Though it is still recommended using the new property names as defined by each NotificationProvider .) If there is now property value associated with the alternative property name the NotificationProviders will use their own defined property names and possibly their own defined property default values if no property value was associated with their own defined property name. Logging indicates the property name found and used as well as the property value and if the property value used is the default. ICEpush has an added @WebListener AutoSystemConfigurator which will use the AnnotationScanner to look for @ExtendedConfigurator annotated classes in order to perform the auto configuration before signalling the {{NotificationProvider}}s. Both ICEpush and ICEpush-EE have an @ExtendedConfigurator annotated class that ensures the old property names are made known to the new Cloud Notification Service. Marking this one as FIXED.
              Jack Van Ooststroom made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s EE-4.1.0.BETA [ 13073 ]
              Ken Fyten made changes -
              Fix Version/s EE-4.1.1.BETA [ 13077 ]
              Fix Version/s EE-4.1.0.GA [ 12172 ]
              Fix Version/s EE-4.1.0.RC1 [ 13073 ]
              Ken Fyten made changes -
              Fix Version/s EE-4.2.0.GA [ 13074 ]
              Fix Version/s EE-4.1.1.BETA [ 13077 ]

                People

                • Assignee:
                  Jack Van Ooststroom
                  Reporter:
                  Jack Van Ooststroom
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: