ICEpush
  1. ICEpush
  2. PUSH-357

ICEfaces src bundle does not build on machine using Java 8

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-4.0.0.GA
          • Fix Version/s: 4.1
          • Component/s: None
          • Labels:
            None
          • Environment:

            Description

            Downloaded the EE-4.0.0.GA-src bundle from icefaces.org. Attempted to build using the default ant target. 28 seconds later the build fails:
              [javadoc] Standard Doclet version 1.8.0_05
              [javadoc] Building tree for all the packages and classes...
              [javadoc] C:\svn\ossrepo\ICEfaces-EE-4.0.0.GA-src\icepush-ee\core\src\main\jav
            a\org\icepush\PushConfiguration.java:44: error: type arguments not allowed here
              [javadoc] * @see #PushConfiguration(Map<String, Object>)
              [javadoc] ^
              [javadoc] C:\svn\ossrepo\ICEfaces-EE-4.0.0.GA-src\icepush-ee\core\src\main\jav
            a\org\icepush\PushConfiguration.java:46: warning - Tag @see:illegal character: "
            60" in "#PushConfiguration(Map<String, Object>)"
              [javadoc] C:\svn\ossrepo\ICEfaces-EE-4.0.0.GA-src\icepush-ee\core\src\main\jav
            a\org\icepush\PushConfiguration.java:46: warning - Tag @see:illegal character: "
            62" in "#PushConfiguration(Map<String, Object>)"
              [javadoc] C:\svn\ossrepo\ICEfaces-EE-4.0.0.GA-src\icepush-ee\core\src\main\jav
            a\org\icepush\PushConfiguration.java:46: warning - Tag @see: can't find PushConf
            iguration(Map<String, Object>) in org.icepush.PushConfiguration
              [javadoc] Building index for all the packages and classes...
              [javadoc] Building index for all classes...
              [javadoc] Generating C:\svn\ossrepo\ICEfaces-EE-4.0.0.GA-src\icepush-ee\core\b
            uild\javadocs\help-doc.html...
              [javadoc] 1 error
              [javadoc] 3 warnings
            BUILD FAILED
            C:\svn\ossrepo\ICEfaces-EE-4.0.0.GA-src\build.xml:158: The following error occurred while executing this line:
            C:\svn\ossrepo\ICEfaces-EE-4.0.0.GA-src\build.xml:268: The following error occur
            red while executing this line:
            C:\svn\ossrepo\ICEfaces-EE-4.0.0.GA-src\icepush-ee\build.xml:24: The following error occurred while executing this line:
            C:\svn\ossrepo\ICEfaces-EE-4.0.0.GA-src\icepush-ee\build.xml:51: The following error occurred while executing this line:
            C:\svn\ossrepo\ICEfaces-EE-4.0.0.GA-src\icepush-ee\core\build.xml:92: Javadoc returned 1
            Total time: 28 seconds

            Removing the javadoc from the file allowed ICEfaces to build successfully.
            Not an issue in Java 7 environments.
            The release src bundle was not tested with java 8 since the creation of the EE-4.0.0 tag.

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Deryk Sinotte added a comment -

              Looks like this JavaDoc check is something that has been added relatively recently which explains why we didn't see it until Java 8:

              http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/3ae62331a56f

              Show
              Deryk Sinotte added a comment - Looks like this JavaDoc check is something that has been added relatively recently which explains why we didn't see it until Java 8: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/3ae62331a56f
              Hide
              Permalink
              Deryk Sinotte added a comment -

              I tried the same test (download src bundle, run Ant target) using an earlier Doclet version and it produces warnings, but not failures:

              javadoc:
     [echo] lib.dir: '../lib'
  [javadoc] Generating Javadoc
  [javadoc] Javadoc execution
  [javadoc] Creating destination directory: "/Users/deryk/Downloads/ICEfaces-EE-4.0.0.GA-src/icepush-ee/core/build/javadocs/"
  [javadoc] Loading source file /Users/deryk/Downloads/ICEfaces-EE-4.0.0.GA-src/icepush-ee/core/src/main/java/org/icepush/PushConfiguration.java...
  [javadoc] Loading source file /Users/deryk/Downloads/ICEfaces-EE-4.0.0.GA-src/icepush-ee/core/src/main/java/org/icepush/PushContext.java...
  [javadoc] Loading source file /Users/deryk/Downloads/ICEfaces-EE-4.0.0.GA-src/icepush-ee/core/src/main/java/org/icepush/PushNotification.java...
  [javadoc] Constructing Javadoc information...
  [javadoc] Standard Doclet version 1.6.0_65
  [javadoc] /Users/deryk/Downloads/ICEfaces-EE-4.0.0.GA-src/icepush-ee/core/src/main/java/org/icepush/PushConfiguration.java:46: warning - Tag @see:illegal character: "60" in "#PushConfiguration(Map<String, Object>)"
  [javadoc] Building tree for all the packages and classes...
  [javadoc] /Users/deryk/Downloads/ICEfaces-EE-4.0.0.GA-src/icepush-ee/core/src/main/java/org/icepush/PushConfiguration.java:46: warning - Tag @see:illegal character: "62" in "#PushConfiguration(Map<String, Object>)"
  [javadoc] /Users/deryk/Downloads/ICEfaces-EE-4.0.0.GA-src/icepush-ee/core/src/main/java/org/icepush/PushConfiguration.java:46: warning - Tag @see: can't find PushConfiguration(Map<String, Object>) in org.icepush.PushConfiguration

              So it seems that they've made the checking of generic types in the documentation stricter than previous versions (error instead of warning). However the fix is simple enough, just remove the type information for the Map:

                   * @see        #PushConfiguration(Map<String, Object>)

              should be

                   * @see        #PushConfiguration(Map)
              Show
              Deryk Sinotte added a comment - I tried the same test (download src bundle, run Ant target) using an earlier Doclet version and it produces warnings, but not failures: javadoc: [echo] lib.dir: '../lib' [javadoc] Generating Javadoc [javadoc] Javadoc execution [javadoc] Creating destination directory: "/Users/deryk/Downloads/ICEfaces-EE-4.0.0.GA-src/icepush-ee/core/build/javadocs/" [javadoc] Loading source file /Users/deryk/Downloads/ICEfaces-EE-4.0.0.GA-src/icepush-ee/core/src/main/java/org/icepush/PushConfiguration.java... [javadoc] Loading source file /Users/deryk/Downloads/ICEfaces-EE-4.0.0.GA-src/icepush-ee/core/src/main/java/org/icepush/PushContext.java... [javadoc] Loading source file /Users/deryk/Downloads/ICEfaces-EE-4.0.0.GA-src/icepush-ee/core/src/main/java/org/icepush/PushNotification.java... [javadoc] Constructing Javadoc information... [javadoc] Standard Doclet version 1.6.0_65 [javadoc] /Users/deryk/Downloads/ICEfaces-EE-4.0.0.GA-src/icepush-ee/core/src/main/java/org/icepush/PushConfiguration.java:46: warning - Tag @see:illegal character: "60" in "#PushConfiguration(Map<String, Object>)" [javadoc] Building tree for all the packages and classes... [javadoc] /Users/deryk/Downloads/ICEfaces-EE-4.0.0.GA-src/icepush-ee/core/src/main/java/org/icepush/PushConfiguration.java:46: warning - Tag @see:illegal character: "62" in "#PushConfiguration(Map<String, Object>)" [javadoc] /Users/deryk/Downloads/ICEfaces-EE-4.0.0.GA-src/icepush-ee/core/src/main/java/org/icepush/PushConfiguration.java:46: warning - Tag @see: can't find PushConfiguration(Map<String, Object>) in org.icepush.PushConfiguration So it seems that they've made the checking of generic types in the documentation stricter than previous versions (error instead of warning). However the fix is simple enough, just remove the type information for the Map: * @see #PushConfiguration(Map< String , Object >) should be * @see #PushConfiguration(Map)
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              Sending icepush-ee/core/src/main/java/org/icepush/PushConfiguration.java
              Transmitting file data .
              Committed revision 44427.

              Show
              Jack Van Ooststroom added a comment - Sending icepush-ee/core/src/main/java/org/icepush/PushConfiguration.java Transmitting file data . Committed revision 44427.
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              The PushConfiguration has been updated as suggested. Marking this one as FIXED.

              Show
              Jack Van Ooststroom added a comment - The PushConfiguration has been updated as suggested. Marking this one as FIXED.
              Hide
              Permalink
              Liana Munroe added a comment -

              Verified using the src at http://dev.icesoft.com/svn/repo/icefaces-ee4/trunk/icefaces-ee, java version 1.8.0_31, ant 1.9.1. The icefaces.org download page must be updated with the new src bundle.

              Show
              Liana Munroe added a comment - Verified using the src at http://dev.icesoft.com/svn/repo/icefaces-ee4/trunk/icefaces-ee , java version 1.8.0_31, ant 1.9.1. The icefaces.org download page must be updated with the new src bundle.

                People

                • Assignee:
                  Jack Van Ooststroom
                  Reporter:
                  Liana Munroe
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: