[PUSH-357] ICEfaces src bundle does not build on machine using Java 8 - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: EE-4.0.0.GA
Fix Version/s: 4.1
Component/s: None
Labels:
None
Environment:

Hide
Windows 8 machine with java version 1.8.0_31, 1.8.0_40, ant 1.9.4, 1.9.1 or ant 1.7.1.
ICEfaces EE-4.0.0. source bundle downloaded from icefaces.org and the repo at http://dev.icesoft.com/svn/repo/icefaces-ee4/trunk/icefaces-ee. Not an issue with ICEfaces 4 trunk

Show
Windows 8 machine with java version 1.8.0_31, 1.8.0_40, ant 1.9.4, 1.9.1 or ant 1.7.1. ICEfaces EE-4.0.0. source bundle downloaded from icefaces.org and the repo at http://dev.icesoft.com/svn/repo/icefaces-ee4/trunk/icefaces-ee . Not an issue with ICEfaces 4 trunk

Description

Downloaded the EE-4.0.0.GA-src bundle from icefaces.org. Attempted to build using the default ant target. 28 seconds later the build fails:
  [javadoc] Standard Doclet version 1.8.0_05
  [javadoc] Building tree for all the packages and classes...
  [javadoc] C:\svn\ossrepo\ICEfaces-EE-4.0.0.GA-src\icepush-ee\core\src\main\jav
a\org\icepush\PushConfiguration.java:44: error: type arguments not allowed here
  [javadoc] * @see #PushConfiguration(Map<String, Object>)
  [javadoc] ^
  [javadoc] C:\svn\ossrepo\ICEfaces-EE-4.0.0.GA-src\icepush-ee\core\src\main\jav
a\org\icepush\PushConfiguration.java:46: warning - Tag @see:illegal character: "
60" in "#PushConfiguration(Map<String, Object>)"
  [javadoc] C:\svn\ossrepo\ICEfaces-EE-4.0.0.GA-src\icepush-ee\core\src\main\jav
a\org\icepush\PushConfiguration.java:46: warning - Tag @see:illegal character: "
62" in "#PushConfiguration(Map<String, Object>)"
  [javadoc] C:\svn\ossrepo\ICEfaces-EE-4.0.0.GA-src\icepush-ee\core\src\main\jav
a\org\icepush\PushConfiguration.java:46: warning - Tag @see: can't find PushConf
iguration(Map<String, Object>) in org.icepush.PushConfiguration
  [javadoc] Building index for all the packages and classes...
  [javadoc] Building index for all classes...
  [javadoc] Generating C:\svn\ossrepo\ICEfaces-EE-4.0.0.GA-src\icepush-ee\core\b
uild\javadocs\help-doc.html...
  [javadoc] 1 error
  [javadoc] 3 warnings
BUILD FAILED
C:\svn\ossrepo\ICEfaces-EE-4.0.0.GA-src\build.xml:158: The following error occurred while executing this line:
C:\svn\ossrepo\ICEfaces-EE-4.0.0.GA-src\build.xml:268: The following error occur
red while executing this line:
C:\svn\ossrepo\ICEfaces-EE-4.0.0.GA-src\icepush-ee\build.xml:24: The following error occurred while executing this line:
C:\svn\ossrepo\ICEfaces-EE-4.0.0.GA-src\icepush-ee\build.xml:51: The following error occurred while executing this line:
C:\svn\ossrepo\ICEfaces-EE-4.0.0.GA-src\icepush-ee\core\build.xml:92: Javadoc returned 1
Total time: 28 seconds

Removing the javadoc from the file allowed ICEfaces to build successfully.
Not an issue in Java 7 environments.
The release src bundle was not tested with java 8 since the creation of the EE-4.0.0 tag.

Activity

Ascending order - Click to sort in descending order

Liana Munroe created issue - 06/Apr/15 2:44 PM

Liana Munroe made changes - 06/Apr/15 2:44 PM

Field	Original Value	New Value
Assignee		Deryk Sinotte [ deryk.sinotte ]

Liana Munroe made changes - 06/Apr/15 2:46 PM

Description

Downloaded the EE-4.0.0.GA-src bundle from icefaces.org. Attempted to build using the default ant target. 28 seconds later the build fails:
BUILD FAILED
C:\svn\ossrepo\ICEfaces-EE-4.0.0.GA-src\build.xml:158: The following error occurred while executing this line:
C:\svn\ossrepo\ICEfaces-EE-4.0.0.GA-src\build.xml:268: The following error occur
red while executing this line:
C:\svn\ossrepo\ICEfaces-EE-4.0.0.GA-src\icepush-ee\build.xml:24: The following error occurred while executing this line:
C:\svn\ossrepo\ICEfaces-EE-4.0.0.GA-src\icepush-ee\build.xml:51: The following error occurred while executing this line:
C:\svn\ossrepo\ICEfaces-EE-4.0.0.GA-src\icepush-ee\core\build.xml:92: Javadoc returned 1
Total time: 28 seconds

Removing the javadoc from the file allowed ICEfaces to build successfully.
Not an issue in Java 7 environments.
The release src bundle was not tested with java 8 since the creation of the EE-4.0.0 tag.

Deryk Sinotte made changes - 06/Apr/15 2:54 PM

Assignee

Deryk Sinotte [ deryk.sinotte ]

Ken Fyten [ ken.fyten ]

Liana Munroe made changes - 06/Apr/15 3:02 PM

Environment

Windows 8 machine with java version 1.8.0_31, 1.8.0_40, ant 1.9.4, 1.9.1 or ant 1.7.1.
ICEfaces EE-4.0.0. source bundle downloaded from icefaces.org

Windows 8 machine with java version 1.8.0_31, 1.8.0_40, ant 1.9.4, 1.9.1 or ant 1.7.1.
ICEfaces EE-4.0.0. source bundle downloaded from icefaces.org and the repo at http://dev.icesoft.com/svn/repo/icefaces-ee4/trunk/icefaces-ee

Liana Munroe made changes - 06/Apr/15 3:06 PM

Environment

Hide

Permalink

Deryk Sinotte added a comment - 06/Apr/15 3:07 PM

Looks like this JavaDoc check is something that has been added relatively recently which explains why we didn't see it until Java 8:

http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/3ae62331a56f

Show

Deryk Sinotte added a comment - 06/Apr/15 3:07 PM Looks like this JavaDoc check is something that has been added relatively recently which explains why we didn't see it until Java 8: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/3ae62331a56f

Deryk Sinotte made changes - 06/Apr/15 3:35 PM

Assignee

Ken Fyten [ ken.fyten ]

Jack Van Ooststroom [ jack.van.ooststroom ]

Hide

Permalink

Deryk Sinotte added a comment - 06/Apr/15 3:36 PM

I tried the same test (download src bundle, run Ant target) using an earlier Doclet version and it produces warnings, but not failures:

javadoc:
     [echo] lib.dir: '../lib'
  [javadoc] Generating Javadoc
  [javadoc] Javadoc execution
  [javadoc] Creating destination directory: "/Users/deryk/Downloads/ICEfaces-EE-4.0.0.GA-src/icepush-ee/core/build/javadocs/"
  [javadoc] Loading source file /Users/deryk/Downloads/ICEfaces-EE-4.0.0.GA-src/icepush-ee/core/src/main/java/org/icepush/PushConfiguration.java...
  [javadoc] Loading source file /Users/deryk/Downloads/ICEfaces-EE-4.0.0.GA-src/icepush-ee/core/src/main/java/org/icepush/PushContext.java...
  [javadoc] Loading source file /Users/deryk/Downloads/ICEfaces-EE-4.0.0.GA-src/icepush-ee/core/src/main/java/org/icepush/PushNotification.java...
  [javadoc] Constructing Javadoc information...
  [javadoc] Standard Doclet version 1.6.0_65
  [javadoc] /Users/deryk/Downloads/ICEfaces-EE-4.0.0.GA-src/icepush-ee/core/src/main/java/org/icepush/PushConfiguration.java:46: warning - Tag @see:illegal character: "60" in "#PushConfiguration(Map<String, Object>)"
  [javadoc] Building tree for all the packages and classes...
  [javadoc] /Users/deryk/Downloads/ICEfaces-EE-4.0.0.GA-src/icepush-ee/core/src/main/java/org/icepush/PushConfiguration.java:46: warning - Tag @see:illegal character: "62" in "#PushConfiguration(Map<String, Object>)"
  [javadoc] /Users/deryk/Downloads/ICEfaces-EE-4.0.0.GA-src/icepush-ee/core/src/main/java/org/icepush/PushConfiguration.java:46: warning - Tag @see: can't find PushConfiguration(Map<String, Object>) in org.icepush.PushConfiguration

So it seems that they've made the checking of generic types in the documentation stricter than previous versions (error instead of warning). However the fix is simple enough, just remove the type information for the Map:

     * @see        #PushConfiguration(Map<String, Object>)

should be

     * @see        #PushConfiguration(Map)

Show

Deryk Sinotte added a comment - 06/Apr/15 3:36 PM I tried the same test (download src bundle, run Ant target) using an earlier Doclet version and it produces warnings, but not failures: javadoc: [echo] lib.dir: '../lib' [javadoc] Generating Javadoc [javadoc] Javadoc execution [javadoc] Creating destination directory: "/Users/deryk/Downloads/ICEfaces-EE-4.0.0.GA-src/icepush-ee/core/build/javadocs/" [javadoc] Loading source file /Users/deryk/Downloads/ICEfaces-EE-4.0.0.GA-src/icepush-ee/core/src/main/java/org/icepush/PushConfiguration.java... [javadoc] Loading source file /Users/deryk/Downloads/ICEfaces-EE-4.0.0.GA-src/icepush-ee/core/src/main/java/org/icepush/PushContext.java... [javadoc] Loading source file /Users/deryk/Downloads/ICEfaces-EE-4.0.0.GA-src/icepush-ee/core/src/main/java/org/icepush/PushNotification.java... [javadoc] Constructing Javadoc information... [javadoc] Standard Doclet version 1.6.0_65 [javadoc] /Users/deryk/Downloads/ICEfaces-EE-4.0.0.GA-src/icepush-ee/core/src/main/java/org/icepush/PushConfiguration.java:46: warning - Tag @see:illegal character: "60" in "#PushConfiguration(Map<String, Object>)" [javadoc] Building tree for all the packages and classes... [javadoc] /Users/deryk/Downloads/ICEfaces-EE-4.0.0.GA-src/icepush-ee/core/src/main/java/org/icepush/PushConfiguration.java:46: warning - Tag @see:illegal character: "62" in "#PushConfiguration(Map<String, Object>)" [javadoc] /Users/deryk/Downloads/ICEfaces-EE-4.0.0.GA-src/icepush-ee/core/src/main/java/org/icepush/PushConfiguration.java:46: warning - Tag @see: can't find PushConfiguration(Map<String, Object>) in org.icepush.PushConfiguration So it seems that they've made the checking of generic types in the documentation stricter than previous versions (error instead of warning). However the fix is simple enough, just remove the type information for the Map: * @see #PushConfiguration(Map< String , Object >) should be * @see #PushConfiguration(Map)

Jack Van Ooststroom made changes - 06/Apr/15 5:42 PM

Fix Version/s

EE-4.1.0.GA [ 12171 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#44427	Tue Apr 07 07:27:06 MDT 2015	jack.van.ooststroom	Fixed JIRA ~~PUSH-357~~ : ICEfaces src bundle does not build on machine using Java 8
				Files Changed
				MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/PushConfiguration.java

Jack Van Ooststroom made changes - 07/Apr/15 7:33 AM

Project	ICEfaces [ 10021 ]	ICEpush [ 10050 ]
Key	~~ICE-10618~~	~~PUSH-357~~
Affects Version/s		EE-4.0.0.GA [ 11170 ]
Affects Version/s	EE-4.0.0.GA [ 11171 ]
Fix Version/s		EE-4.1.0.GA [ 12172 ]
Fix Version/s	EE-4.1.0.GA [ 12171 ]

Hide

Permalink

Jack Van Ooststroom added a comment - 07/Apr/15 7:34 AM

Sending icepush-ee/core/src/main/java/org/icepush/PushConfiguration.java
Transmitting file data .
Committed revision 44427.

Show

Jack Van Ooststroom added a comment - 07/Apr/15 7:34 AM Sending icepush-ee/core/src/main/java/org/icepush/PushConfiguration.java Transmitting file data . Committed revision 44427.

Hide

Permalink

Jack Van Ooststroom added a comment - 07/Apr/15 7:35 AM

The PushConfiguration has been updated as suggested. Marking this one as FIXED.

Show

Jack Van Ooststroom added a comment - 07/Apr/15 7:35 AM The PushConfiguration has been updated as suggested. Marking this one as FIXED.

Jack Van Ooststroom made changes - 07/Apr/15 7:35 AM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Hide

Permalink

Liana Munroe added a comment - 07/Apr/15 10:21 AM

Verified using the src at http://dev.icesoft.com/svn/repo/icefaces-ee4/trunk/icefaces-ee, java version 1.8.0_31, ant 1.9.1. The icefaces.org download page must be updated with the new src bundle.

Show

Liana Munroe added a comment - 07/Apr/15 10:21 AM Verified using the src at http://dev.icesoft.com/svn/repo/icefaces-ee4/trunk/icefaces-ee , java version 1.8.0_31, ant 1.9.1. The icefaces.org download page must be updated with the new src bundle.

Ken Fyten made changes - 14/Apr/15 3:08 PM

Fix Version/s		4.1 [ 11570 ]
Fix Version/s	EE-4.1.0.GA [ 12172 ]

Ken Fyten made changes - 14/Apr/15 3:08 PM

Security

Private [ 10001 ]

Ken Fyten made changes - 13/Mar/17 1:32 PM

Status

Resolved [ 5 ]

Closed [ 6 ]

People

Assignee:

Jack Van Ooststroom

Reporter:

Liana Munroe

Votes:

0 Vote for this issue

Watchers:

3 Start watching this issue

Dates

Created:

06/Apr/15 2:44 PM

Updated:

13/Mar/17 1:32 PM

Resolved:

07/Apr/15 7:35 AM