ICEpush
  1. ICEpush
  2. PUSH-351

JBoss EAP 6.3.0 uses Objects in JMS property values which causes a PropertyException

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-3.3.0.GA_P02, EE-4.0.0.GA
    • Fix Version/s: EE-4.0.0.GA, EE-3.3.0.GA_P03
    • Component/s: Push Server
    • Labels:
      None
    • Environment:
      JBoss EAP 6.3.0 Cluster, ICEfaces-EE, EPS, Poll

      Description

      Our Properties.PropertyValidator throws a PropertyException when encountering an Object in JMS property values. The property in question here originates from JBoss EAP 6.3.0 itself.

        Activity

        Hide
        Jack Van Ooststroom added a comment -

        Sending src/main/java/com/icesoft/net/messaging/AbstractMessage.java
        Transmitting file data .
        Committed revision 41285.

        Show
        Jack Van Ooststroom added a comment - Sending src/main/java/com/icesoft/net/messaging/AbstractMessage.java Transmitting file data . Committed revision 41285.
        Hide
        Jack Van Ooststroom added a comment - - edited

        As the ServletContext is getting passed down the chain due to PUSH-350 to allow for ServerUtility.isJBoss7(ServletContext) checking, dependent on the outcome the Objects are allowed when in a JBoss AS 7 environment, which includes JBoss EAP 6.3.0.

        Despite the Java Message Service specification saying that these characters are not allowed as a property value:

        JMS 1.1:

        "3.5.2 Property Values
        Property values can be boolean, byte, short, int, long, float, double, and String."

        JMS 2.0:

        "3.5.2. Property values
        Property values can be boolean, byte, short, int, long, float, double, and String."

        Sources:

        As ICEpush-EE has an abstracted layer for dealing with messages it enforces these rules outside of the Message Broker. For now the exception for JBoss AS 7 has been added. Marking this one as FIXED.

        Show
        Jack Van Ooststroom added a comment - - edited As the ServletContext is getting passed down the chain due to PUSH-350 to allow for ServerUtility.isJBoss7(ServletContext) checking, dependent on the outcome the Objects are allowed when in a JBoss AS 7 environment, which includes JBoss EAP 6.3.0. Despite the Java Message Service specification saying that these characters are not allowed as a property value: JMS 1.1: "3.5.2 Property Values Property values can be boolean, byte, short, int, long, float, double, and String." JMS 2.0: "3.5.2. Property values Property values can be boolean, byte, short, int, long, float, double, and String." Sources: http://download.oracle.com/otndocs/jcp/7195-jms-1.1-fr-spec-oth-JSpec/ http://download.oracle.com/otndocs/jcp/jms-2_0-fr-spec/index.html As ICEpush-EE has an abstracted layer for dealing with messages it enforces these rules outside of the Message Broker. For now the exception for JBoss AS 7 has been added. Marking this one as FIXED.
        Hide
        Jack Van Ooststroom added a comment -

        Sending eps/src/main/java/com/icesoft/net/messaging/AbstractMessage.java
        Transmitting file data .
        Committed revision 41482.

        Show
        Jack Van Ooststroom added a comment - Sending eps/src/main/java/com/icesoft/net/messaging/AbstractMessage.java Transmitting file data . Committed revision 41482.
        Hide
        Jack Van Ooststroom added a comment -

        Backported the fix to EE-3 as well.

        Show
        Jack Van Ooststroom added a comment - Backported the fix to EE-3 as well.
        Hide
        Jack Van Ooststroom added a comment -

        ICEfaces-EE 3.3.x confirmed on JBoss EAP 6.3.0 cluster.

        Show
        Jack Van Ooststroom added a comment - ICEfaces-EE 3.3.x confirmed on JBoss EAP 6.3.0 cluster.

          People

          • Assignee:
            Jack Van Ooststroom
            Reporter:
            Jack Van Ooststroom
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: