ICEpush
  1. ICEpush
  2. PUSH-328

An NPE can occur between addMember and push calls due to BrowserID being null on a freshly created PushID

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0.BETA
    • Fix Version/s: 4.0
    • Component/s: Push Library
    • Labels:
      None
    • Environment:
      ICEpush, .icepush and REST APIs

      Description

      There seems to be a window between addMember(...) and push(...) method calls where a freshly created PushID object does not yet have an associated BrowserID object due to the listen request not being received yet between these calls. This causes an NPE to occur.

        Activity

        Hide
        Jack Van Ooststroom added a comment - - edited

        Sending core/src/main/java/org/icepush/LocalPushGroupManager.java
        Transmitting file data .
        Committed revision 41537.

        Sending eps/src/main/java/com/icesoft/push/LocalPushGroupManager.java
        Transmitting file data .
        Committed revision 38760.

        Sending src/main/java/com/icesoft/notify/push/BlockingConnectionServer.java
        Sending src/main/java/com/icesoft/notify/push/Browser.java
        Sending src/main/java/com/icesoft/notify/push/LocalPushGroupManager.java
        Transmitting file data ...
        Committed revision 38762.

        Show
        Jack Van Ooststroom added a comment - - edited Sending core/src/main/java/org/icepush/LocalPushGroupManager.java Transmitting file data . Committed revision 41537. Sending eps/src/main/java/com/icesoft/push/LocalPushGroupManager.java Transmitting file data . Committed revision 38760. Sending src/main/java/com/icesoft/notify/push/BlockingConnectionServer.java Sending src/main/java/com/icesoft/notify/push/Browser.java Sending src/main/java/com/icesoft/notify/push/LocalPushGroupManager.java Transmitting file data ... Committed revision 38762.
        Hide
        Jack Van Ooststroom added a comment -

        Looks like the addMember(...) method of the LocalPushGroupManager should also be able to instantiate a BrowserID. Added newBrowser(...) method hierarchy to the LocalPushGroupManager classes. The addMember(...) method utilizes the newly methods from PUSH-327 for the timely creation of BrowserID and the timely addition of both PushID and BrowserID to their respective collections. Marking this one as FIXED.

        Show
        Jack Van Ooststroom added a comment - Looks like the addMember(...) method of the LocalPushGroupManager should also be able to instantiate a BrowserID. Added newBrowser(...) method hierarchy to the LocalPushGroupManager classes. The addMember(...) method utilizes the newly methods from PUSH-327 for the timely creation of BrowserID and the timely addition of both PushID and BrowserID to their respective collections. Marking this one as FIXED.

          People

          • Assignee:
            Jack Van Ooststroom
            Reporter:
            Jack Van Ooststroom
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: