Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 4.0.BETA
-
Fix Version/s: 4.0
-
Component/s: JavaScript Client
-
Labels:None
-
Environment:ICEpush, nginx
-
Workaround Exists:Yes
-
Workaround Description:
Description
ICEpush makes use of a number of HTTP headers. These values should be passed as parameters in the body of the HTTP request:
ice.push.heartbeatTimestamp: 1401307088848
ice.notifyBack: apns:f7353
ice.push.browser: 1hvr1j5ar
ice.push.sequence: 130
ice.parkids: true
ice.push.window: fe4f7
(In some cases these are passed as body parameters, but the use of headers should be avoided.)
ice.push.heartbeatTimestamp: 1401307088848
ice.notifyBack: apns:f7353
ice.push.browser: 1hvr1j5ar
ice.push.sequence: 130
ice.parkids: true
ice.push.window: fe4f7
(In some cases these are passed as body parameters, but the use of headers should be avoided.)
Activity
| Field | Original Value | New Value |
|---|---|---|
| Assignee | Mircea Toma [ mircea.toma ] |
| Workaround Description |
Use
proxy_pass_request_headers on; http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_pass_request_headers http://stackoverflow.com/questions/19751313/forward-request-headers-from-nginx-proxy-server Example configuration for nginx: location / { proxy_pass http://mysite.com; proxy_set_header Host http://mysite.com; proxy_set_header HTTP_Country-Code $geoip_country_code; proxy_pass_request_headers on; } |
|
| Workaround Exists | Yes [ 10007 ] |
| Fix Version/s | 4.0.BETA [ 10971 ] |
| Workaround Description |
Use
proxy_pass_request_headers on; http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_pass_request_headers http://stackoverflow.com/questions/19751313/forward-request-headers-from-nginx-proxy-server Example configuration for nginx: location / { proxy_pass http://mysite.com; proxy_set_header Host http://mysite.com; proxy_set_header HTTP_Country-Code $geoip_country_code; proxy_pass_request_headers on; } |
Use in the http section:
ignore_invalid_headers off; http://wiki.nginx.org/HttpCoreModule#ignore_invalid_headers proxy_pass_request_headers on; http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_pass_request_headers http://stackoverflow.com/questions/19751313/forward-request-headers-from-nginx-proxy-server Example configuration for nginx: location / { proxy_pass http://mysite.com; proxy_set_header Host http://mysite.com; proxy_set_header HTTP_Country-Code $geoip_country_code; proxy_pass_request_headers on; } |
| Fix Version/s | 4.0 [ 11383 ] | |
| Fix Version/s | 4.0.BETA [ 10971 ] |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #41327 | Wed Jun 11 15:19:51 MDT 2014 | mircea.toma | |
| Files Changed | ||||
MODIFY
/icepush/trunk/icepush/core/src/main/java/org/icepush/Browser.java
MODIFY
/icepush/trunk/icepush/core/src/main/java/org/icepush/servlet/ServletPushRequest.java
MODIFY
/icepush/trunk/icepush/core/src/main/javascript/application.js
MODIFY
/icepush/trunk/icepush/core/src/main/javascript/connection.async.js
|
Modified bridge and server side servlets to use request parameters instead of request headers.
Show
Mircea Toma
added a comment - Modified bridge and server side servlets to use request parameters instead of request headers.
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
Additional configuration for nginx was required since it rejects the "invalid" . separator in the ICEpush headers. This can be addressed by adding as described in the workaround.
ignore_invalid_headers off;
According to RFC 2068 an HTTP header name is a "token" http://tools.ietf.org/html/rfc2068
token = 1*<any CHAR except CTLs or tspecials>
tspecials = "(" | ")" | "<" | ">" | "@"
"
which allows the "." character, but it is apparently uncommon enough to be rejected by nginx.