[PUSH-317] Use request parameters for ICEpush - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 4.0.BETA
Fix Version/s: 4.0
Component/s: JavaScript Client
Labels:
None
Environment:
ICEpush, nginx

Workaround Exists:

Yes
Workaround Description:

Hide
Use in the http section:

    ignore_invalid_headers off;

http://wiki.nginx.org/HttpCoreModule#ignore_invalid_headers

    proxy_pass_request_headers on;

http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_pass_request_headers

http://stackoverflow.com/questions/19751313/forward-request-headers-from-nginx-proxy-server

Example configuration for nginx:

location / {
    proxy_pass http://mysite.com;
    proxy_set_header Host http://mysite.com;
    proxy_set_header HTTP_Country-Code $geoip_country_code;
    proxy_pass_request_headers on;
}

Show
Use in the http section:     ignore_invalid_headers off; http://wiki.nginx.org/HttpCoreModule#ignore_invalid_headers     proxy_pass_request_headers on; http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_pass_request_headers http://stackoverflow.com/questions/19751313/forward-request-headers-from-nginx-proxy-server Example configuration for nginx: location / {     proxy_pass http://mysite.com;     proxy_set_header Host http://mysite.com;     proxy_set_header HTTP_Country-Code $geoip_country_code;     proxy_pass_request_headers on; }

Description

ICEpush makes use of a number of HTTP headers. These values should be passed as parameters in the body of the HTTP request:

ice.push.heartbeatTimestamp: 1401307088848
ice.notifyBack: apns:f7353
ice.push.browser: 1hvr1j5ar
ice.push.sequence: 130
ice.parkids: true
ice.push.window: fe4f7

(In some cases these are passed as body parameters, but the use of headers should be avoided.)

Activity

Descending order - Click to sort in ascending order

Hide

Permalink

Mircea Toma added a comment - 11/Jun/14 3:22 PM

Modified bridge and server side servlets to use request parameters instead of request headers.

Show

Mircea Toma added a comment - 11/Jun/14 3:22 PM Modified bridge and server side servlets to use request parameters instead of request headers.

Hide

Permalink

Ted Goddard added a comment - 05/Jun/14 11:57 AM

Additional configuration for nginx was required since it rejects the "invalid" . separator in the ICEpush headers. This can be addressed by adding as described in the workaround.

ignore_invalid_headers off;

According to RFC 2068 an HTTP header name is a "token" http://tools.ietf.org/html/rfc2068

token = 1*<any CHAR except CTLs or tspecials>

tspecials = "(" | ")" | "<" | ">" | "@"

","	";"	":"	"\"	<">
"/"	"[" \| "]"	"?"	"="
" {" \| "} "	SP	HT

which allows the "." character, but it is apparently uncommon enough to be rejected by nginx.

Show

Ted Goddard added a comment - 05/Jun/14 11:57 AM Additional configuration for nginx was required since it rejects the "invalid" . separator in the ICEpush headers. This can be addressed by adding as described in the workaround. ignore_invalid_headers off; According to RFC 2068 an HTTP header name is a "token" http://tools.ietf.org/html/rfc2068 token = 1*<any CHAR except CTLs or tspecials> tspecials = "(" | ")" | "<" | ">" | "@" "," ";" ":" "\" <"> "/" " [" | "] " "?" "=" " {" | "} " SP HT which allows the "." character, but it is apparently uncommon enough to be rejected by nginx.

People

Assignee:

Mircea Toma

Reporter:

Ted Goddard

Votes:

0 Vote for this issue

Watchers:

2 Start watching this issue

Dates

Created:

28/May/14 2:08 PM

Updated:

17/Nov/14 11:16 AM

Resolved:

11/Jun/14 3:22 PM