ICEpush
  1. ICEpush
  2. PUSH-287

IE 10 support

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: Bridge-it 1.0
          • Fix Version/s: Bridge-it 1.0
          • Component/s: JavaScript Client
          • Labels:
            None
          • Environment:
            ICEpush, Internet Explorer 10
          • Assignee Priority:
            P1

            Description

            IE 10 enters an infinite loop of false notifications on IE 10.

              Activity

              Ascending order - Click to sort in descending order
              Ted Goddard created issue -
              Ted Goddard made changes -
              Field Original Value New Value
              Assignee Mircea Toma [ mircea.toma ]
              Hide
              Permalink
              Ted Goddard added a comment -

              Maybe something odd with the local storage events on IE 10?

              Show
              Ted Goddard added a comment - Maybe something odd with the local storage events on IE 10?
              Hide
              Permalink
              Ted Goddard added a comment -

              http://bridgeit.github.io/demo-jqm/cloud-push.html

              Show
              Ted Goddard added a comment - http://bridgeit.github.io/demo-jqm/cloud-push.html
              Ken Fyten made changes -
              Affects Version/s EE-3.3.0.GA_P01 [ 11175 ]
              Ken Fyten made changes -
              Affects Version/s Bridge-it 1.0 [ 11374 ]
              Ken Fyten made changes -
              Fix Version/s Bridge-it 1.0 [ 11374 ]
              Fix Version/s EE-3.3.0.GA_P02 [ 11370 ]
              Ken Fyten made changes -
              Assignee Priority P1 [ 10010 ]
              Hide
              Permalink
              Mircea Toma added a comment - - edited

              The issue occurs due to an oversight in the implementation of the LocalStorageNotificationBroadcaster. The callbacks registered with the localStorage are not filtering on the name of the slot they are observing on. Before we have been using only one slot in the localStorage, but recently we introduce the pushID expiry mechanism who is also using the localStorage. So now the changes in the slots used by pushID expiry mechanism are also triggering the invocation of the callbacks registered for the push notification.

              The fix makes sure that the callback registered with LocalStorageNotificationBroadcaster is invoked only when the localStorage slot (created by LocalStorageNotificationBroadcaster instance) is modified.

              Show
              Mircea Toma added a comment - - edited The issue occurs due to an oversight in the implementation of the LocalStorageNotificationBroadcaster. The callbacks registered with the localStorage are not filtering on the name of the slot they are observing on. Before we have been using only one slot in the localStorage, but recently we introduce the pushID expiry mechanism who is also using the localStorage. So now the changes in the slots used by pushID expiry mechanism are also triggering the invocation of the callbacks registered for the push notification. The fix makes sure that the callback registered with LocalStorageNotificationBroadcaster is invoked only when the localStorage slot (created by LocalStorageNotificationBroadcaster instance) is modified.
              Mircea Toma made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #38758 Fri Nov 08 06:21:41 MST 2013 mircea.toma PUSH-287 Make sure that the callback registered with LocalStorageNotificationBroadcaster is invoked only when the localStorage slot (created by LocalStorageNotificationBroadcaster instance) is modified.
              Files Changed
              Commit graph MODIFY /icepush/trunk/icepush/core/src/main/javascript/inter.window.notification.js
              Hide
              Permalink
              Mircea Toma added a comment -

              The issue occurs in any version of IE because the localStorage events are also fired in the window modifying the localStorage (unlike the Firefox, Safari and Chrome).

              Show
              Mircea Toma added a comment - The issue occurs in any version of IE because the localStorage events are also fired in the window modifying the localStorage (unlike the Firefox, Safari and Chrome).
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Ted Goddard
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: