Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: Bridge-it 1.0
    • Fix Version/s: Bridge-it 1.0
    • Component/s: JavaScript Client
    • Labels:
      None
    • Environment:
      ICEpush, Internet Explorer 10
    • Assignee Priority:
      P1

      Description

      IE 10 enters an infinite loop of false notifications on IE 10.

        Activity

        Hide
        Ted Goddard added a comment -

        Maybe something odd with the local storage events on IE 10?

        Show
        Ted Goddard added a comment - Maybe something odd with the local storage events on IE 10?
        Show
        Ted Goddard added a comment - http://bridgeit.github.io/demo-jqm/cloud-push.html
        Hide
        Mircea Toma added a comment - - edited

        The issue occurs due to an oversight in the implementation of the LocalStorageNotificationBroadcaster. The callbacks registered with the localStorage are not filtering on the name of the slot they are observing on. Before we have been using only one slot in the localStorage, but recently we introduce the pushID expiry mechanism who is also using the localStorage. So now the changes in the slots used by pushID expiry mechanism are also triggering the invocation of the callbacks registered for the push notification.

        The fix makes sure that the callback registered with LocalStorageNotificationBroadcaster is invoked only when the localStorage slot (created by LocalStorageNotificationBroadcaster instance) is modified.

        Show
        Mircea Toma added a comment - - edited The issue occurs due to an oversight in the implementation of the LocalStorageNotificationBroadcaster. The callbacks registered with the localStorage are not filtering on the name of the slot they are observing on. Before we have been using only one slot in the localStorage, but recently we introduce the pushID expiry mechanism who is also using the localStorage. So now the changes in the slots used by pushID expiry mechanism are also triggering the invocation of the callbacks registered for the push notification. The fix makes sure that the callback registered with LocalStorageNotificationBroadcaster is invoked only when the localStorage slot (created by LocalStorageNotificationBroadcaster instance) is modified.
        Hide
        Mircea Toma added a comment -

        The issue occurs in any version of IE because the localStorage events are also fired in the window modifying the localStorage (unlike the Firefox, Safari and Chrome).

        Show
        Mircea Toma added a comment - The issue occurs in any version of IE because the localStorage events are also fired in the window modifying the localStorage (unlike the Firefox, Safari and Chrome).

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Ted Goddard
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: