ICEpush
  1. ICEpush
  2. PUSH-253

Change log levels for the NotificationProviders to INFO for success and FINE for failure

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-3.2.0.GA
          • Fix Version/s: EE-3.3.0.GA
          • Component/s: Push Library
          • Labels:
            None
          • Environment:
            ICEpush-EE

            Description

            We should change the log levels for the various NotificationProviders we have when it comes to success and failure:

            - Success should be logged at Level.INFO
            - Failure should be logged at Level.FINE

              Activity

              Ascending order - Click to sort in descending order
              Jack Van Ooststroom created issue -
              Jack Van Ooststroom made changes -
              Field Original Value New Value
              Assignee Jack Van Ooststroom [ jack.van.ooststroom ]
              Jack Van Ooststroom made changes -
              Status Open [ 1 ] In Progress [ 3 ]
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              Sending core-ee/src/main/java/com/icesoft/icepush/APNSNotificationProvider.java
              Sending core-ee/src/main/java/com/icesoft/icepush/BPNSNotificationProvider.java
              Sending core-ee/src/main/java/com/icesoft/icepush/GcmNotificationProvider.java
              Transmitting file data ...
              Committed revision 34684.

              Show
              Jack Van Ooststroom added a comment - Sending core-ee/src/main/java/com/icesoft/icepush/APNSNotificationProvider.java Sending core-ee/src/main/java/com/icesoft/icepush/BPNSNotificationProvider.java Sending core-ee/src/main/java/com/icesoft/icepush/GcmNotificationProvider.java Transmitting file data ... Committed revision 34684.
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              The following Notification Providers have been updated:

              • AmazonSNSNotificationProvider
              • APNSNotificationProvider
              • BPNSNotificationProvider
              • GcmNotificationProvider
              • LoggingNotificationProvider
              • TwilioSMSNotificationProvider

              At Level.INFO you'll now see something like:

              • "APNS Notification Provider is on"
              • "APNS Notification Provider is off"

              At Level.FINE you'll now see something like:

              • "reason: ..."

              In case the Notification Provider resulted in being off.

              Marking this one as FIXED.

              Show
              Jack Van Ooststroom added a comment - The following Notification Providers have been updated: AmazonSNSNotificationProvider APNSNotificationProvider BPNSNotificationProvider GcmNotificationProvider LoggingNotificationProvider TwilioSMSNotificationProvider At Level.INFO you'll now see something like: "APNS Notification Provider is on" "APNS Notification Provider is off" At Level.FINE you'll now see something like: "reason: ..." In case the Notification Provider resulted in being off. Marking this one as FIXED.
              Jack Van Ooststroom made changes -
              Status In Progress [ 3 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s EE-3.3.0.GA [ 10575 ]
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              I was a bit too enthusiast with my changes to APNSNotificationProvider. The Level.SEVERE message that used to be in there shouldn't have been converted. It's a legitimate error message based on incorrect configuration by the user.

              Show
              Jack Van Ooststroom added a comment - I was a bit too enthusiast with my changes to APNSNotificationProvider. The Level.SEVERE message that used to be in there shouldn't have been converted. It's a legitimate error message based on incorrect configuration by the user.
              Jack Van Ooststroom made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              Sending core-ee/src/main/java/com/icesoft/icepush/APNSNotificationProvider.java
              Transmitting file data .
              Committed revision 34728.

              Show
              Jack Van Ooststroom added a comment - Sending core-ee/src/main/java/com/icesoft/icepush/APNSNotificationProvider.java Transmitting file data . Committed revision 34728.
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              The Level.SEVERE logging is back. Marking this one as FIXED.

              Show
              Jack Van Ooststroom added a comment - The Level.SEVERE logging is back. Marking this one as FIXED.
              Jack Van Ooststroom made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Jack Van Ooststroom
                  Reporter:
                  Jack Van Ooststroom
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: