Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: EE-3.2.0.GA
-
Fix Version/s: EE-3.3.0.GA
-
Component/s: Push Library
-
Labels:None
-
Environment:ICEpush-EE
Description
We should change the log levels for the various NotificationProviders we have when it comes to success and failure:
- Success should be logged at Level.INFO
- Failure should be logged at Level.FINE
- Success should be logged at Level.INFO
- Failure should be logged at Level.FINE
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
The following Notification Providers have been updated:
- AmazonSNSNotificationProvider
- APNSNotificationProvider
- BPNSNotificationProvider
- GcmNotificationProvider
- LoggingNotificationProvider
- TwilioSMSNotificationProvider
At Level.INFO you'll now see something like:
- "APNS Notification Provider is on"
- "APNS Notification Provider is off"
At Level.FINE you'll now see something like:
- "reason: ..."
In case the Notification Provider resulted in being off.
Marking this one as FIXED.
Show
Jack Van Ooststroom
added a comment - The following Notification Providers have been updated:
AmazonSNSNotificationProvider
APNSNotificationProvider
BPNSNotificationProvider
GcmNotificationProvider
LoggingNotificationProvider
TwilioSMSNotificationProvider
At Level.INFO you'll now see something like:
"APNS Notification Provider is on"
"APNS Notification Provider is off"
At Level.FINE you'll now see something like:
"reason: ..."
In case the Notification Provider resulted in being off.
Marking this one as FIXED.
I was a bit too enthusiast with my changes to APNSNotificationProvider. The Level.SEVERE message that used to be in there shouldn't have been converted. It's a legitimate error message based on incorrect configuration by the user.
Show
Jack Van Ooststroom
added a comment - I was a bit too enthusiast with my changes to APNSNotificationProvider. The Level.SEVERE message that used to be in there shouldn't have been converted. It's a legitimate error message based on incorrect configuration by the user.
Sending core-ee/src/main/java/com/icesoft/icepush/APNSNotificationProvider.java
Transmitting file data .
Committed revision 34728.
Show
Jack Van Ooststroom
added a comment - Sending core-ee/src/main/java/com/icesoft/icepush/APNSNotificationProvider.java
Transmitting file data .
Committed revision 34728.
The Level.SEVERE logging is back. Marking this one as FIXED.
Show
Jack Van Ooststroom
added a comment - The Level.SEVERE logging is back. Marking this one as FIXED.
Sending core-ee/src/main/java/com/icesoft/icepush/APNSNotificationProvider.java
Sending core-ee/src/main/java/com/icesoft/icepush/BPNSNotificationProvider.java
Sending core-ee/src/main/java/com/icesoft/icepush/GcmNotificationProvider.java
Transmitting file data ...
Committed revision 34684.