ICEpush
  1. ICEpush
  2. PUSH-244

Turning on Level.FINE logging breaks setting the NotifyBackURI

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-3.2.0.GA, 3.3
          • Fix Version/s: EE-3.3.0.GA, 4.0.BETA, 4.0
          • Component/s: Push Library
          • Labels:
            None
          • Environment:
            ICEpush, Mobile Device
          • Workaround Exists:
            Yes
          • Workaround Description:
            Turn off Level.FINE logging for org.icepush.BlockingConnectionServer

            Description

            If the Level.FINE logging is switched on for ICEpush, the NotifyBackURI appears not to be set on the PushID object.

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              Sending src/main/java/org/icepush/BlockingConnectionServer.java
              Transmitting file data .
              Committed revision 35650.

              Show
              Jack Van Ooststroom added a comment - Sending src/main/java/org/icepush/BlockingConnectionServer.java Transmitting file data . Committed revision 35650.
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              In one of the logging blocks in BlockingConnectionServer, namely for logging the "ICEpush metric", within this block the NotifyBackURI is also trying to be set, but only on the BlockingConnectionServer and not on the corresponding PushID instances. Retrieving the NotifyBackURI from the Request or the PushGroupManager is now moved into a separate private method, and both the logging block and the handling of the request now invoke this method, ensuring the new NotifyBackURI is set on both the BlockingConnectionServer and PushID. Even though I find it strange that we have this logic inside a logging block as well, I decided to leave the invocation of the new method in there for timing purposes of when the logging is printed. Marking this one as FIXED.

              Show
              Jack Van Ooststroom added a comment - In one of the logging blocks in BlockingConnectionServer, namely for logging the "ICEpush metric", within this block the NotifyBackURI is also trying to be set, but only on the BlockingConnectionServer and not on the corresponding PushID instances. Retrieving the NotifyBackURI from the Request or the PushGroupManager is now moved into a separate private method, and both the logging block and the handling of the request now invoke this method, ensuring the new NotifyBackURI is set on both the BlockingConnectionServer and PushID. Even though I find it strange that we have this logic inside a logging block as well, I decided to leave the invocation of the new method in there for timing purposes of when the logging is printed. Marking this one as FIXED.

                People

                • Assignee:
                  Jack Van Ooststroom
                  Reporter:
                  Jack Van Ooststroom
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: