Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 3.1
-
Fix Version/s: 4.0 - Beta, 4.0
-
Component/s: Viewer RI
-
Labels:None
-
Environment:-
Description
When setting fit to width, the page zooms towards the center rather than
positioning itself at the top. The customer would like us to consider this fix
for our next release. Here is what he has done:
I got this working by modifying the setFitMode(int) method as follows:
At the bottom of the method I replaced the call to setZoom(newZoom, null, true)
with the following logic:
// set appropriate zoom level
// If we're scrolled all the way to the top, center to top of document when zoom.
if (getVerticalScrollBar().getValue() == 0)
{
setZoom(newZoom, new Point(0, 0), true);
}
else
{
setZoom(newZoom, null, true);
}
positioning itself at the top. The customer would like us to consider this fix
for our next release. Here is what he has done:
I got this working by modifying the setFitMode(int) method as follows:
At the bottom of the method I replaced the call to setZoom(newZoom, null, true)
with the following logic:
// set appropriate zoom level
// If we're scrolled all the way to the top, center to top of document when zoom.
if (getVerticalScrollBar().getValue() == 0)
{
setZoom(newZoom, new Point(0, 0), true);
}
else
{
setZoom(newZoom, null, true);
}
Activity
| Field | Original Value | New Value |
|---|---|---|
| Salesforce Case | [50070000007C5dh] |
| Fix Version/s | 3.2 [ 10212 ] |
I have attached the patch file which I've submitted as a contribution to be considered for a future release.
Show
Ken Walker
added a comment - I have attached the patch file which I've submitted as a contribution to be considered for a future release.
| Attachment | DocumentViewControllerImpl.java.patch [ 12079 ] |
Thanks Ken, I'll make sure it gets added to the next release.
Show
Patrick Corless
added a comment - Thanks Ken, I'll make sure it gets added to the next release.
| Assignee | Patrick Corless [ patrick.corless ] | Carlo Guglielmin [ carlo.guglielmin ] |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #19892 | Tue Dec 08 15:43:31 MST 2009 | carlo.guglielmin | |
| Files Changed | ||||
MODIFY
/icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/common/views/DocumentViewControllerImpl.java
|
I tested and applied this patch in revision 19892. Thanks Ken Walker!
Show
Carlo Guglielmin
added a comment - I tested and applied this patch in revision 19892. Thanks Ken Walker!
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Salesforce Case | [50070000007C5dh] | [50070000007C5dh, 5007000000ApPDh] |
| Fix Version/s | 4.0 [ 10222 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
Just to clarify the issue, I don't necessarily want it to scroll to the top whenever you set fit to width...only if you're already scrolled to the top.