ICEpdf
  1. ICEpdf
  2. PDF-550

Annotation edit panes incorrectly setting enabled/disable states

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 5.0.0 alpha1, 5.0.0 beta1
          • Fix Version/s: 5.0
          • Component/s: Viewer RI
          • Labels:
            None
          • Environment:
            Viewer RI

            Description

            While doing some GUI testing I came across an issue where the disable state of input fields was not being set correctly.

              Activity

              Descending order - Click to sort in ascending order
              Patrick Corless made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #34215 Wed Apr 03 14:23:42 MDT 2013 patrick.corless PDF-550 correct some enable/disable state bugs with the annotation edit panels.
              Files Changed
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/common/utility/annotation/AnnotationPanel.java
              Commit graph MODIFY /icepdf/trunk/icepdf/core/src/org/icepdf/core/pobjects/annotations/FreeTextAnnotation.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/common/tools/ZoomInPageHandler.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/common/views/PageViewComponentImpl.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/common/tools/FreeTextAnnotationHandler.java
              Commit graph MODIFY /icepdf/trunk/icepdf/core/src/org/icepdf/core/pobjects/annotations/CircleAnnotation.java
              Patrick Corless made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Patrick Corless added a comment -

              Updated the disable/enable logic as well as touched up two tools which where not painting there selection boxes correctly.

              Show
              Patrick Corless added a comment - Updated the disable/enable logic as well as touched up two tools which where not painting there selection boxes correctly.
              Hide
              Permalink
              Patrick Corless added a comment -

              As it turns out there wasn't just one issue but many. The main culprit was related to enable/disabling all input items based on the an annotation edit-ability. This call was made after the individual panel logic ran and negated any previous settings.

              Show
              Patrick Corless added a comment - As it turns out there wasn't just one issue but many. The main culprit was related to enable/disabling all input items based on the an annotation edit-ability. This call was made after the individual panel logic ran and negated any previous settings.
              Patrick Corless made changes -
              Field Original Value New Value
              Fix Version/s 5.0 [ 10314 ]
              Patrick Corless created issue -

                People

                • Assignee:
                  Patrick Corless
                  Reporter:
                  Patrick Corless
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: