ICEmobile
  1. ICEmobile
  2. MOBI-727

carousel not working properly after ajax update on android stock browser and container

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 1.3 Beta
    • Fix Version/s: 1.4 Beta
    • Component/s: Faces, JSP
    • Labels:
      None
    • Environment:
      icemobile all

      Description

      carousel freezes after ajax update or (container) wil not accept updated value and will return to original selected value in mobileshowcase and icemobilespring apps

        Activity

        Judy Guglielmin created issue -
        Hide
        Judy Guglielmin added a comment - - edited

        thought could have been introduced with work done on MOBI-637, but when this was backed out to code from 12/11/25 (rev 32370) as only carousel.js and CarouselRenderer had minor changes from MOBI-637, the problem still exists. Could problem stem from mojarra 2.1.21 or icefaces 3.3 or container? Problems getting js logging statements to console on devices available for android.

        Show
        Judy Guglielmin added a comment - - edited thought could have been introduced with work done on MOBI-637 , but when this was backed out to code from 12/11/25 (rev 32370) as only carousel.js and CarouselRenderer had minor changes from MOBI-637 , the problem still exists. Could problem stem from mojarra 2.1.21 or icefaces 3.3 or container? Problems getting js logging statements to console on devices available for android.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #34989 Mon May 13 12:04:49 MDT 2013 judy.guglielmin MOBI-727 JSP fixed minor js error. JSP carousel now working in android, iOS, desktop for icemobilespring
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/javascript/icemobile.js
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #35023 Tue May 14 17:18:32 MDT 2013 ted.goddard render tabset script conditionally inside a fixed span (MOBI-727)
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/BaseCoreRenderer.java
        Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/TabSetCoreRenderer.java
        Hide
        Ted Goddard added a comment -

        A new API has been added to BaseCoreRenderer:

        + public void writeExternalScript(IMobiComponent component, IResponseWriter writer, String url, boolean required)

        The required attribute indicates whether the script within the span is required or not; if not required, only the span is rendered. This allows components to add their JavaScript to the page as necessary and have it removed in subsequent updates without causing a large DOM diff. This was added to prevent TabSet from causing a large DOM diff on the carousel page. There may be a variety of other components that need a similar change.

        Show
        Ted Goddard added a comment - A new API has been added to BaseCoreRenderer: + public void writeExternalScript(IMobiComponent component, IResponseWriter writer, String url, boolean required) The required attribute indicates whether the script within the span is required or not; if not required, only the span is rendered. This allows components to add their JavaScript to the page as necessary and have it removed in subsequent updates without causing a large DOM diff. This was added to prevent TabSet from causing a large DOM diff on the carousel page. There may be a variety of other components that need a similar change.
        Judy Guglielmin made changes -
        Field Original Value New Value
        Fix Version/s 1.4 Beta [ 10874 ]
        Fix Version/s 1.3 Beta [ 10373 ]
        Hide
        Judy Guglielmin added a comment -

        Any further modifications (removal of callback for DomSubtreeMOdified event, ensuring refresh callback also gets registered for full submit), further support for ajax page update, will be done in 1.4 Beta
        iScroll 5 to be released shortly, so can be done together for 1.4 Beta

        Show
        Judy Guglielmin added a comment - Any further modifications (removal of callback for DomSubtreeMOdified event, ensuring refresh callback also gets registered for full submit), further support for ajax page update, will be done in 1.4 Beta iScroll 5 to be released shortly, so can be done together for 1.4 Beta
        Judy Guglielmin made changes -
        Assignee Judy Guglielmin [ judy.guglielmin ] Steve Maryka [ steve.maryka ]

          People

          • Assignee:
            Steve Maryka
            Reporter:
            Judy Guglielmin
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated: