ICEmobile
  1. ICEmobile
  2. MOBI-640

rework tabset component to use core rendering strategy

          Details

          • Type: Improvement Improvement
          • Status: Resolved
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.2 Final
          • Fix Version/s: 1.3 Beta
          • Component/s: Faces, Spring
          • Labels:
            None
          • Environment:
            icemobile

            Description

            currently many open jira's for tabset. Will link to this one and deal with them for tablet.

            1) use common core rendering
            2) proper rendering of bottom orientation and get working for large view
            3) correct state regardless of whether contentPanes are client or not.
            4) common attributes between jsf and jsp
            5) disabled support

              Issue Links

              blocks

              Bug - A problem which impairs or prevents the functions of the product. MOBI-415 JSF TabSet has unimplemented tabChangeListener attribute

              • Major - Major loss of function.
              • Resolved

              Bug - A problem which impairs or prevents the functions of the product. MOBI-433 TabSet orientation bottom doesn't work with ipad or honeycomb themes

              • Major - Major loss of function.
              • Resolved

              Bug - A problem which impairs or prevents the functions of the product. MOBI-629 TabSet does not synchronize selected tab

              • Major - Major loss of function.
              • Resolved

              Task - A task that needs to be done. MOBI-414 JSF and JSP TabSet components have different apis

              • Major - Major loss of function.
              • Resolved

                Activity

                Ascending order - Click to sort in descending order
                Judy Guglielmin created issue -
                Judy Guglielmin made changes -
                Field Original Value New Value
                Link This issue blocks MOBI-629 [ MOBI-629 ]
                Judy Guglielmin made changes -
                Link This issue blocks MOBI-415 [ MOBI-415 ]
                Judy Guglielmin made changes -
                Link This issue blocks MOBI-414 [ MOBI-414 ]
                Judy Guglielmin made changes -
                Link This issue blocks MOBI-433 [ MOBI-433 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #33519 Tue Feb 19 17:47:17 MST 2013 judy.guglielmin MOBI-640 checkin of tabset component using common core rendering as much as possible. Did not remove old JSP component which still works. New jsp component usage will appear in new jsp test app (see MOBI-;659)
                Files Changed
                Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.tabset/tabset.js
                Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/tabset/TabSetMeta.java
                Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/resources/META-INF/icemobile.tld
                Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layout/tabsetBasic/tabSet.xhtml
                Commit graph ADD /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/TabSetCoreRenderer.java
                Commit graph ADD /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/component/ITabPane.java
                Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/tabset/TabSet.java
                Commit graph ADD /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/component/ITabSet.java
                Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/javascript/icemobile.js
                Commit graph ADD /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/TabPaneCoreRenderer.java
                Commit graph ADD /icemobile/trunk/icemobile/jsp/src/main/java/org/icemobile/jsp/tags/layout/TabPaneTag.java
                Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/java/org/icefaces/mobile/layout/LayoutBean.java
                Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/tabset/TabSetRenderer.java
                Commit graph ADD /icemobile/trunk/icemobile/jsp/src/main/java/org/icemobile/jsp/tags/layout/TabSetControlTag.java
                Hide
                Permalink
                Judy Guglielmin added a comment -

                rev 33519 has initial checkin of tabSet where disabled is implemented in JSF, core rendering is used as much as is possible (not a lot) and common interface to ensure attributes are same.
                JSP has new tabSetController component which only takes child of tabPane
                <mobi:tabSetControl id="tabsetOne"
                orientation="$

                {tabInfo.orientation}

                "
                autoWidth="$

                {tabInfo.autoWidth}

                "
                disabled="$

                {tabInfo.disabled}

                "
                height="$

                {tabInfo.height}

                "
                autoHeight="$

                {tabInfo.autoHeight}

                "
                style="$

                {tabInfo.style}

                "
                styleClass="$

                {tabInfo.styleClass}

                "
                selectedId="$

                {tabInfo.selectedId}

                ">
                <mobi:tabPane id="pane1" title="Sailor">
                <%@ include file="../includes/pane1.jsp"%>
                </mobi:tabPane>
                <mobi:tabPane id="pane2" title="Breaker">
                <%@ include file="../includes/pane2.jsp"%>
                </mobi:tabPane>
                <mobi:tabPane id="pane3" title="Skate">
                <%@ include file="../includes/pane3.jsp"%>
                </mobi:tabPane>
                </mobi:tabSetControl>

                buffered approach taken with new tags. Still some work to do to enhance performance, but tests in new JSP test app show promise. (MOBI-659 test app not yet checked in).

                Show
                Judy Guglielmin added a comment - rev 33519 has initial checkin of tabSet where disabled is implemented in JSF, core rendering is used as much as is possible (not a lot) and common interface to ensure attributes are same. JSP has new tabSetController component which only takes child of tabPane <mobi:tabSetControl id="tabsetOne" orientation="$ {tabInfo.orientation} " autoWidth="$ {tabInfo.autoWidth} " disabled="$ {tabInfo.disabled} " height="$ {tabInfo.height} " autoHeight="$ {tabInfo.autoHeight} " style="$ {tabInfo.style} " styleClass="$ {tabInfo.styleClass} " selectedId="$ {tabInfo.selectedId} "> <mobi:tabPane id="pane1" title="Sailor"> <%@ include file="../includes/pane1.jsp"%> </mobi:tabPane> <mobi:tabPane id="pane2" title="Breaker"> <%@ include file="../includes/pane2.jsp"%> </mobi:tabPane> <mobi:tabPane id="pane3" title="Skate"> <%@ include file="../includes/pane3.jsp"%> </mobi:tabPane> </mobi:tabSetControl> buffered approach taken with new tags. Still some work to do to enhance performance, but tests in new JSP test app show promise. ( MOBI-659 test app not yet checked in).
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #33525 Wed Feb 20 13:07:34 MST 2013 judy.guglielmin MOBI-640 minor fix for autoHeight attribute
                Files Changed
                Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.tabset/tabset.js
                Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/javascript/icemobile.js
                Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/BaseCoreRenderer.java
                Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/TabSetCoreRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #33592 Mon Feb 25 11:17:44 MST 2013 judy.guglielmin MOBI-640 when no client side behavior, content Pane renderer must write the correct classes for visible contentPane
                Files Changed
                Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/contentpane/ContentPaneRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #33675 Wed Feb 27 10:48:15 MST 2013 judy.guglielmin MOBI-640, MOBI-667 mobileshowcase uses defaultId attribute in tabSet composite component implementation and selectedId was resolving to null. Put defaultId into ITabSet but it's not currently used as a tag attribute in JSP (strictly used for JSF, but cannot be useful for tag handler as tag handler in JSF requires a value for selectedId BEFORE the component is added to the tree)
                Files Changed
                Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/tabset/TabSetMeta.java
                Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.tabset/tabset.js
                Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/contentpane/ContentPaneRenderer.java
                Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/tabset/TabSetRenderer.java
                Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/component/ITabPane.java
                Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/java/org/icemobile/jsp/tags/layout/TabSetControlTag.java
                Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/tabset/TabSet.java
                Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/renderkit/BaseLayoutRenderer.java
                Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/component/ITabSet.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #33682 Wed Feb 27 17:03:01 MST 2013 judy.guglielmin MOBI-640, 667. attribute of currentId was changed to selectedId to make similar to accordion and some other Jira reference specifying to do so, but samples were not updated to reflect this.
                Files Changed
                Commit graph MODIFY /icemobile/trunk/icemobile/samples/mediacast/src/main/webapp/WEB-INF/includes/views/small.xhtml
                Commit graph MODIFY /icemobile/trunk/icemobile/samples/mediacast/src/main/webapp/WEB-INF/includes/views/large.xhtml
                Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/tabset-example.xhtml
                Steve Maryka made changes -
                Assignee Steve Maryka [ steve.maryka ] Judy Guglielmin [ judy.guglielmin ]
                Hide
                Permalink
                Judy Guglielmin added a comment -

                old style tabSet still available so any other work on this could be done with new Jira.

                Show
                Judy Guglielmin added a comment - old style tabSet still available so any other work on this could be done with new Jira.
                Judy Guglielmin made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Fix Version/s 1.3 Beta [ 10373 ]
                Resolution Fixed [ 1 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #34752 Mon May 06 15:37:44 MDT 2013 judy.guglielmin MOBI-640 correct auto-detect of parentFooter and parentHeader for JSF. No longer require these attributes for tabSet in JSF.
                Files Changed
                Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layout/tabsetBasic/tabSet.xhtml
                Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/java/org/icefaces/mobile/layout/LayoutBean.java
                Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/tabset/TabSetRenderer.java
                Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/tabset/TabSet.java
                Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/tabset-example.xhtml

                  People

                  • Assignee:
                    Judy Guglielmin
                    Reporter:
                    Judy Guglielmin
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    1 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: